Subject: Re: [PATCH SLOF] pci-properties: Remove redundant call to device-type

From: Alexey Kardashevskiy <[email-masked]>
Date: Wed, 11 Mar 2015 20:13:11 +1100

On 03/11/2015 07:21 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2015-03-11 at 08:50 +0100, Thomas Huth wrote:
>>
>> - Graphic cards should get the "display" device_type ... I guess
>> that's
>>    missing now?
>
> At least the code for qemu-vga does it
>
>> - pci bus nodes (like bridges) should get the "pci" device_type
>>    according to the Open Firmware PCI binding, is this still the case?
>
> Ah yes we need to check that, specifically P2P bridges
>
>> - Seems like there are some other devices with device_type property
>>    where SLOF does not provide an implemented interface, like in
>>    slof/fs/usb/dev-mouse.fs ... should these be revised, too?
>
> not a *huge* issue but we can look into it when needed.

Then I better remove it now as well, any reason to wait for "when needed"?

-- 
Alexey