From: Cedric Le Goater <clg@fr•ibm.com>
To: Guenter Roeck <linux@roeck-us•net>
Cc: Stewart Smith <stewart@linux•vnet.ibm.com>,
lm-sensors@lm-sensors•org,
Neelesh Gupta <neelegup@linux•vnet.ibm.com>,
skiboot@lists•ozlabs.org, linuxppc-dev@lists•ozlabs.org,
Jean Delvare <jdelvare@suse•de>
Subject: Re: [PATCH 2/4] hwmon: (ibmpowernv) add support for the new device tree
Date: Wed, 08 Apr 2015 18:06:03 +0200 [thread overview]
Message-ID: <552551EB.9020808@fr.ibm.com> (raw)
In-Reply-To: <20150408152029.GA11030@roeck-us.net>
On 04/08/2015 05:20 PM, Guenter Roeck wrote:
> On Wed, Apr 01, 2015 at 12:15:04PM +0200, Cédric Le Goater wrote:
>> The new OPAL device tree for sensors has a different layout and uses new
>> property names, for the type and for the handler used to capture the
>> sensor data.
>>
>> This patch modifies the ibmpowernv driver to support such a tree in a
>> way preserving compatibility with older OPAL firmwares.
>>
>> This is achieved by changing the error path of the routine parsing
>> an OPAL node name. The node is simply considered being from the new
>> device tree layout and fallback values are used.
>>
>> Signed-off-by: Cédric Le Goater <clg@fr•ibm.com>
>
> Hi Cedric,
>
> I was about to apply the series, but then I found the following problem.
>
>> ---
>> drivers/hwmon/ibmpowernv.c | 47 +++++++++++++++++++++++++++++++++++---------
>> 1 file changed, 38 insertions(+), 9 deletions(-)
>>
> [ ... ]
>>
>> @@ -189,11 +204,16 @@ static u32 get_sensor_hwmon_index(struct sensor_data *sdata,
>> {
>> int i;
>>
>> - for (i = 0; i < count; i++)
>> - if (sdata_table[i].opal_index == sdata->opal_index &&
>> - sdata_table[i].type == sdata->type)
>> - return sdata_table[i].hwmon_index;
>> + /*
>> + * We don't use the OPAL index on newer device trees
>> + */
>> + if (sdata->opal_index != -1) {
>
> opal_index is u32, so this won't work (or at least the result is
> unpredictable).
>
> Also, in patch 4/4 (v4), get_logical_cpu() takes unsigned int as parameter,
> but get_hard_smp_processor_id() returns an int, causing gcc to complain
> if the code is built with W=1.
>
> Please fix and resubmit the entire series.
>
> When you do that, please also ensure that continuation lines
> are aligned (in patch 3/4).
Sure. Working on it right now.
Thanks,
C.
next prev parent reply other threads:[~2015-04-08 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 15:20 [PATCH 2/4] hwmon: (ibmpowernv) add support for the new device tree Guenter Roeck
2015-04-08 16:06 ` Cedric Le Goater [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-19 17:44 [PATCH v2 0/5] hwmon: (ibmpowernv) remove dependency on OPAL index Cédric Le Goater
2015-04-01 10:15 ` [PATCH 2/4] hwmon: (ibmpowernv) add support for the new device tree Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552551EB.9020808@fr.ibm.com \
--to=clg@fr$(echo .)ibm.com \
--cc=jdelvare@suse$(echo .)de \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lm-sensors@lm-sensors$(echo .)org \
--cc=neelegup@linux$(echo .)vnet.ibm.com \
--cc=skiboot@lists$(echo .)ozlabs.org \
--cc=stewart@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox