From: Sudeep Holla <sudeep.holla@arm•com>
To: Preeti U Murthy <preeti@linux•vnet.ibm.com>
Cc: "rlippert@google•com" <rlippert@google•com>,
"daniel.lezcano@linaro•org" <daniel.lezcano@linaro•org>,
"linux-pm@vger•kernel.org" <linux-pm@vger•kernel.org>,
"peterz@infradead•org" <peterz@infradead•org>,
"linus.walleij@linaro•org" <linus.walleij@linaro•org>,
"rafael.j.wysocki@intel•com" <rafael.j.wysocki@intel•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"mingo@redhat•com" <mingo@redhat•com>,
Sudeep Holla <sudeep.holla@arm•com>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] cpuidle: Handle tick_broadcast_enter() failure gracefully
Date: Thu, 07 May 2015 10:56:45 +0100 [thread overview]
Message-ID: <554B36DD.5080807@arm.com> (raw)
In-Reply-To: <20150507052600.20882.39542.stgit@preeti.in.ibm.com>
Hi Preeti,
On 07/05/15 06:26, Preeti U Murthy wrote:
> When a CPU has to enter an idle state where tick stops, it makes a call
> to tick_broadcast_enter(). The call will fail if this CPU is the
> broadcast CPU. Today, under such a circumstance, the arch cpuidle code
> handles this CPU. This is not convincing because not only are we not
> aware what the arch cpuidle code does, but we also do not account for
> the idle state residency time and usage of such a CPU.
>
> This scenario can be handled better by simply asking the cpuidle
> governor to choose an idle state where in ticks do not stop. To
> accommodate this change move the setting of runqueue idle state from the
> core to the cpuidle driver, else the rq->idle_state will be set wrong.
>
> Signed-off-by: Preeti U Murthy <preeti@linux•vnet.ibm.com>
> ---
> Based on linux-pm/bleeding-edge
I am unable to apply this patch cleanly on linux-pm/bleeding-edge
I think it conflicts with few patches that Rafael posted recently
which are in the branch now.
Regards,
Sudeep
next prev parent reply other threads:[~2015-05-07 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 5:26 [PATCH] cpuidle: Handle tick_broadcast_enter() failure gracefully Preeti U Murthy
2015-05-07 9:56 ` Sudeep Holla [this message]
2015-05-07 17:49 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B36DD.5080807@arm.com \
--to=sudeep.holla@arm$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=preeti@linux$(echo .)vnet.ibm.com \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rlippert@google$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox