From: Timur Tabi <timur@tabi•org>
To: "Maciej S. Szmigiero" <mail@maciej•szmigiero.name>,
"alsa-devel@alsa-project•org" <alsa-devel@alsa-project•org>
Cc: Nicolin Chen <nicoleotsuka@gmail•com>,
Xiubo Li <Xiubo.Lee@gmail•com>,
Liam Girdwood <lgirdwood@gmail•com>,
Mark Brown <broonie@kernel•org>, Jaroslav Kysela <perex@perex•cz>,
Takashi Iwai <tiwai@suse•de>,
linuxppc-dev@lists•ozlabs.org,
linux-kernel <linux-kernel@vger•kernel.org>,
Fabio Estevam <festevam@gmail•com>
Subject: Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates
Date: Sun, 28 Jun 2015 09:01:50 -0500 [thread overview]
Message-ID: <558FFE4E.703@tabi.org> (raw)
In-Reply-To: <558FFAC4.2060608@maciej.szmigiero.name>
Maciej S. Szmigiero wrote:
> /* Are the RX and the TX clocks locked? */
> if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) {
> - ssi_private->cpu_dai_drv.symmetric_rates = 1;
> + if (!fsl_ssi_is_ac97(ssi_private))
> + ssi_private->cpu_dai_drv.symmetric_rates = 1;
> +
Is this necessary? Why not just add fsl,ssi-asynchronous to the AC97
device tree node?
next prev parent reply other threads:[~2015-06-28 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 13:46 [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates Maciej S. Szmigiero
2015-06-28 14:01 ` Timur Tabi [this message]
2015-06-28 19:12 ` Maciej S. Szmigiero
-- strict thread matches above, loose matches on Subject: below --
2015-07-30 14:34 Maciej S. Szmigiero
2015-07-31 5:27 ` Markus Pargmann
2015-07-31 5:53 ` Markus Pargmann
2015-07-31 14:38 ` Maciej S. Szmigiero
2015-08-02 18:46 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558FFE4E.703@tabi.org \
--to=timur@tabi$(echo .)org \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=festevam@gmail$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mail@maciej$(echo .)szmigiero.name \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox