From: Thomas Huth <thuth@redhat•com>
To: Sam Bobroff <sam.bobroff@au1•ibm.com>,
kvm-ppc@vger•kernel.org, Alexander Graf <agraf@suse•de>
Cc: paulus@samba•org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v3 1/1] KVM: PPC: Book3S: correct width in XER handling
Date: Thu, 16 Jul 2015 23:13:25 +0200 [thread overview]
Message-ID: <55A81E75.5030200@redhat.com> (raw)
In-Reply-To: <edf0cbb1d82070438f6b03f55e35347ef996503d.1432684609.git.sam.bobroff@au1.ibm.com>
On 05/27/2015 01:56 AM, Sam Bobroff wrote:
> In 64 bit kernels, the Fixed Point Exception Register (XER) is a 64
> bit field (e.g. in kvm_regs and kvm_vcpu_arch) and in most places it is
> accessed as such.
>
> This patch corrects places where it is accessed as a 32 bit field by a
> 64 bit kernel. In some cases this is via a 32 bit load or store
> instruction which, depending on endianness, will cause either the
> lower or upper 32 bits to be missed. In another case it is cast as a
> u32, causing the upper 32 bits to be cleared.
>
> This patch corrects those places by extending the access methods to
> 64 bits.
>
> Signed-off-by: Sam Bobroff <sam.bobroff@au1•ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat•com>
Actually this patch also fixes a bug that SLOF sometimes crashes when a
vCPU gets kicked out of kernel mode (see the following URL for details:
https://bugzilla.redhat.com/show_bug.cgi?id=1178502 ), and I've just
tested that this bug does not occur with this patch anymore, so also:
Tested-by: Thomas Huth <thuth@redhat•com>
next prev parent reply other threads:[~2015-07-16 21:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 23:56 [PATCH v3 1/1] KVM: PPC: Book3S: correct width in XER handling Sam Bobroff
2015-07-16 14:52 ` Laurent Vivier
2015-07-16 21:13 ` Thomas Huth [this message]
2015-08-06 1:25 ` Sam Bobroff
2015-08-06 10:16 ` Laurent Vivier
2015-08-12 18:57 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A81E75.5030200@redhat.com \
--to=thuth@redhat$(echo .)com \
--cc=agraf@suse$(echo .)de \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=sam.bobroff@au1$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox