Subject: Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform

From: Jacek Anaszewski <[email-masked]>
Date: Tue, 28 Jul 2015 13:23:32 +0200

On 28.07.2015 12:14, Benjamin Herrenschmidt wrote:
> On Tue, 2015-07-28 at 08:38 +0200, Jacek Anaszewski wrote:
>>>>> +    /* Register the classdev */
>>>>> +    rc = devm_led_classdev_register(dev, &powernv_led->cdev);
>>>>> +    if (rc) {
>>>>> +        dev_err(dev, "%s: Classdev registration failed for %s\n",
>>>>> +            __func__, powernv_led->cdev.name);
>>>>> +    }
>>
>> Braces are not needed here,
>
> Putting my old maintainer hat on for a minute ... this is serious nit
> picking :-)
>
> Arguably, the function being multi-line, the braces do make the code
> more readable. This is a matter of taste which in such as case
> which isn't a blatant violation of an important rule should be left to
> the choice of the code implementor/maintainer.

I will not insist as checkpatch.pl also doesn't complain
about that.

Vasant, please ignore my remark then.

-- 
Best Regards,
Jacek Anaszewski