Subject: Re: [SLOF] [SLOF PATCH 2/2] fbuffer: Use a smaller cursor

From: Thomas Huth <[email-masked]>
Date: Wed, 29 Jul 2015 08:03:23 +0200

On 29/07/15 05:42, Segher Boessenkool wrote:
> On Wed, Jul 29, 2015 at 01:05:48PM +1000, Alexey Kardashevskiy wrote:
>>>  : fb8-toggle-cursor ( -- )
>>>  	line# fb8-line2addr column# fb8-columns2bytes +
>>> -	char-height 0 ?DO
>>> +	char-height 3 - screen-width screen-depth * * +
>>> +	3 0 ?DO
>>
>> Why not just:
>>
>> -	char-height 0 ?DO
>> +	1 0 ?DO
>>
>> ? What is this magic with screen-width about?
> 
> Thomas' patch draws the cursor as the bottom three lines of a
> character cell; your suggestion would draw it as the top one line.

Right.

> But indeed it could be
> 
>   char-height dup 3 - ?DO ...

Since the loop body expects the framebuffer address on the stack, the
loop boundaries are just used to count the iterations ... so "3 0"
sounds like the easiest and most readable way to specify this IMHO.

 Thomas