From: Anshuman Khandual <khandual@linux•vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman•id.au>, linuxppc-dev@ozlabs•org
Cc: mikey@neuling•org
Subject: Re: [V3] powerpc/irq: Enable some more exceptions in /proc/interrupts interface
Date: Thu, 06 Aug 2015 18:54:04 +0530 [thread overview]
Message-ID: <55C35FF4.9050001@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150804095726.66D4A1402E2@ozlabs.org>
On 08/04/2015 03:27 PM, Michael Ellerman wrote:
> On Mon, 2015-13-07 at 08:16:06 UTC, Anshuman Khandual wrote:
>> This patch enables facility unavailable exceptions for generic facility,
>> FPU, ALTIVEC and VSX in /proc/interrupts listing by incrementing their
>> newly added IRQ statistical counters as and when these exceptions happen.
>> This also adds couple of helper functions which will be called from within
>> the interrupt handler context to update their statistics. Similarly this
>> patch also enables alignment and program check exceptions as well.
>
> ...
>
>> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
>> index 0a0399c2..a86180c 100644
>> --- a/arch/powerpc/kernel/exceptions-64s.S
>> +++ b/arch/powerpc/kernel/exceptions-64s.S
>> @@ -1158,6 +1158,7 @@ BEGIN_FTR_SECTION
>> END_FTR_SECTION_IFSET(CPU_FTR_TM)
>> #endif
>> bl load_up_fpu
>> + bl fpu_unav_exceptions_count
>
> Is it safe to call C code here?
Hmm, is it not ? I had that question but was not really sure. Dont
understand the difference between 'fast_exception_return' and
'ret_from_except' completely. Will converting the following sequence
of code
bl load_up_fpu
+ bl fpu_unav_exceptions_count
b fast_exception_return
into
bl load_up_fpu
RECONCILE_IRQ_STATE(r10, r11)
addi r3,r1,STACK_FRAME_OVERHEAD
+ bl fpu_unav_exceptions_count
b ret_from_except
help solve the problem ?
next prev parent reply other threads:[~2015-08-06 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 8:16 [PATCH V3] powerpc/irq: Enable some more exceptions in /proc/interrupts interface Anshuman Khandual
2015-07-21 8:13 ` Anshuman Khandual
2015-08-04 9:57 ` [V3] " Michael Ellerman
2015-08-06 13:24 ` Anshuman Khandual [this message]
2015-08-14 2:52 ` Michael Ellerman
2015-08-19 13:54 ` Anshuman Khandual
2015-08-09 2:27 ` Benjamin Herrenschmidt
2015-08-12 8:38 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C35FF4.9050001@linux.vnet.ibm.com \
--to=khandual@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox