From: Paolo Bonzini <pbonzini@redhat•com>
To: Nicholas Krause <xerofoify@gmail•com>, agraf@suse•com
Cc: gleb@kernel•org, kvm-ppc@vger•kernel.org, kvm@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing
Date: Fri, 7 Aug 2015 15:59:28 +0200 [thread overview]
Message-ID: <55C4B9C0.5030102@redhat.com> (raw)
In-Reply-To: <1438955228-30116-1-git-send-email-xerofoify@gmail.com>
On 07/08/2015 15:47, Nicholas Krause wrote:
> - kvm_set_irq_routing(opp->kvm, routing, 0, 0);
> + ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
> + if (ret) {
> + kfree(routing);
> + return ret;
> + }
>
> kfree(routing);
> return 0;
You could just return ret here. The new "if" is not necessary.
Paolo
next prev parent reply other threads:[~2015-08-07 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 13:47 [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing Nicholas Krause
2015-08-07 13:59 ` Paolo Bonzini [this message]
2015-08-07 14:00 ` nick
-- strict thread matches above, loose matches on Subject: below --
2015-08-06 17:13 Nicholas Krause
2015-08-07 10:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C4B9C0.5030102@redhat.com \
--to=pbonzini@redhat$(echo .)com \
--cc=agraf@suse$(echo .)com \
--cc=gleb@kernel$(echo .)org \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=xerofoify@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox