Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing

From: nick <[email-masked]>
Date: Fri, 07 Aug 2015 10:00:52 -0400

On 2015-08-07 09:59 AM, Paolo Bonzini wrote:
> 
> 
> On 07/08/2015 15:47, Nicholas Krause wrote:
>> -	kvm_set_irq_routing(opp->kvm, routing, 0, 0);
>> +	ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
>> +	if (ret) {
>> +		kfree(routing);
>> +		return ret;
>> +	}
>>  
>>  	kfree(routing);
>>  	return 0;
> 
> You could just return ret here.  The new "if" is not necessary.
> 
> Paolo
> 

Ok sure that seems fine to be and much simpler then this.
Sorry about the wasting your time with this patch.
Nick