Subject: Re: [4/8] powerpc/slb: Add some helper functions to improve modularization

From: Anshuman Khandual <[email-masked]>
Date: Wed, 12 Aug 2015 12:06:39 +0530

On 08/12/2015 09:41 AM, Michael Ellerman wrote:
> On Wed, 2015-29-07 at 07:10:01 UTC, Anshuman Khandual wrote:
>> > This patch adds the following six helper functions to help improve
>> > modularization and readability of the code.
>> > 
>> > (1) slb_invalidate_all:		Invalidates the entire SLB
>> > (2) slb_invalidate:		Invalidates SLB entries present in PACA
>> > (3) mmu_linear_vsid_flags:	VSID flags for kernel linear mapping
>> > (4) mmu_virtual_vsid_flags:	VSID flags for kernel virtual mapping
>> > (5) mmu_vmemmap_vsid_flags:	VSID flags for kernel vmem mapping
>> > (6) mmu_io_vsid_flags:		VSID flags for kernel I/O mapping
> That's too many changes for one patch, it's certainly not a single logical change.
> 
> I'm happy with all the flag ones being done in a single patch, but please do
> the other two in separate patches.

Sure, will split this into three separate patches, also update the
in-code documentation as suggested on the [5/8] patch and then will
send out a new series.