From: Jacek Anaszewski <j.anaszewski@samsung•com>
To: Vasant Hegde <hegdevasant@linux•vnet.ibm.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail•com>,
linux-leds@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
mpe@ellerman•id.au, rpurdie@rpsys•net, cooloney@gmail•com,
khandual@linux•vnet.ibm.com, j.anaszewski81@gmail•com,
arnd@arndb•de, stewart@linux•vnet.ibm.com,
benh@kernel•crashing.org
Subject: Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform
Date: Wed, 19 Aug 2015 13:54:03 +0200 [thread overview]
Message-ID: <55D46E5B.20203@samsung.com> (raw)
In-Reply-To: <55B7BEA8.7080107@gmail.com>
Hi Vasant,
On 07/28/2015 07:40 PM, Jacek Anaszewski wrote:
> Vasant,
>
> On 28.07.2015 15:40, Vasant Hegde wrote:
>> On 07/27/2015 03:20 PM, Jacek Anaszewski wrote:
>>> Hi Vasant,
>>>
>>> On 27.07.2015 05:41, Vasant Hegde wrote:
>>>> On 07/27/2015 03:11 AM, Jacek Anaszewski wrote:
>>>>> Hi Vasant,
>>>>>
>>>>
>>>> Hi Jacek,
>>>>
>>>>> Two trivial details left. Please find them below.
>>>>
>>>> Thanks for the review/Ack. I'll fix below issues and resend patchset.
>>>>
>>>> I will ask Benh/Michael to take this patchset. But this patchset is
>>>> depending
>>>> on your core changes. Can you confirm that you are pushing that
>>>> patchset in next
>>>> merge window?
>>
>> Jacek,
>>
>>>
>>> Without my core changes your driver won't work with led triggers, but
>>> AFAIR this use case is not relevant for your LEDs? Eventually, we could
>>> produce a patch set adding support for LED triggers if it will be clear
>>> that LED core changes will not be merged in the upcoming merge window.
>>
>> IIUC current LED code doesn't allow me to sleep (without driver specific
>> workqueue). And powernv_led_set() call will sleep. Hence I think it
>> won't work.
>>
>> I did a quick test without your patch. It doesn't seems to be working.
Does brightness setting work properly without work queue?
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-08-19 11:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 5:21 [PATCH v8 0/3] LED driver for PowerNV platform Vasant Hegde
2015-07-25 5:21 ` [PATCH v8 1/3] powerpc/powernv: Add OPAL interfaces for accessing and modifying system LED states Vasant Hegde
2015-07-25 5:21 ` [PATCH v8 2/3] powerpc/powernv: Create LED platform device Vasant Hegde
2015-07-25 5:21 ` [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform Vasant Hegde
2015-07-26 21:41 ` Jacek Anaszewski
2015-07-27 3:41 ` Vasant Hegde
2015-07-27 9:50 ` Jacek Anaszewski
2015-07-28 13:40 ` Vasant Hegde
2015-07-28 17:40 ` Jacek Anaszewski
2015-08-19 11:54 ` Jacek Anaszewski [this message]
2015-08-19 12:06 ` Vasant Hegde
2015-07-28 6:38 ` Jacek Anaszewski
2015-07-28 10:14 ` Benjamin Herrenschmidt
2015-07-28 11:23 ` Jacek Anaszewski
2015-08-18 10:21 ` [v8,3/3] " Michael Ellerman
2015-08-19 8:42 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D46E5B.20203@samsung.com \
--to=j.anaszewski@samsung$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=cooloney@gmail$(echo .)com \
--cc=hegdevasant@linux$(echo .)vnet.ibm.com \
--cc=j.anaszewski81@gmail$(echo .)com \
--cc=jacek.anaszewski@gmail$(echo .)com \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=rpurdie@rpsys$(echo .)net \
--cc=stewart@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox