From: Julien Grall <julien.grall@citrix•com>
To: David Vrabel <david.vrabel@citrix•com>, <xen-devel@lists•xenproject.org>
Cc: Jiri Slaby <jslaby@suse•cz>, <ian.campbell@citrix•com>,
<stefano.stabellini@eu•citrix.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
<linux-kernel@vger•kernel.org>,
Boris Ostrovsky <boris.ostrovsky@oracle•com>,
<linuxppc-dev@lists•ozlabs.org>,
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition
Date: Fri, 28 Aug 2015 16:03:14 +0100 [thread overview]
Message-ID: <55E07832.1010802@citrix.com> (raw)
In-Reply-To: <55D5A42E.7070800@citrix.com>
Hi David,
On 20/08/15 10:55, David Vrabel wrote:
> On 07/08/15 17:46, Julien Grall wrote:
>> The console ring is always based on the page granularity of Xen.
> [...]
>> --- a/drivers/tty/hvc/hvc_xen.c
>> +++ b/drivers/tty/hvc/hvc_xen.c
>> @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void)
>> if (r < 0 || v == 0)
>> goto err;
>> gfn = v;
>> - info->intf = xen_remap(gfn << PAGE_SHIFT, PAGE_SIZE);
>> + info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, PAGE_SIZE);
>
> You need XEN_PAGE_SIZE here I think...
Right, I did the mistake while rebase on my s/mfn/gfn/ series. I will
fix it in the next version.
Regards,
--
Julien Grall
prev parent reply other threads:[~2015-08-28 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438966019-19322-1-git-send-email-julien.grall@citrix.com>
2015-08-07 16:46 ` [PATCH v3 11/20] tty/hvc: xen: Use xen page definition Julien Grall
2015-08-20 9:55 ` [Xen-devel] " David Vrabel
2015-08-28 15:03 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E07832.1010802@citrix.com \
--to=julien.grall@citrix$(echo .)com \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=david.vrabel@citrix$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=ian.campbell@citrix$(echo .)com \
--cc=jslaby@suse$(echo .)cz \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=stefano.stabellini@eu$(echo .)citrix.com \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox