From: Thomas Huth <thuth@redhat•com>
To: Dinar valeev <k0da@opensuse•org>,
linuxppc-dev@lists•ozlabs.org,
Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
Cc: Dinar Valeev <dvaleev@suse•com>
Subject: Re: [PATCH] Fix function keys sequence on USB
Date: Tue, 1 Sep 2015 16:13:14 +0200 [thread overview]
Message-ID: <55E5B27A.8020306@redhat.com> (raw)
In-Reply-To: <1432906201-25009-1-git-send-email-k0da@opensuse.org>
Hi!
May I ask what's the status of this patch? As far as I can see, it has
not been included in the repository yet?
On 29/05/15 15:30, Dinar valeev wrote:
> From: Dinar Valeev <dvaleev@suse•com>
>
> Original issue is home and end keys are not functional in grub2.
> Later I've found other inconsistencies in f1-f12 keys.
>
> "Correct sequence" was crabbed by pressing key on cat running in
> xterm.
>
> Tested with Home, End, F2, Del and F10 keys in grub2
>
> Signed-off-by: Dinar Valeev <dvaleev@suse•com>
> ---
> lib/libusb/usb-hid.c | 40 +++++++++++++++++-----------------------
> 1 file changed, 17 insertions(+), 23 deletions(-)
>
> diff --git a/lib/libusb/usb-hid.c b/lib/libusb/usb-hid.c
> index f0cab8a..ccd5ba9 100644
> --- a/lib/libusb/usb-hid.c
> +++ b/lib/libusb/usb-hid.c
...
> @@ -278,7 +274,7 @@ static void check_key_code(uint8_t *buf)
> case 0x45:
> write_key(0x1b); /* F12 */
> write_key(0x5b);
> - write_key(0x31);
> + write_key(0x32);
> write_key(0x34);
> write_key(0x7e);
> break;
... I'm especially interested in this hunk here. One of our testers ran
into the problem that you can not enter the boot menu when using USB
keyboard (and starting QEMU with "-boot menu=on"), and I think this is
related to this hunk.
Looking at "f12-pressed?" in slof/fs/start-up.fs you can also easily see
that the menu code expects a "32" instead of "31" here, and Dinar's
patch fixes this issue!
Thomas
next prev parent reply other threads:[~2015-09-01 14:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 13:30 [PATCH] Fix function keys sequence on USB Dinar valeev
2015-05-30 9:59 ` [PATCH slof] " Alexey Kardashevskiy
2015-05-30 19:21 ` Dinar Valeev
2015-06-02 9:47 ` [PATCH] " Nikunj A Dadhania
2015-06-02 10:05 ` Dinar Valeev
2015-06-02 10:29 ` Nikunj A Dadhania
2015-06-02 10:43 ` Dinar Valeev
2015-06-02 11:12 ` Thomas Huth
2015-06-02 11:17 ` Dinar Valeev
2015-07-06 7:58 ` Nikunj A Dadhania
2015-09-01 14:13 ` Thomas Huth [this message]
2015-09-01 14:48 ` Dinar Valeev
2015-09-01 15:08 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5B27A.8020306@redhat.com \
--to=thuth@redhat$(echo .)com \
--cc=dvaleev@suse$(echo .)com \
--cc=k0da@opensuse$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox