From: christophe leroy <christophe.leroy@c-s•fr>
To: Scott Wood <scottwood@freescale•com>
Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>,
linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
Joakim Tjernlund <joakim.tjernlund@transmode•se>
Subject: Re: [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600
Date: Fri, 4 Sep 2015 20:00:59 +0200 [thread overview]
Message-ID: <55E9DC5B.4090506@c-s.fr> (raw)
In-Reply-To: <20150904164349.GA10337@home.buserror.net>
Le 04/09/2015 18:43, Scott Wood a écrit :
> On Thu, Sep 03, 2015 at 11:27:03AM +0200, Christophe Leroy wrote:
>> On PPC832x, perf record/report reports martian addresses
>>
>> 2.62% perf_reseau4 libpthread-2.18.so [.] __libc_send
>> 2.56% perf_reseau4 [kernel.kallsyms] [k] __ip_make_skb
>> 1.62% perf_reseau4 [kernel.kallsyms] [k] __ip_append_data.isra.39
>> 1.55% perf_reseau4 [kernel.kallsyms] [k] ip_finish_output
>> 1.33% perf_reseau4 [unknown] [k] 0x7ffffd94
>> 1.33% perf_reseau4 [unknown] [k] 0x7ffffd95
>> 1.28% perf_reseau4 [unknown] [k] 0x7ffffd97
>> 1.26% perf_reseau4 [unknown] [k] 0x7ffffda3
>> 1.24% perf_reseau4 [unknown] [k] 0x7ffffd98
>> 1.22% perf_reseau4 [unknown] [k] 0x7ffffd92
>> 1.22% perf_reseau4 [unknown] [k] 0x7ffffd9b
>> [.....]
>>
>> This is due to function perf_instruction_pointer() reading SPR SIAR
>> which doesn't exist on e300 core. The perf_instruction_pointer() is
>> redefined in arch/powerpc/perf/core-book3s.c when CONFIG_PPC_PERF_CTRS
>> is selected.
>>
>> This patch moves the selection of CONFIG_PPC_HAVE_PMU in 86xx section
>> so that CONFIG_PPC_PERF_CTRS won't be selected for other 6xx powerpc
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s•fr>
> So, what happens when a kernel is built that supports both 83xx and 86xx?
Right, so should we define a processor feature for it ?
> Plus, it's e300, not e600, that is the exception among 6xx-style cores.
Is it ? I've been looking for special register SIAR (spr 955) in several
6xx reference manuals.
82xx doesn't have it, 52xx and 512x don't have it.
I found it only in the 86xx
Which other family has it ?
Christophe
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
next prev parent reply other threads:[~2015-09-04 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 9:27 [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600 Christophe Leroy
2015-09-03 9:47 ` Michael Ellerman
2015-09-04 16:43 ` Scott Wood
2015-09-04 18:00 ` christophe leroy [this message]
2015-09-04 18:31 ` Segher Boessenkool
2015-09-04 19:51 ` Segher Boessenkool
2015-09-09 22:24 ` Scott Wood
2015-09-10 0:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E9DC5B.4090506@c-s.fr \
--to=christophe.leroy@c-s$(echo .)fr \
--cc=benh@kernel$(echo .)crashing.org \
--cc=joakim.tjernlund@transmode$(echo .)se \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox