From: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>
To: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>
Cc: benh@kernel•crashing.org, paulus@samba•org, mpe@ellerman•id.au,
anton@samba•org, akpm@linux-foundation•org,
nacc@linux•vnet.ibm.com, gkurz@linux•vnet.ibm.com,
grant.likely@linaro•org, nikunj@linux•vnet.ibm.com,
vdavydov@parallels•com, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org, linux-mm@kvack•org
Subject: Re: [PATCH V2 1/2] mm: Replace nr_node_ids for loop with for_each_node in list lru
Date: Tue, 15 Sep 2015 07:47:26 +0530 [thread overview]
Message-ID: <55F77FB6.7020806@linux.vnet.ibm.com> (raw)
In-Reply-To: <1442282917-16893-2-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
On 09/15/2015 07:38 AM, Raghavendra K T wrote:
> The functions used in the patch are in slowpath, which gets called
> whenever alloc_super is called during mounts.
>
> Though this should not make difference for the architectures with
> sequential numa node ids, for the powerpc which can potentially have
> sparse node ids (for e.g., 4 node system having numa ids, 0,1,16,17
> is common), this patch saves some unnecessary allocations for
> non existing numa nodes.
>
> Even without that saving, perhaps patch makes code more readable.
>
> [ Take memcg_aware check outside for_each loop: Vladimir]
> Signed-off-by: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>
> ---
Sorry that I had misspelled Vladimir above.
next prev parent reply other threads:[~2015-09-15 2:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 2:08 [PATCH V2 0/2] Replace nr_node_ids for loop with for_each_node Raghavendra K T
2015-09-15 2:08 ` [PATCH V2 1/2] mm: Replace nr_node_ids for loop with for_each_node in list lru Raghavendra K T
2015-09-15 2:17 ` Raghavendra K T [this message]
2015-09-15 7:59 ` Vladimir Davydov
2015-09-15 2:08 ` [PATCH V2 2/2] powerpc:numa Do not allocate bootmem memory for non existing nodes Raghavendra K T
2015-09-22 5:29 ` Michael Ellerman
2015-09-22 10:48 ` Raghavendra K T
2015-09-22 19:36 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F77FB6.7020806@linux.vnet.ibm.com \
--to=raghavendra.kt@linux$(echo .)vnet.ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anton@samba$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=gkurz@linux$(echo .)vnet.ibm.com \
--cc=grant.likely@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nacc@linux$(echo .)vnet.ibm.com \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=vdavydov@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox