From: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
To: "Matthew R. Ochs" <mrochs@linux•vnet.ibm.com>,
linux-scsi@vger•kernel.org,
James Bottomley <James.Bottomley@HansenPartnership•com>,
"Nicholas A. Bellinger" <nab@linux-iscsi•org>,
Brian King <brking@linux•vnet.ibm.com>,
Ian Munsie <imunsie@au1•ibm.com>,
Daniel Axtens <dja@ozlabs•au.ibm.com>,
Tomas Henzl <thenzl@redhat•com>,
David Laight <David.Laight@ACULAB•COM>
Cc: Michael Neuling <mikey@neuling•org>,
linuxppc-dev@lists•ozlabs.org,
"Manoj N. Kumar" <manoj@linux•vnet.ibm.com>
Subject: Re: [PATCH v4 12/32] cxlflash: Fix to avoid spamming the kernel log
Date: Tue, 29 Sep 2015 15:05:55 +1000 [thread overview]
Message-ID: <560A1C33.8040709@au1.ibm.com> (raw)
In-Reply-To: <1443222936-9385-1-git-send-email-mrochs@linux.vnet.ibm.com>
On 26/09/15 09:15, Matthew R. Ochs wrote:
> During run-time the driver can be very chatty and spam the system
> kernel log. Various print statements can be limited and/or moved
> to development-only mode. Additionally, numerous prints can be
> converted to trace the corresponding device.
>
> The following changes were made:
> - pr_debug to pr_devel
> - pr_debug to pr_debug_ratelimited
> - pr_err to dev_err
> - pr_debug to dev_dbg
>
> Signed-off-by: Matthew R. Ochs <mrochs@linux•vnet.ibm.com>
> Signed-off-by: Manoj N. Kumar <manoj@linux•vnet.ibm.com>
> Reviewed-by: Brian King <brking@linux•vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
Changes mostly look fine, further comments below.
> --- a/drivers/scsi/cxlflash/main.c
> +++ b/drivers/scsi/cxlflash/main.c
> @@ -58,8 +58,8 @@ static struct afu_cmd *cmd_checkout(struct afu *afu)
> cmd = &afu->cmd[k];
>
> if (!atomic_dec_if_positive(&cmd->free)) {
> - pr_debug("%s: returning found index=%d\n",
> - __func__, cmd->slot);
> + pr_devel("%s: returning found index=%d cmd=%p\n",
> + __func__, cmd->slot, cmd);
> pr_debug("%s: cmd failed afu_rc=%d scsi_rc=%d fc_rc=%d "
> - "afu_extra=0x%X, scsi_entra=0x%X, fc_extra=0x%X\n",
> + "afu_extra=0x%X, scsi_extra=0x%X, fc_extra=0x%X\n",
> __func__, ioasa->rc.afu_rc, ioasa->rc.scsi_rc,
> ioasa->rc.fc_rc, ioasa->afu_extra, ioasa->scsi_extra,
> ioasa->fc_extra);
Minor nitpicking: mention that you fix these in the commit message.
> @@ -240,9 +240,9 @@ static void cmd_complete(struct afu_cmd *cmd)
> cmd_is_tmf = cmd->cmd_tmf;
> cmd_checkin(cmd); /* Don't use cmd after here */
>
> - pr_debug("%s: calling scsi_set_resid, scp=%p "
> - "result=%X resid=%d\n", __func__,
> - scp, scp->result, resid);
> + pr_debug_ratelimited("%s: calling scsi_done scp=%p result=%X "
> + "ioasc=%d\n", __func__, scp, scp->result,
> + cmd->sa.ioasc);
>
> scsi_set_resid(scp, resid);
> scsi_dma_unmap(scp);
Why has the message changed from scsi_set_resid to scsi_done, and should
the message be moved to immediately before the scsi_done call?
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1•ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2015-09-29 5:06 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 23:09 [PATCH v4 00/32] cxlflash: Miscellaneous bug fixes and corrections Matthew R. Ochs
2015-09-25 23:12 ` [PATCH v4 01/32] cxlflash: Fix to avoid invalid port_sel value Matthew R. Ochs
2015-09-25 23:12 ` [PATCH v4 02/32] cxlflash: Replace magic numbers with literals Matthew R. Ochs
2015-09-29 5:40 ` Andrew Donnellan
2015-09-25 23:12 ` [PATCH v4 03/32] cxlflash: Fix read capacity timeout Matthew R. Ochs
2015-09-25 23:13 ` [PATCH v4 04/32] cxlflash: Fix potential oops following LUN removal Matthew R. Ochs
2015-09-25 23:13 ` [PATCH v4 05/32] cxlflash: Fix data corruption when vLUN used over multiple cards Matthew R. Ochs
2015-09-25 23:14 ` [PATCH v4 06/32] cxlflash: Fix to avoid sizeof(bool) Matthew R. Ochs
2015-09-28 22:35 ` Daniel Axtens
2015-09-25 23:14 ` [PATCH v4 07/32] cxlflash: Fix context encode mask width Matthew R. Ochs
2015-09-28 22:39 ` Daniel Axtens
2015-09-25 23:14 ` [PATCH v4 08/32] cxlflash: Fix to avoid CXL services during EEH Matthew R. Ochs
2015-09-28 22:07 ` Brian King
2015-09-28 23:05 ` Daniel Axtens
2015-09-29 19:28 ` Matthew R. Ochs
2015-09-25 23:14 ` [PATCH v4 09/32] cxlflash: Correct naming of limbo state and waitq Matthew R. Ochs
2015-09-28 23:09 ` Daniel Axtens
2015-09-25 23:14 ` [PATCH v4 10/32] cxlflash: Make functions static Matthew R. Ochs
2015-09-25 23:14 ` [PATCH v4 11/32] cxlflash: Refine host/device attributes Matthew R. Ochs
2015-09-29 4:29 ` Andrew Donnellan
2015-09-25 23:15 ` [PATCH v4 12/32] cxlflash: Fix to avoid spamming the kernel log Matthew R. Ochs
2015-09-29 5:05 ` Andrew Donnellan [this message]
2015-09-29 20:37 ` Matthew R. Ochs
2015-09-25 23:16 ` [PATCH v4 13/32] cxlflash: Fix to avoid stall while waiting on TMF Matthew R. Ochs
2015-09-25 23:16 ` [PATCH v4 14/32] cxlflash: Fix location of setting resid Matthew R. Ochs
2015-09-25 23:16 ` [PATCH v4 15/32] cxlflash: Fix host link up event handling Matthew R. Ochs
2015-09-25 23:16 ` [PATCH v4 16/32] cxlflash: Fix async interrupt bypass logic Matthew R. Ochs
2015-09-25 23:16 ` [PATCH v4 17/32] cxlflash: Remove dual port online dependency Matthew R. Ochs
2015-09-28 23:37 ` Daniel Axtens
2015-09-29 19:38 ` Matthew R. Ochs
2015-09-30 23:50 ` Daniel Axtens
2015-10-01 15:00 ` Matthew R. Ochs
2015-09-25 23:17 ` [PATCH v4 18/32] cxlflash: Fix AFU version access/storage and add check Matthew R. Ochs
2015-09-25 23:17 ` [PATCH v4 19/32] cxlflash: Correct usage of scsi_host_put() Matthew R. Ochs
2015-09-25 23:17 ` [PATCH v4 20/32] cxlflash: Fix to prevent workq from accessing freed memory Matthew R. Ochs
2015-09-25 23:17 ` [PATCH v4 21/32] cxlflash: Correct behavior in device reset handler following EEH Matthew R. Ochs
2015-09-25 23:17 ` [PATCH v4 22/32] cxlflash: Remove unnecessary scsi_block_requests Matthew R. Ochs
2015-09-25 23:18 ` [PATCH v4 23/32] cxlflash: Fix function prolog parameters and return codes Matthew R. Ochs
2015-09-29 4:36 ` Andrew Donnellan
2015-09-29 20:31 ` Matthew R. Ochs
2015-09-25 23:18 ` [PATCH v4 24/32] cxlflash: Fix MMIO and endianness errors Matthew R. Ochs
2015-09-29 1:52 ` Andrew Donnellan
2015-09-25 23:18 ` [PATCH v4 25/32] cxlflash: Fix to prevent EEH recovery failure Matthew R. Ochs
2015-09-29 1:25 ` Daniel Axtens
2015-09-29 20:11 ` Matthew R. Ochs
2015-09-30 23:53 ` Daniel Axtens
2015-09-25 23:18 ` [PATCH v4 26/32] cxlflash: Correct spelling, grammar, and alignment mistakes Matthew R. Ochs
2015-09-29 1:18 ` Andrew Donnellan
2015-09-25 23:19 ` [PATCH v4 27/32] cxlflash: Fix to prevent stale AFU RRQ Matthew R. Ochs
2015-09-29 1:36 ` Daniel Axtens
2015-09-29 20:22 ` Matthew R. Ochs
2015-09-30 23:51 ` Daniel Axtens
2015-09-25 23:19 ` [PATCH v4 28/32] MAINTAINERS: Add cxlflash driver Matthew R. Ochs
2015-09-25 23:19 ` [PATCH v4 29/32] cxlflash: Fix to double the delay each time Matthew R. Ochs
2015-09-29 1:19 ` Andrew Donnellan
2015-09-29 1:40 ` Daniel Axtens
2015-09-29 20:28 ` Matthew R. Ochs
2015-09-30 0:08 ` Daniel Axtens
2015-09-25 23:19 ` [PATCH v4 30/32] cxlflash: Fix to avoid corrupting adapter fops Matthew R. Ochs
2015-09-28 22:13 ` Brian King
2015-09-29 0:54 ` Andrew Donnellan
2015-09-30 0:18 ` Daniel Axtens
2015-09-25 23:19 ` [PATCH v4 31/32] cxlflash: Correct trace string Matthew R. Ochs
2015-09-29 1:20 ` Andrew Donnellan
2015-09-25 23:19 ` [PATCH v4 32/32] cxlflash: Fix to avoid potential deadlock on EEH Matthew R. Ochs
2015-09-28 23:41 ` Brian King
2015-09-29 19:40 ` Matthew R. Ochs
2015-09-30 0:33 ` Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560A1C33.8040709@au1.ibm.com \
--to=andrew.donnellan@au1$(echo .)ibm.com \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=dja@ozlabs$(echo .)au.ibm.com \
--cc=imunsie@au1$(echo .)ibm.com \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=manoj@linux$(echo .)vnet.ibm.com \
--cc=mikey@neuling$(echo .)org \
--cc=mrochs@linux$(echo .)vnet.ibm.com \
--cc=nab@linux-iscsi$(echo .)org \
--cc=thenzl@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox