From: Timur Tabi <timur@tabi•org>
To: alex.popov@linux•com,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>,
Anatolij Gustschin <agust@denx•de>, Rob Herring <robh@kernel•org>,
Grant Likely <grant.likely@linaro•org>,
Dan Williams <dan.j.williams@intel•com>,
Vinod Koul <vinod.koul@intel•com>,
Pawel Moll <pawel.moll@arm•com>,
Mark Rutland <mark.rutland@arm•com>,
Ian Campbell <ijc+devicetree@hellion•org.uk>,
Kumar Gala <galak@codeaurora•org>,
linuxppc-dev@lists•ozlabs.org, dmaengine@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver
Date: Thu, 1 Oct 2015 12:11:10 -0500 [thread overview]
Message-ID: <560D692E.1010309@tabi.org> (raw)
In-Reply-To: <560C5325.6070406@linux.com>
On 09/30/2015 04:24 PM, Alexander Popov wrote:
>> Can you test for "!cs" here instead?
>>
>>> + e = -EFAULT;
>>> + goto err_param;
>>> + }
>
> Unfortunately no: 0 is a valid value for Chip Select.
> Is it OK to leave it like that?
Yes.
>>> + lpbfifo.ram_bus_addr = sg_dma_address(&sg); /* For freeing later */
>>> + sg_dma_len(&sg) = lpbfifo.req->size;
>>
>> I don't think sg_dma_len() is meant to be used as an lvalue.
>
> I've double-checked and found many cases of such usage of this macro.
> It seems that I can't avoid it too.
Ok.
>> Driver code that has to parse #address-cells or #size-cells
>> is usually wrong.
>
> I would not call it "parsing", I just check whether the dts-file is good.
> Anyway, could you give me a clue how to do better?
You should use of_n_size_cells() and of_n_addr_cells().
--
next prev parent reply other threads:[~2015-10-01 17:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 17:28 [PATCH v3 0/3] powerpc/512x: add LocalPlus Bus FIFO device driver Alexander Popov
2015-09-24 17:28 ` [PATCH v3 1/3] " Alexander Popov
2015-09-25 1:01 ` Timur Tabi
2015-09-28 13:13 ` Alexander Popov
2015-09-28 13:18 ` Timur Tabi
2015-09-29 6:34 ` Alexander Popov
2015-09-30 21:24 ` Alexander Popov
2015-10-01 17:11 ` Timur Tabi [this message]
2015-10-05 22:22 ` Alexander Popov
2015-09-24 17:28 ` [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO Alexander Popov
2015-09-25 0:18 ` Timur Tabi
2015-09-28 13:24 ` Alexander Popov
2015-09-28 13:26 ` Timur Tabi
2015-09-29 6:35 ` Alexander Popov
2015-09-24 17:28 ` [PATCH v3 3/3] dmaengine: mpc512x: initialize with subsys_initcall() Alexander Popov
2015-09-25 0:16 ` Timur Tabi
2015-09-28 13:15 ` Alexander Popov
2015-10-07 14:17 ` Vinod Koul
2015-10-07 21:31 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D692E.1010309@tabi.org \
--to=timur@tabi$(echo .)org \
--cc=agust@denx$(echo .)de \
--cc=alex.popov@linux$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=dan.j.williams@intel$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=grant.likely@linaro$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=pawel.moll@arm$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=vinod.koul@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox