Subject: Re: [PATCH] powerpc/pseries/hvcserver: don't memset pi_buff if it is null

From: Colin Ian King <[email-masked]>
Date: Mon, 12 Oct 2015 07:14:36 +0100

On 12/10/15 01:35, Daniel Axtens wrote:
> 
> Hi Colin,
> 
> This looks good. Out of curiousity, how did you find it? Code
> inspection? Bug? Static analysis?

static analysis with cppcheck. I forgot to mention that in the commit
message.

> 
> Not that it's particularly meaningful for such a trivial fix, but FWIW
:
> 
> Reviewed-by: Daniel Axtens <[email-masked]>
> 
> Regards,
> Daniel
> 
> Colin King <[email-masked]> writes:
> 
>> From: Colin Ian King <[email-masked]>
>>
>> pi_buff is being memset before it is sanity checked. Move the
>> memset after the null pi_buff sanity check to avoid an oops.
>>
>> Signed-off-by: Colin Ian King <[email-masked]>
>> ---
>>  arch/powerpc/platforms/pseries/hvcserver.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/pseries/hvcserver.c b/arch/powerp
c/platforms/pseries/hvcserver.c
>> index eedb645..94a6e56 100644
>> --- a/arch/powerpc/platforms/pseries/hvcserver.c
>> +++ b/arch/powerpc/platforms/pseries/hvcserver.c
>> @@ -142,11 +142,11 @@ int hvcs_get_partner_info(uint32_t unit_address
, struct list_head *head,
>>  	int more = 1;
>>  	int retval;
>>  
>> -	memset(pi_buff, 0x00, PAGE_SIZE);
>>  	/* invalid parameters */
>>  	if (!head || !pi_buff)
>>  		return -EINVAL;
>>  
>> +	memset(pi_buff, 0x00, PAGE_SIZE);
>>  	last_p_partition_ID = last_p_unit_address = ~0UL;
>>  	INIT_LIST_HEAD(head);
>>  
>> -- 
>> 2.5.0
>>
>> _______________________________________________
>> Linuxppc-dev mailing list
>> [email-masked]
>> https://lists.ozlabs.org/listinfo/linuxppc-dev