Subject: Re: [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake

From: Sudeep Holla <[email-masked]>
Date: Mon, 19 Oct 2015 18:35:43 +0100

Hi Ben,

On 23/09/15 05:06, Scott Wood wrote:
> On Mon, 2015-09-21 at 16:47 +0100, Sudeep Holla wrote:
>> mpic_irq_set_wake return -ENXIO for non FSL MPIC and sets IRQF_NO_SUSPEND
>> flag for FSL ones. enable_irq_wake already returns -ENXIO if irq_set_wak
>> is not implemented. Also there's no need to set the IRQF_NO_SUSPEND flag
>> as it doesn't guarantee wakeup for that interrupt.
>>
>> This patch removes the redundant mpic_irq_set_wake and sets the
>> IRQCHIP_SKIP_SET_WAKE for only FSL MPIC.
>>
>> Cc: Benjamin Herrenschmidt <[email-masked]>
>> Cc: Paul Mackerras <[email-masked]>
>> Cc: Michael Ellerman <[email-masked]>
>> Cc: Scott Wood <[email-masked]>
>> Cc: Hongtao Jia <[email-masked]>
>> Cc: Marc Zyngier <[email-masked]>
>> Cc: [email-masked]
>> Signed-off-by: Sudeep Holla <[email-masked]>
>> ---
>>   arch/powerpc/sysdev/mpic.c | 23 ++++-------------------
>>   1 file changed, 4 insertions(+), 19 deletions(-)
>
> Acked-by: Scott Wood <[email-masked]>
>

Can you pick this up via your tree ?

-- 
Regards,
Sudeep