From: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
To: Uma Krishnan <ukrishn@linux•vnet.ibm.com>,
linux-scsi@vger•kernel.org,
James Bottomley <James.Bottomley@HansenPartnership•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"Matthew R. Ochs" <mrochs@linux•vnet.ibm.com>,
"Manoj N. Kumar" <manoj@linux•vnet.ibm.com>,
Brian King <brking@linux•vnet.ibm.com>
Cc: Daniel Axtens <dja@ozlabs•au.ibm.com>,
linuxppc-dev@lists•ozlabs.org, Ian Munsie <imunsie@au1•ibm.com>
Subject: Re: [PATCH v2 6/6] cxlflash: Enable device id for future IBM CXL adapter
Date: Tue, 15 Dec 2015 14:11:00 +1100 [thread overview]
Message-ID: <566F84C4.1000203@au1.ibm.com> (raw)
In-Reply-To: <1450127263-48261-1-git-send-email-ukrishn@linux.vnet.ibm.com>
On 15/12/15 08:07, Uma Krishnan wrote:
> From: Manoj Kumar <manoj@linux•vnet.ibm.com>
>
> This drop enables a future card with a device id
> of 0x0600 to be recognized by the cxlflash driver.
If you do a V3 - this could be better worded in the imperative mood as:
"Add a new device ID (0x0600) for a future IBM CXL Flash Adapter card."
>
> As per the design, the Accelerator Function Unit (AFU)
> for this new IBM CXL Flash Adapter retains the same
> host interface as the previous generation. For the early
> prototypes of the new card, the driver with this change
> behaves exactly as the driver prior to this behaved with
> the earlier generation card. Therefore, no card specific
> programming has been added. These card specific changes
> can be staged in later if needed.
>
> Signed-off-by: Manoj N. Kumar <manoj@linux•vnet.ibm.com>
> Acked-by: Matthew R. Ochs <mrochs@linux•vnet.ibm.com>
Assuming that the final card won't break in a particularly nasty way in
the absence of later code changes, all looks good.
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1•ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2015-12-15 3:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 20:51 [PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates Uma Krishnan
2015-12-14 20:55 ` Uma Krishnan
2015-12-14 20:55 ` [PATCH v2 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1 Uma Krishnan
2015-12-14 20:55 ` [PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates Uma Krishnan
2015-12-14 20:55 ` [PATCH v2 2/6] cxlflash: Fix to avoid virtual LUN failover failure Uma Krishnan
2015-12-14 21:06 ` [PATCH v2 3/6] cxlflash: Removed driver date print Uma Krishnan
2015-12-14 23:45 ` Matthew R. Ochs
2015-12-15 0:20 ` Andrew Donnellan
2015-12-15 21:04 ` Manoj Kumar
2015-12-14 21:07 ` [PATCH v2 4/6] cxlflash: Fix to resolve cmd leak after host reset Uma Krishnan
2015-12-15 2:45 ` Andrew Donnellan
2015-12-14 21:07 ` [PATCH v2 5/6] cxlflash: Resolve oops in wait_port_offline Uma Krishnan
2015-12-14 21:07 ` [PATCH v2 6/6] cxlflash: Enable device id for future IBM CXL adapter Uma Krishnan
2015-12-15 3:11 ` Andrew Donnellan [this message]
2016-01-07 2:01 ` [PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566F84C4.1000203@au1.ibm.com \
--to=andrew.donnellan@au1$(echo .)ibm.com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=dja@ozlabs$(echo .)au.ibm.com \
--cc=imunsie@au1$(echo .)ibm.com \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=manoj@linux$(echo .)vnet.ibm.com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mrochs@linux$(echo .)vnet.ibm.com \
--cc=ukrishn@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox