From: "Wangnan (F)" <wangnan0@huawei•com>
To: Arnaldo Carvalho de Melo <acme@kernel•org>,
"Naveen N. Rao" <naveen.n.rao@linux•vnet.ibm.com>
Cc: <jolsa@redhat•com>, <linux-kernel@vger•kernel.org>,
<linuxppc-dev@lists•ozlabs.org>, <sukadev@linux•vnet.ibm.com>
Subject: Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
Date: Thu, 17 Dec 2015 09:29:31 +0800 [thread overview]
Message-ID: <56720FFB.5060407@huawei.com> (raw)
In-Reply-To: <20151216194234.GA19926@kernel.org>
On 2015/12/17 3:42, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu:
>> On 2015/12/15 08:51AM, Wang Nan wrote:
>>> From: "Naveen N. Rao" <naveen.n.rao@linux•vnet.ibm.com>
>>>
>>> perf build is currently (v4.4-rc5) broken on powerpc:
>>>
>>> bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support
>>> your arch.
>>> # error __NR_bpf not defined. libbpf does not support your arch.
>>> ^
>>>
>>> Fix this by including tools/scripts/Makefile.arch for the proper
>>> $ARCH macro. While at it, remove redundant LP64 macro definition.
>>>
>>> Also, since libbpf require $(srctree) now, detect the path of
>>> srctree like perf.
>>>
>>> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux•vnet.ibm.com>
>>> Signed-off-by: Wang Nan <wangnan0@huawei•com>
>>> Acked-by: Jiri Olsa <jolsa@kernel•org>
>>> Cc: Arnaldo Carvalho de Melo <acme@kernel•org>
>>> Cc: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
>>> ---
>>>
>>> v3 -> v4: Add srctree detector code so directly run 'make' in libbpf
>>> directory would not cause error.
>> Good catch!
>>
>> Tested-by: Naveen N. Rao <naveen.n.rao@linux•vnet.ibm.com>
> Trying to apply the patchkit:
>
> [acme@zoo linux]$ make -C tools clean > /dev/null 2>&1
> [acme@zoo linux]$ make -C tools/perf build-test
> make: Entering directory '/home/git/linux/tools/perf'
> Testing Makefile
> tests/make:15: /scripts/Makefile.arch: No such file or directory
> make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop.
> tests/make:5: recipe for target 'all' failed
> make[1]: *** [all] Error 2
> Makefile:81: recipe for target 'build-test' failed
> make: *** [build-test] Error 2
> make: Leaving directory '/home/git/linux/tools/perf'
> [acme@zoo linux]$
>
> What am I doing wrong?
You need all 3 patches. This v4 patch is a fix for previous v3 3/3 and I
send
this patch by replying that one. I thought your email client is sorted
by thread
so you can easily find it but it seems I was wrong...
The whole thread is:
[PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf:
http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangnan0@huawei.com
[PATCH v3 1/3] perf tools: Fix PowerPC native building
http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangnan0@huawei.com
[PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts
http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangnan0@huawei.com
[PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf
http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangnan0@huawei.com
and [PATCH v3 3/3] breaks local building because the usage of "srctree", and
I fix it in this one.
Thanks.
next prev parent reply other threads:[~2015-12-17 1:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 10:50 [PATCH] perf: bpf: Fix build breakage due to libbpf Naveen N. Rao
2015-12-14 11:35 ` [PATCH] tools lib bpf: Support libbpf on PowerPC Wang Nan
2015-12-14 11:53 ` [PATCH] perf: bpf: Fix build breakage due to libbpf Wangnan (F)
2015-12-14 15:17 ` Naveen N. Rao
2015-12-14 11:57 ` [PATCH v2] tools lib bpf: Support libbpf on PowerPC Wang Nan
2015-12-14 15:43 ` Naveen N. Rao
2015-12-15 3:35 ` [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf Wang Nan
2015-12-15 3:35 ` [PATCH v3 1/3] perf tools: Fix PowerPC native building Wang Nan
2015-12-15 3:35 ` [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts Wang Nan
2015-12-15 3:35 ` [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf Wang Nan
2015-12-15 8:49 ` Wangnan (F)
2015-12-15 8:51 ` [PATCH v4] " Wang Nan
2015-12-15 11:40 ` Naveen N. Rao
2015-12-16 19:42 ` Arnaldo Carvalho de Melo
2015-12-17 1:29 ` Wangnan (F) [this message]
2015-12-17 5:07 ` Naveen N. Rao
2015-12-17 12:19 ` Arnaldo Carvalho de Melo
2016-01-07 6:58 ` Naveen N. Rao
2016-01-07 16:08 ` Arnaldo Carvalho de Melo
2016-01-07 20:39 ` Arnaldo Carvalho de Melo
2016-01-07 21:23 ` Arnaldo Carvalho de Melo
2016-01-08 1:56 ` Wangnan (F)
2016-01-08 15:52 ` Jiri Olsa
2016-01-08 5:39 ` Naveen N. Rao
2016-01-08 12:51 ` Arnaldo Carvalho de Melo
2016-01-08 13:31 ` Wangnan (F)
2016-01-08 13:46 ` Arnaldo Carvalho de Melo
2016-01-09 2:03 ` Fengguang Wu
2015-12-15 8:05 ` [PATCH v3 0/3] perf build: PowerPC: " Jiri Olsa
2015-12-15 11:29 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56720FFB.5060407@huawei.com \
--to=wangnan0@huawei$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=jolsa@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox