From: "Wangnan (F)" <wangnan0@huawei•com>
To: Arnaldo Carvalho de Melo <acme@kernel•org>,
"Naveen N. Rao" <naveen.n.rao@linux•vnet.ibm.com>,
Jiri Olsa <jolsa@kernel•org>
Cc: <linux-kernel@vger•kernel.org>, <linuxppc-dev@lists•ozlabs.org>,
<sukadev@linux•vnet.ibm.com>
Subject: Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
Date: Fri, 8 Jan 2016 09:56:43 +0800 [thread overview]
Message-ID: <568F175B.4030008@huawei.com> (raw)
In-Reply-To: <20160107212303.GI18457@kernel.org>
On 2016/1/8 5:23, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 07, 2016 at 05:39:57PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu:
>>> Can you please push at least the initial 3 patches of this for v4.4?
>>> Wang Nan has posted v6 here:
>>> http://thread.gmane.org/gmane.linux.kernel/2110626
>
>> So I tried it again today, from the v6, the latest patch with that
>> subject line in my inbox, and I get this, after applying the first three
>> patches:
>
>> [acme@zoo linux]$ make -C tools clean > /dev/null
>> [acme@zoo linux]$ make -C tools/perf build-test
>> make: Entering directory '/home/git/linux/tools/perf'
>> Testing Makefile
>> tests/make:15: /scripts/Makefile.arch: No such file or directory
>> make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop.
>> tests/make:5: recipe for target 'all' failed
>> make[1]: *** [all] Error 2
>> Makefile:81: recipe for target 'build-test' failed
>> make: *** [build-test] Error 2
>> make: Leaving directory '/home/git/linux/tools/perf'
>> [acme@zoo linux]$
>> Trying to figure this out...
> So, this doesn't seem to have been tessted, this part, specifically:
>
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index 8ea3dffc5065..cd9c3ce1a5c2 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -12,7 +12,7 @@ endif
> else
> PERF := .
>
> -include config/Makefile.arch
> +include $(srctree)/scripts/Makefile.arch
>
> # FIXME looks like x86 is the only arch running tests ;-)
> # we need some IS_(32/64) flag to make this generic
>
>
> ----------------------------------------------------
>
> Because $(srctree) is not set at that point, I copied the needed bits from
> tools/perf/Makefile.perf and got the patch below, which makes:L
>
> make -C tools/perf build-test
>
> Work for me again.
>
> This should wrap up the day nicely, making me think of Jens Axboe recent
> cool reaction to an untested patch:
>
> http://lkml.kernel.org/r/5661C2BC.9030007@kernel.dk
>
> :-)
>
Sorry. I though I have tested my patch by building perf, but didn't
realize perf/tests/make is not used in normal building. Doing build-test
takes too long, so I always forget it. Also, in my environment it can fail:
LD
/opt/wangnan/yocto_build/tmp-eglibc/work/generic_x86_64-oe-linux/perf/1.0-r8/perf-1.0/perf-in.o
LINK
/opt/wangnan/yocto_build/tmp-eglibc/work/generic_x86_64-oe-linux/perf/1.0-r8/perf-1.0/perf
test: test -x ./perf
make[2]: *** [make_no_newt] Error 1
make[1]: *** [all] Error 2
make: *** [build-test] Error 2
since I'm in a yocto building environment. I'll look into this problem
and give a patch on it.
Thank you.
next prev parent reply other threads:[~2016-01-08 1:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 10:50 [PATCH] perf: bpf: Fix build breakage due to libbpf Naveen N. Rao
2015-12-14 11:35 ` [PATCH] tools lib bpf: Support libbpf on PowerPC Wang Nan
2015-12-14 11:53 ` [PATCH] perf: bpf: Fix build breakage due to libbpf Wangnan (F)
2015-12-14 15:17 ` Naveen N. Rao
2015-12-14 11:57 ` [PATCH v2] tools lib bpf: Support libbpf on PowerPC Wang Nan
2015-12-14 15:43 ` Naveen N. Rao
2015-12-15 3:35 ` [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf Wang Nan
2015-12-15 3:35 ` [PATCH v3 1/3] perf tools: Fix PowerPC native building Wang Nan
2015-12-15 3:35 ` [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts Wang Nan
2015-12-15 3:35 ` [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf Wang Nan
2015-12-15 8:49 ` Wangnan (F)
2015-12-15 8:51 ` [PATCH v4] " Wang Nan
2015-12-15 11:40 ` Naveen N. Rao
2015-12-16 19:42 ` Arnaldo Carvalho de Melo
2015-12-17 1:29 ` Wangnan (F)
2015-12-17 5:07 ` Naveen N. Rao
2015-12-17 12:19 ` Arnaldo Carvalho de Melo
2016-01-07 6:58 ` Naveen N. Rao
2016-01-07 16:08 ` Arnaldo Carvalho de Melo
2016-01-07 20:39 ` Arnaldo Carvalho de Melo
2016-01-07 21:23 ` Arnaldo Carvalho de Melo
2016-01-08 1:56 ` Wangnan (F) [this message]
2016-01-08 15:52 ` Jiri Olsa
2016-01-08 5:39 ` Naveen N. Rao
2016-01-08 12:51 ` Arnaldo Carvalho de Melo
2016-01-08 13:31 ` Wangnan (F)
2016-01-08 13:46 ` Arnaldo Carvalho de Melo
2016-01-09 2:03 ` Fengguang Wu
2015-12-15 8:05 ` [PATCH v3 0/3] perf build: PowerPC: " Jiri Olsa
2015-12-15 11:29 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568F175B.4030008@huawei.com \
--to=wangnan0@huawei$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=jolsa@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox