From: David Daney <ddaney.cavm@gmail•com>
To: Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>
Cc: linux-arm-kernel@lists•infradead.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-pci@vger•kernel.org,
linux-ia64@vger•kernel.org, linux-metag@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-s390@vger•kernel.org,
linux-sh@vger•kernel.org, linux-arch@vger•kernel.org,
Will.Deacon@arm•com, catalin.marinas@arm•com,
grant.likely@linaro•org, leif.lindholm@linaro•org,
rfranz@cavium•com, ard.biesheuvel@linaro•org, msalter@redhat•com,
robh+dt@kernel•org, steve.capper@linaro•org,
hanjun.guo@linaro•org, al.stone@linaro•org, arnd@arndb•de,
pawel.moll@arm•com, mark.rutland@arm•com,
ijc+devicetree@hellion•org.uk, galak@codeaurora•org,
rjw@rjwysocki•net, lenb@kernel•org, marc.zyngier@arm•com,
lorenzo.pieralisi@arm•com, bhelgaas@google•com,
tony.luck@intel•com, fenghua.yu@intel•com,
james.hogan@imgtec•com, benh@kernel•crashing.org,
tglx@linutronix•de, mingo@redhat•com, hpa@zytor•com,
x86@kernel•org, jonathan@jonmasters•org, rrichter@cavium•com,
Prasun.Kapoor@caviumnetworks•com, gpkulkarni@gmail•com
Subject: Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware
Date: Mon, 18 Jan 2016 09:41:03 -0800 [thread overview]
Message-ID: <569D23AF.9050503@gmail.com> (raw)
In-Reply-To: <1453134965-6125-6-git-send-email-gkulkarni@caviumnetworks.com>
On 01/18/2016 08:36 AM, Ganapatrao Kulkarni wrote:
> update numa_node of device associated with pci bus.
> moved down devm_kzalloc to allocate from node memory.
>
> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>
> ---
> drivers/pci/host/pci-host-generic.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c
> index 5434c90..0e1ce06 100644
> --- a/drivers/pci/host/pci-host-generic.c
> +++ b/drivers/pci/host/pci-host-generic.c
> @@ -215,11 +215,9 @@ static int gen_pci_probe(struct platform_device *pdev)
> const struct of_device_id *of_id;
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> - struct gen_pci *pci = devm_kzalloc(dev, sizeof(*pci), GFP_KERNEL);
> + struct gen_pci *pci;
> struct pci_bus *bus, *child;
>
> - if (!pci)
> - return -ENOMEM;
>
> type = of_get_property(np, "device_type", NULL);
> if (!type || strcmp(type, "pci")) {
> @@ -230,6 +228,11 @@ static int gen_pci_probe(struct platform_device *pdev)
> of_pci_check_probe_only();
>
> of_id = of_match_node(gen_pci_of_match, np);
> + set_dev_node(dev, of_node_to_nid(np));
This shouldn't be done in individual platform_drivers, but instead in
the device probing code.
There is code that does this in drivers/of/platform.c and
drivers/of/device.c Is that not being called for the pci-host-gweneric
devices? If not, we should figure out why, and perhaps attempt to fix
it rather than doing it here.
> + pci = devm_kzalloc(dev, sizeof(*pci), GFP_KERNEL);
> + if (!pci)
> + return -ENOMEM;
> +
> pci->cfg.ops = (struct gen_pci_cfg_bus_ops *)of_id->data;
> pci->host.dev.parent = dev;
> INIT_LIST_HEAD(&pci->host.windows);
>
next prev parent reply other threads:[~2016-01-18 17:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 16:35 [PATCH v9 0/6] arm64, numa: Add numa support for arm64 platforms Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 1/6] arm64, numa: adding " Ganapatrao Kulkarni
2016-01-26 18:52 ` Bjorn Helgaas
2016-01-18 16:36 ` [PATCH v9 2/6] Documentation, dt, arm64/arm: dt bindings for numa Ganapatrao Kulkarni
2016-01-20 14:18 ` Rob Herring
2016-01-26 17:16 ` Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 3/6] arm64/arm, numa, dt: adding numa dt binding implementation for arm64 platforms Ganapatrao Kulkarni
2016-01-26 20:36 ` Bjorn Helgaas
2016-01-28 14:39 ` Will Deacon
2016-01-28 17:12 ` Ganapatrao Kulkarni
2016-01-28 18:08 ` Will Deacon
2016-01-28 18:48 ` Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 4/6] arm64, dt, thunderx: Add initial dts for Cavium Thunderx in 2 node topology Ganapatrao Kulkarni
2016-01-18 17:49 ` David Daney
2016-01-18 16:36 ` [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware Ganapatrao Kulkarni
2016-01-18 17:41 ` David Daney [this message]
2016-01-19 5:58 ` Ganapatrao Kulkarni
2016-01-19 9:41 ` Lorenzo Pieralisi
2016-01-19 12:32 ` Ganapatrao Kulkarni
2016-01-26 20:50 ` Bjorn Helgaas
2016-01-26 20:52 ` Bjorn Helgaas
2016-01-18 16:36 ` [RFC PATCH v9 6/6] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files Ganapatrao Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569D23AF.9050503@gmail.com \
--to=ddaney.cavm@gmail$(echo .)com \
--cc=Prasun.Kapoor@caviumnetworks$(echo .)com \
--cc=Will.Deacon@arm$(echo .)com \
--cc=al.stone@linaro$(echo .)org \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=fenghua.yu@intel$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=gkulkarni@caviumnetworks$(echo .)com \
--cc=gpkulkarni@gmail$(echo .)com \
--cc=grant.likely@linaro$(echo .)org \
--cc=hanjun.guo@linaro$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=james.hogan@imgtec$(echo .)com \
--cc=jonathan@jonmasters$(echo .)org \
--cc=leif.lindholm@linaro$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=marc.zyngier@arm$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=msalter@redhat$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=rfranz@cavium$(echo .)com \
--cc=rjw@rjwysocki$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=rrichter@cavium$(echo .)com \
--cc=steve.capper@linaro$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox