From: Gerhard Pircher <gerhard_pircher@gmx•net>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
linuxppc-dev@lists•ozlabs.org,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>
Cc: linux-ide@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [RFT PATCH] powerpc: convert amigaone_defconfig to use libata PATA drivers
Date: Wed, 3 Feb 2016 22:17:51 +0100 [thread overview]
Message-ID: <56B26E7F.70307@gmx.net> (raw)
In-Reply-To: <1454514630-29269-12-git-send-email-b.zolnierkie@samsung.com>
Am 2016-02-03 um 16:50 schrieb Bartlomiej Zolnierkiewicz:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts amigaone_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>
> ---
> Build tested only.
> If you have affected hardware please test. Thank you.
>
> arch/powerpc/configs/amigaone_defconfig | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/arch/powerpc/configs/amigaone_defconfig b/arch/powerpc/configs/amigaone_defconfig
> index 84f1b41..55a4929 100644
> --- a/arch/powerpc/configs/amigaone_defconfig
> +++ b/arch/powerpc/configs/amigaone_defconfig
> @@ -46,12 +46,6 @@ CONFIG_PARPORT_PC_FIFO=y
> CONFIG_BLK_DEV_FD=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_BLK_DEV_RAM=y
> -CONFIG_IDE=y
> -CONFIG_BLK_DEV_IDECD=y
> -# CONFIG_IDEPCI_PCIBUS_ORDER is not set
> -CONFIG_BLK_DEV_GENERIC=y
> -CONFIG_BLK_DEV_SIIMAGE=y
> -CONFIG_BLK_DEV_VIA82CXXX=y
> CONFIG_SCSI=y
> CONFIG_BLK_DEV_SD=y
> CONFIG_CHR_DEV_ST=y
> @@ -62,6 +56,10 @@ CONFIG_SCSI_CONSTANTS=y
> CONFIG_SCSI_SYM53C8XX_2=y
> CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0
> # CONFIG_SCSI_SYM53C8XX_MMIO is not set
> +CONFIG_ATA=y
> +CONFIG_PATA_SIL680=y
> +CONFIG_PATA_VIA=y
> +CONFIG_ATA_GENERIC=y
> CONFIG_NETDEVICES=y
> CONFIG_VORTEX=y
> CONFIG_8139CP=y
>
Thanks for cleaning up the defconfig file!
libata drivers work fine on the amigaone platform (tested on all three
first-gen AmigaOne machines). BTW: could it be that CONFIG_ATA_SFF=y
and CONFIG_ATA_BMDMA=y are missing in the patch?
br,
Gerhard
next prev parent reply other threads:[~2016-02-03 21:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 15:50 [PATCH] powerpc/83xx: disable IDE subsystem in mpc834x_itx_defconfig Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [PATCH] powerpc/85xx: disable IDE subsystem in ksi8560_defconfig Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc/85xx: convert mpc85xx_cds_defconfig to use libata PATA drivers Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [PATCH] powerpc/85xx: disable IDE subsystem in stx_gp3_defconfig Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc/85xx: convert tqm8540_defconfig to use libata PATA drivers Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc/85xx: convert tqm8541_defconfig " Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc/85xx: convert tqm8555_defconfig " Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc/85xx: convert tqm8560_defconfig " Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc/86xx: convert gef_ppc9a_defconfig " Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc/86xx: convert gef_sbc310_defconfig " Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [PATCH] powerpc/86xx: disable IDE subsystem in mpc8610_hpcd_defconfig Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert amigaone_defconfig to use libata PATA drivers Bartlomiej Zolnierkiewicz
2016-02-03 21:17 ` Gerhard Pircher [this message]
2016-02-04 14:35 ` Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert cell_defconfig " Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert chrp32_defconfig " Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert g5_defconfig " Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert maple_defconfig " Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [PATCH] powerpc: disable IDE subsystem in pasemi_defconfig Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert pmac32_defconfig to use libata PATA drivers Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert ppc64_defconfig " Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert ppc64e_defconfig " Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert ppc6xx_defconfig " Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [PATCH] powerpc: disable IDE subsystem in pq2fads_defconfig Bartlomiej Zolnierkiewicz
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert pseries_defconfig to use libata PATA drivers Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
2016-02-03 15:50 ` [RFT PATCH] powerpc: convert storcenter_defconfig " Bartlomiej Zolnierkiewicz
2016-11-17 12:04 ` [RFT] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B26E7F.70307@gmx.net \
--to=gerhard_pircher@gmx$(echo .)net \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox