From: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
To: "Oliver O'Halloran" <oohall@gmail•com>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc/lib/sstep.c - Fix emulation fall-through
Date: Tue, 16 Feb 2016 11:59:37 +1100 [thread overview]
Message-ID: <56C27479.8080808@au1.ibm.com> (raw)
In-Reply-To: <1455578929-29599-1-git-send-email-oohall@gmail.com>
On 16/02/16 10:28, Oliver O'Halloran wrote:
> There is a switch fallthough in instr_analyze() which can cause
> an invalid instruction to be emulated as a different, valid,
> instruction. The rld* (opcode 30) case extracts a sub-opcode from
> bits 3:1 of the instruction word. However, the only valid values
> of this field a 001 and 000. These cases are correctly handled,
> but the others are not which causes execution to fall through
> into case 31.
>
> Breaking out of the switch causes the instruction to be marked as
> unknown and allows the caller to deal with the invalid instruction
> in a manner consistent with other invalid instructions.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail•com>
The title should probably be "powerpc/sstep: fix switch fallthrough in
instruction emulation" to be consistent with our usual patch titling
practice. Please respin.
Apart from that, I'm reasonably convinced this is an appropriate fix:
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1•ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2016-02-16 1:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 6:55 [PATCH] Fix fall-through from case 30 (rld*) to case 31 Oliver O'Halloran
2016-01-27 0:52 ` Andrew Donnellan
2016-01-27 5:29 ` oliver
2016-01-27 7:00 ` Andrew Donnellan
2016-02-15 23:28 ` [PATCH] powerpc/lib/sstep.c - Fix emulation fall-through Oliver O'Halloran
2016-02-16 0:59 ` Andrew Donnellan [this message]
2016-02-16 6:31 ` [PATCH v2] powerpc/sstep.c " Oliver O'Halloran
2016-05-10 21:48 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C27479.8080808@au1.ibm.com \
--to=andrew.donnellan@au1$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=oohall@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox