From: Balbir Singh <bsingharora@gmail•com>
To: Petr Mladek <pmladek@suse•com>
Cc: linuxppc-dev@ozlabs•org, duwe@lst•de,
linux-kernel@vger•kernel.org, rostedt@goodmis•org,
kamalesh@linux•vnet.ibm.com, jeyu@redhat•com, jkosina@suse•cz,
live-patching@vger•kernel.org, mbenes@suse•cz,
mpe@ellerman•id.au, jikos@kernel•org, Torsten Duwe <duwe@suse•de>
Subject: Re: [v5][PATCH] livepatch/ppc: Enable livepatching on powerpc
Date: Wed, 9 Mar 2016 14:37:34 +1100 [thread overview]
Message-ID: <56DF9A7E.4070101@gmail.com> (raw)
In-Reply-To: <20160308160259.GF10940@pathway.suse.cz>
On 09/03/16 03:02, Petr Mladek wrote:
> On Tue 2016-03-08 18:33:57, Balbir Singh wrote:
>> Changelog v5:
>> 1. Removed the mini-stack frame created for klp_return_helper.
>> As a result of the mini-stack frame, function with > 8
>> arguments could not be patched
>> 2. Removed camel casing in the comments
> I tested this patch and it fails when I call a patched printk()
> from a module.
>
> You might try it with the test patch below. It is a bit twisted
> because it calls the patched printk from livepatch_cmdline_proc_show()
> that it added by the same patch module. Please, look at
> livepatch_cmdline_proc_show(), it does:
>
> static int count;
>
> if (!count++)
> trace_printk("%s\n", "this has been live patched");
> else
> printk("%s\n", "this has been live patched");
>
>
> It means that calls only trace_printk() when called first time.
> It calls the patched printk when called second time.
>
>
> I have tested it the following way:
>
>
> # booted kernel with the changes below
> # applied the patch:
> $> modprobe livepatch-sample
>
> # trigger the pached printk()
> $>cat /sys/kernel/livepatch/livepatch_sample/enabled
> 1
>
> # look into both dmesg and trace buffer
> $> dmesg | tail -n 1
> [ 727.537307] patch enabled: 1
> $> cat /sys/kernel/debug/tracing/trace | tail -n 1
> cat-3588 [003] .... 727.537448: livepatch_printk: patch enabled: 1
>
> # trigger livepatch_cmdline_proc_show() 1st time
> c79:~ # cat /proc/cmdline
> this has been live patched
>
> # the message appeared only in trace buffer
> $> dmesg | tail -n 1
> [ 727.537307] patch enabled: 1
> c79:~ # cat /sys/kernel/debug/tracing/trace | tail -n 1
> cat-3511 [000] .... 862.958383: livepatch_cmdline_proc_show: this has been live patched
>
>
> # trigger livepatch_cmdline_proc_show() 2nd time
> c79:~ # cat /proc/cmdline
>
> !!! KABOOM !!!
>
> It is becaused it tried to call the patched printk()?
>
Yes, the situation is that we restored the r2 for the kernel (from ftrace_caller, it is now kernel_toc),
whereas the LR points to the module. The difference between r2 and r0 > 4GB.
Very good test case. Did it work with v4? I presume it did because we have enough space to save both
Thanks,
Balbir Singh
prev parent reply other threads:[~2016-03-09 3:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 7:33 [v5][PATCH] livepatch/ppc: Enable livepatching on powerpc Balbir Singh
2016-03-08 10:45 ` Torsten Duwe
2016-03-08 13:52 ` Balbir Singh
2016-03-08 15:34 ` Torsten Duwe
2016-03-09 3:41 ` Balbir Singh
2016-03-09 16:10 ` Petr Mladek
2016-03-09 17:26 ` Torsten Duwe
2016-03-08 16:02 ` Petr Mladek
2016-03-09 3:37 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DF9A7E.4070101@gmail.com \
--to=bsingharora@gmail$(echo .)com \
--cc=duwe@lst$(echo .)de \
--cc=duwe@suse$(echo .)de \
--cc=jeyu@redhat$(echo .)com \
--cc=jikos@kernel$(echo .)org \
--cc=jkosina@suse$(echo .)cz \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=live-patching@vger$(echo .)kernel.org \
--cc=mbenes@suse$(echo .)cz \
--cc=mpe@ellerman$(echo .)id.au \
--cc=pmladek@suse$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox