public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse•cz>
To: Peter Zijlstra <peterz@infradead•org>
Cc: akpm@linux-foundation•org, linux-kernel@vger•kernel.org,
	Richard Henderson <rth@twiddle•net>,
	Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
	Matt Turner <mattst88@gmail•com>,
	Vineet Gupta <vgupta@synopsys•com>,
	Russell King <linux@arm•linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm•com>,
	Will Deacon <will.deacon@arm•com>,
	Haavard Skinnemoen <hskinnemoen@gmail•com>,
	Hans-Christian Egtvedt <egtvedt@samfundet•no>,
	Steven Miao <realmz6@gmail•com>, Mark Salter <msalter@redhat•com>,
	Aurelien Jacquiot <a-jacquiot@ti•com>,
	Mikael Starvik <starvik@axis•com>,
	Jesper Nilsson <jesper.nilsson@axis•com>,
	Yoshinori Sato <ysato@users•sourceforge.jp>,
	Richard Kuo <rkuo@codeaurora•org>,
	Tony Luck <tony.luck@intel•com>,
	Fenghua Yu <fenghua.yu@intel•com>,
	Geert Uytterhoeven <geert@linux-m68k•org>,
	James Hogan <james.hogan@imgtec•com>,
	Michal Simek <monstr@monstr•eu>,
	Ralf Baechle <ralf@linux-mips•org>,
	David Howells <dhowells@redhat•com>,
	Koichi Yasutake <yasutake.koichi@jp•panasonic.com>,
	Ley Foon Tan <lftan@altera•com>, Jonas Bonn <jonas@southpole•se>,
	"James E.J. Bottomley" <jejb@parisc-linux•org>,
	Helge Deller <deller@gmx•de>,
	Benjamin Herrenschmidt <benh@kernel•crashing.org>,
	Paul Mackerras <paulus@samba•org>,
	Michael Ellerman <mpe@ellerman•id.au>,
	Martin Schwidefsky <schwidefsky@de•ibm.com>,
	Heiko Carstens <heiko.carstens@de•ibm.com>,
	Chen Liqin <liqin.linux@gmail•com>,
	Lennox Wu <lennox.wu@gmail•com>, Rich Felker <dalias@libc•org>,
	"David S. Miller" <davem@davemloft•net>,
	Chris Metcalf <cmetcalf@mellanox•com>,
	Jeff Dike <jdike@addtoit•com>,
	Richard Weinberger <richard@nod•at>,
	Guan Xuetao <gxt@mprc•pku.edu.cn>,
	Thomas Gleixner <tglx@linutronix•de>,
	Ingo Molnar <mingo@redhat•com>, "H. Peter Anvin" <hpa@zytor•com>,
	x86@kernel•org, Chris Zankel <chris@zankel•net>,
	Max Filippov <jcmvbkbc@gmail•com>,
	linux-alpha@vger•kernel.org, linux-snps-arc@lists•infradead.org,
	linux-arm-kernel@lists•infradead.org,
	adi-buildroot-devel@lists•sourceforge.net,
	linux-c6x-dev@linux-c6x•org, linux-cris-kernel@axis•com,
	uclinux-h8-devel@lists•sourceforge.jp,
	linux-hexagon@vger•kernel.org, linux-ia64@vger•kernel.org,
	linux-m68k@lists•linux-m68k.org, linux-metag@vger•kernel.org,
	linux-mips@linux-mips•org, linux-am33-list@redhat•com,
	nios2-dev@lists•rocketboards.org, linux-parisc@vger•kernel.org,
	linuxppc-dev@lists•ozlabs.org, linux-s390@vger•kernel.org,
	linux-sh@vger•kernel.org, sparclinux@vger•kernel.org,
	user-mode-linux-devel@lists•sourceforge.net,
	user-mode-linux-user@lists•sourceforge.net,
	linux-xtensa@linux-xtensa•org
Subject: Re: [PATCH 3/4] exit_thread: accept a task parameter to be exited
Date: Thu, 24 Mar 2016 14:05:03 +0100	[thread overview]
Message-ID: <56F3E5FF.9030105@suse.cz> (raw)
In-Reply-To: <20160324130303.GS6356@twins.programming.kicks-ass.net>

On 03/24/2016, 02:03 PM, Peter Zijlstra wrote:
> On Thu, Mar 24, 2016 at 01:58:13PM +0100, Jiri Slaby wrote:
>>  void
>> -exit_thread(void)
>> +exit_thread(struct task_struct *me)
>>  {
>>  }
> 
> task_struct arguments are called: tsk, task, p
> 'me' seems very wrong, as that could only mean 'current', and its
> clearly not that.

Ah, OK. I will wait for more feedback and will fix this.

thanks,
-- 
js
suse labs

  reply	other threads:[~2016-03-24 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 12:58 [PATCH 3/4] exit_thread: accept a task parameter to be exited Jiri Slaby
2016-03-24 13:03 ` Peter Zijlstra
2016-03-24 13:05   ` Jiri Slaby [this message]
2016-03-24 15:36 ` Russell King - ARM Linux
2016-03-25  8:32 ` [3/4] " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F3E5FF.9030105@suse.cz \
    --to=jslaby@suse$(echo .)cz \
    --cc=a-jacquiot@ti$(echo .)com \
    --cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=benh@kernel$(echo .)crashing.org \
    --cc=catalin.marinas@arm$(echo .)com \
    --cc=chris@zankel$(echo .)net \
    --cc=cmetcalf@mellanox$(echo .)com \
    --cc=dalias@libc$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=deller@gmx$(echo .)de \
    --cc=dhowells@redhat$(echo .)com \
    --cc=egtvedt@samfundet$(echo .)no \
    --cc=fenghua.yu@intel$(echo .)com \
    --cc=geert@linux-m68k$(echo .)org \
    --cc=gxt@mprc$(echo .)pku.edu.cn \
    --cc=heiko.carstens@de$(echo .)ibm.com \
    --cc=hpa@zytor$(echo .)com \
    --cc=hskinnemoen@gmail$(echo .)com \
    --cc=ink@jurassic$(echo .)park.msu.ru \
    --cc=james.hogan@imgtec$(echo .)com \
    --cc=jcmvbkbc@gmail$(echo .)com \
    --cc=jdike@addtoit$(echo .)com \
    --cc=jejb@parisc-linux$(echo .)org \
    --cc=jesper.nilsson@axis$(echo .)com \
    --cc=jonas@southpole$(echo .)se \
    --cc=lennox.wu@gmail$(echo .)com \
    --cc=lftan@altera$(echo .)com \
    --cc=linux-alpha@vger$(echo .)kernel.org \
    --cc=linux-am33-list@redhat$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-c6x-dev@linux-c6x$(echo .)org \
    --cc=linux-cris-kernel@axis$(echo .)com \
    --cc=linux-hexagon@vger$(echo .)kernel.org \
    --cc=linux-ia64@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-m68k@lists$(echo .)linux-m68k.org \
    --cc=linux-metag@vger$(echo .)kernel.org \
    --cc=linux-mips@linux-mips$(echo .)org \
    --cc=linux-parisc@vger$(echo .)kernel.org \
    --cc=linux-s390@vger$(echo .)kernel.org \
    --cc=linux-sh@vger$(echo .)kernel.org \
    --cc=linux-snps-arc@lists$(echo .)infradead.org \
    --cc=linux-xtensa@linux-xtensa$(echo .)org \
    --cc=linux@arm$(echo .)linux.org.uk \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=liqin.linux@gmail$(echo .)com \
    --cc=mattst88@gmail$(echo .)com \
    --cc=mingo@redhat$(echo .)com \
    --cc=monstr@monstr$(echo .)eu \
    --cc=mpe@ellerman$(echo .)id.au \
    --cc=msalter@redhat$(echo .)com \
    --cc=nios2-dev@lists$(echo .)rocketboards.org \
    --cc=paulus@samba$(echo .)org \
    --cc=peterz@infradead$(echo .)org \
    --cc=ralf@linux-mips$(echo .)org \
    --cc=realmz6@gmail$(echo .)com \
    --cc=richard@nod$(echo .)at \
    --cc=rkuo@codeaurora$(echo .)org \
    --cc=rth@twiddle$(echo .)net \
    --cc=schwidefsky@de$(echo .)ibm.com \
    --cc=sparclinux@vger$(echo .)kernel.org \
    --cc=starvik@axis$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=tony.luck@intel$(echo .)com \
    --cc=uclinux-h8-devel@lists$(echo .)sourceforge.jp \
    --cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
    --cc=user-mode-linux-user@lists$(echo .)sourceforge.net \
    --cc=vgupta@synopsys$(echo .)com \
    --cc=will.deacon@arm$(echo .)com \
    --cc=x86@kernel$(echo .)org \
    --cc=yasutake.koichi@jp$(echo .)panasonic.com \
    --cc=ysato@users$(echo .)sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox