Subject: Re: [PATCH] powerpc: define the fman node for the kmcoge4 DTS

From: Valentin Longchamp <[email-masked]>
Date: Thu, 7 Apr 2016 08:14:43 +0200

On 06/04/16 23:49, Scott Wood wrote:
> On Wed, 2016-04-06 at 15:37 +0200, Valentin Longchamp wrote:
>> Now that the FMAN mac driver has been merged the fman node is relevant.
>>
>> The kmcoge4 board implements 3 ethernet interfaces, 1 with a RGMII phy
>> and 2 with fixed 1 Giga SGMII links.
>>
>> Signed-off-by: Valentin Longchamp <[email-masked]>
>> ---
>>  arch/powerpc/boot/dts/fsl/kmcoge4.dts | 39
>> +++++++++++++++++++++++++++++++++++
>>  1 file changed, 39 insertions(+)
>>
>> diff --git a/arch/powerpc/boot/dts/fsl/kmcoge4.dts
>> b/arch/powerpc/boot/dts/fsl/kmcoge4.dts
>> index 6858ec9..1cec66d 100644
>> --- a/arch/powerpc/boot/dts/fsl/kmcoge4.dts
>> +++ b/arch/powerpc/boot/dts/fsl/kmcoge4.dts
>> @@ -106,6 +106,45 @@
>>  		sata@221000 {
>>  			status = "disabled";
>>  		};
>> +
>> +		fman0: fman@400000 {
>> +			enet0: ethernet@e0000 {
>> +				phy-connection-type = "sgmii";
>> +				local-mac-address = [00 11 22 33 44 55];
>> +				fixed-link {
>> +					speed = <1000>;
>> +					full-duplex;
>> +				};
>> +			};
>> +			mdio0: mdio@e1120 {
>> +				front_phy: ethernet-phy@11 {
>> +					reg = <0x11>;
>> +				};
>> +			};
>> +
>> +			enet1: ethernet@e2000 {
>> +				phy-connection-type = "sgmii";
>> +				local-mac-address = [00 11 22 33 44 56];
>> +				fixed-link {
>> +					speed = <1000>;
>> +					full-duplex;
>> +				};
>> +			};
> 
> No hardcoded MAC addresses.
> 

For these 2 interfaces where I have the local-mac-address field, the MAC
addresses are set later by an application that reads the real address in some
EEPROM. However, in order to let the fman mac_probe to run successfully in the
first place I have set non-zero MAC addresses since the local-mac-address fields
are not set by u-boot.

I have found several local-mac-address fields in other DTS files that are all
zeros, and thus are rejected by of_get_mac_address. Are they leftovers from the
past or should they be used here as well ? If not, I will simply drop these 2
fields.

Thanks

Valentin