From: Arnd Bergmann <arnd@arndb•de>
To: John Youn <John.Youn@synopsys•com>
Cc: Christian Lamparter <chunkeey@googlemail•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Felipe Balbi <felipe.balbi@linux•intel.com>,
"linux-mips@linux-mips•org" <linux-mips@linux-mips•org>,
"gregkh@linuxfoundation•org" <gregkh@linuxfoundation•org>,
"linux-usb@vger•kernel.org" <linux-usb@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"a.seppala@gmail•com" <a.seppala@gmail•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Felipe Balbi <balbi@ti•com>,
Douglas Anderson <dianders@chromium•org>,
Gregory Herrero <gregory.herrero@intel•com>,
Mian Yousaf Kaukab <yousaf.kaukab@intel•com>,
Marek Szyprowski <m.szyprowski@samsung•com>
Subject: Re: [PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM systems
Date: Fri, 13 May 2016 15:48:14 +0200 [thread overview]
Message-ID: <5706100.G8QoS78uJd@wuerfel> (raw)
In-Reply-To: <573574F2.8010901@synopsys.com>
On Thursday 12 May 2016 23:32:18 John Youn wrote:
>
> Hi Arnd,
>
> The capitalization issue is still there in this patch.
>
> There's also a few checkpatch issues.
Fixed now, thanks. I'll send a v4 in a bit.
> And should the barrier be moved after the write like it says in the
> comment? That seems to have been removed since earlier versions of
> the patch.
I've clarified the comment, so we refer to the __raw_writel
not the writel. It's also possible that this was just another
bug in the patch that broke powerpc, but I don't know anything
about MIPS barrier semantics, so I prefer not to touch that.
Arnd
prev parent reply other threads:[~2016-05-13 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 20:56 [PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM systems Arnd Bergmann
2016-05-13 6:32 ` John Youn
2016-05-13 13:48 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5706100.G8QoS78uJd@wuerfel \
--to=arnd@arndb$(echo .)de \
--cc=John.Youn@synopsys$(echo .)com \
--cc=a.seppala@gmail$(echo .)com \
--cc=balbi@ti$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=chunkeey@googlemail$(echo .)com \
--cc=dianders@chromium$(echo .)org \
--cc=felipe.balbi@linux$(echo .)intel.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gregory.herrero@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=yousaf.kaukab@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox