From: Krzysztof Kozlowski <k.kozlowski@samsung•com>
To: Richard Henderson <rth@twiddle•net>,
Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
Matt Turner <mattst88@gmail•com>,
Vineet Gupta <vgupta@synopsys•com>,
Russell King <linux@armlinux•org.uk>,
Stefano Stabellini <sstabellini@kernel•org>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will.deacon@arm•com>,
Haavard Skinnemoen <hskinnemoen@gmail•com>,
Hans-Christian Egtvedt <egtvedt@samfundet•no>,
Steven Miao <realmz6@gmail•com>, Mark Salter <msalter@redhat•com>,
Aurelien Jacquiot <a-jacquiot@ti•com>,
Mikael Starvik <starvik@axis•com>,
Jesper Nilsson <jesper.nilsson@axis•com>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Richard Kuo <rkuo@codeaurora•org>,
Tony Luck <tony.luck@intel•com>,
Fenghua Yu <fenghua.yu@intel•com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
James Hogan <james.hogan@imgtec•com>,
Michal Simek <monstr@monstr•eu>,
Ralf Baechle <ralf@linux-mips•org>,
David Howells <dhowells@redhat•com>,
Ley Foon Tan <lftan@altera•com>, Jonas Bonn <jonas@southpole•se>,
"James E.J. Bottomley" <jejb@parisc-linux•org>,
Helge Deller <deller@gmx•de>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>,
Arnd Bergmann <arnd@arndb•de>, Olof Johansson <olof@lixom•net>,
Geoff Levand <geoff@infradead•org>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Guan Xuetao <gxt@mprc•pku.edu.cn>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, "H. Peter Anvin" <hpa@zytor•com>,
x86@kernel•org, Boris Ostrovsky <boris.ostrovsky@oracle•com>,
David Vrabel <david.vrabel@citrix•com>,
Juergen Gross <jgross@suse•com>,
Bjorn Helgaas <bhelgaas@google•com>,
David Airlie <airlied@linux•ie>, Joerg Roedel <joro@8bytes•org>,
David Woodhouse <dwmw2@infradead•org>,
Andrew Morton <akpm@linux-foundation•org>,
linux-doc@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-alpha@vger•kernel.org, linux-snps-arc@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
xen-devel@lists•xenproject.org,
adi-buildroot-devel@lists•sourceforge.net,
linux-c6x-dev@linux-c6x•org, linux-cris-kernel@axis•com,
uclinux-h8-devel@lists•sourceforge.jp,
linux-hexagon@vger•kernel.org, linux-ia64@vger•kernel.org,
linux-m68k@lists•linux-m68k.org, linux-metag@vger•kernel.org,
linux-mips@linux-mips•org, linux-am33-list@redhat•com,
nios2-dev@lists•rocketboards.org, linux-parisc@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-s390@vger•kernel.org,
linux-sh@vger•kernel.org, sparclinux@vger•kernel.org,
discuss@x86-64•org, linux-pci@vger•kernel.org,
linux-xtensa@linux-xtensa•org, dri-devel@lists•freedesktop.org,
linux-samsung-soc@vger•kernel.org,
linux-mediatek@lists•infradead.org,
linux-arm-msm@vger•kernel.org, freedreno@lists•freedesktop.org,
nouveau@lists•freedesktop.org,
linux-rockchip@lists•infradead.org, linux-rdma@vger•kernel.org,
iommu@lists•linux-foundation.org, linux-media@vger•kernel.org,
linux-omap@vger•kernel.org, linux-fbdev@vger•kernel.org
Cc: hch@infradead•org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>
Subject: Re: [RFC v3 01/45] powerpc: dma-mapping: Don't hard-code the value of DMA_ATTR_WEAK_ORDERING
Date: Fri, 03 Jun 2016 09:55:48 +0200 [thread overview]
Message-ID: <57513804.9020309@samsung.com> (raw)
In-Reply-To: <1464881987-13203-2-git-send-email-k.kozlowski@samsung.com>
On 06/02/2016 05:39 PM, Krzysztof Kozlowski wrote:
> Hard-coded value of DMA_ATTR_WEAK_ORDERING is then compared with the
> symbol. This will stop matching if the value of symbol is changed (when
> switching DMA attributes to unsigned long).
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
> ---
> arch/powerpc/platforms/cell/iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
> index 14a582b21274..0c2794d2b6c0 100644
> --- a/arch/powerpc/platforms/cell/iommu.c
> +++ b/arch/powerpc/platforms/cell/iommu.c
> @@ -1162,7 +1162,7 @@ static int __init setup_iommu_fixed(char *str)
> pciep = of_find_node_by_type(NULL, "pcie-endpoint");
>
> if (strcmp(str, "weak") == 0 || (pciep && strcmp(str, "strong") != 0))
> - iommu_fixed_is_weak = 1;
> + iommu_fixed_is_weak = DMA_ATTR_WEAK_ORDERING;
After some more thoughts given to this, I think my fix is not correct.
The 'iommu_fixed_is_weak' stores the bool and it is used to compare with
result of test_bit().
Please ignore this patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-06-03 7:55 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 15:39 [RFC v3 00/45] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 01/45] powerpc: dma-mapping: Don't hard-code the value of DMA_ATTR_WEAK_ORDERING Krzysztof Kozlowski
2016-06-03 7:55 ` Krzysztof Kozlowski [this message]
2016-06-02 15:39 ` [RFC v3 02/45] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-06-03 7:17 ` Geert Uytterhoeven
2016-06-03 7:50 ` Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 03/45] alpha: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 04/45] arc: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 05/45] ARM: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 06/45] arm64: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 07/45] avr32: " Krzysztof Kozlowski
2016-06-06 6:43 ` Hans-Christian Noren Egtvedt
2016-06-02 15:39 ` [RFC v3 08/45] blackfin: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 09/45] c6x: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 10/45] cris: " Krzysztof Kozlowski
2016-06-03 7:52 ` Jesper Nilsson
2016-06-02 15:39 ` [RFC v3 11/45] frv: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 12/45] drm/exynos: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 13/45] drm/mediatek: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 14/45] drm/msm: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 15/45] drm/nouveau: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 16/45] drm/rockship: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 17/45] infiniband: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 18/45] iommu: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 19/45] [media] " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 20/45] xen: " Krzysztof Kozlowski
2016-06-07 9:06 ` David Vrabel
2016-06-02 15:39 ` [RFC v3 21/45] swiotlb: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 22/45] powerpc: " Krzysztof Kozlowski
2016-06-03 11:56 ` Michael Ellerman
2016-06-03 12:39 ` Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 23/45] video: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 24/45] x86: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 25/45] iommu: intel: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 26/45] h8300: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 27/45] hexagon: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 28/45] ia64: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 29/45] m68k: " Krzysztof Kozlowski
2016-06-03 7:18 ` Geert Uytterhoeven
2016-06-02 15:39 ` [RFC v3 30/45] metag: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 31/45] microblaze: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 32/45] mips: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 33/45] mn10300: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 34/45] nios2: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 35/45] openrisc: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 36/45] parisc: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 37/45] misc: mic: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 38/45] s390: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 39/45] sh: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 40/45] sparc: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 41/45] tile: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 42/45] unicore32: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 43/45] xtensa: " Krzysztof Kozlowski
2016-06-02 15:39 ` [RFC v3 44/45] dma-mapping: Remove dma_get_attr Krzysztof Kozlowski
2016-06-06 6:45 ` Hans-Christian Noren Egtvedt
2016-06-02 15:39 ` [RFC v3 45/45] dma-mapping: Document the DMA attributes right in declaration Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57513804.9020309@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=a-jacquiot@ti$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=david.vrabel@citrix$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=dhowells@redhat$(echo .)com \
--cc=discuss@x86-64$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dwmw2@infradead$(echo .)org \
--cc=egtvedt@samfundet$(echo .)no \
--cc=fenghua.yu@intel$(echo .)com \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=geert@linux-m68k$(echo .)org \
--cc=geoff@infradead$(echo .)org \
--cc=gxt@mprc$(echo .)pku.edu.cn \
--cc=hch@infradead$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=hskinnemoen@gmail$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=james.hogan@imgtec$(echo .)com \
--cc=jejb@parisc-linux$(echo .)org \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jgross@suse$(echo .)com \
--cc=jonas@southpole$(echo .)se \
--cc=joro@8bytes$(echo .)org \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=lftan@altera$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-am33-list@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-cris-kernel@axis$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=mpe@ellerman$(echo .)id.au \
--cc=msalter@redhat$(echo .)com \
--cc=nios2-dev@lists$(echo .)rocketboards.org \
--cc=nouveau@lists$(echo .)freedesktop.org \
--cc=olof@lixom$(echo .)net \
--cc=paulus@samba$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=realmz6@gmail$(echo .)com \
--cc=rkuo@codeaurora$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=sstabellini@kernel$(echo .)org \
--cc=starvik@axis$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=uclinux-h8-devel@lists$(echo .)sourceforge.jp \
--cc=vgupta@synopsys$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox