Subject: Re: [PATCH v5 08/11] powerpc/powernv: Add platform support for stop instruction

From: Shreyas B Prabhu <[email-masked]>
Date: Thu, 09 Jun 2016 21:39:09 +0530

On 06/09/2016 10:12 AM, Sam Bobroff wrote:
> On Thu, Jun 02, 2016 at 07:38:58AM -0500, Shreyas B. Prabhu wrote:
> 
> ...
> 
>> +/* Power Management - PSSCR Fields */
> 
> It might be nice to give the full name of the register, as below with the FPSCR.
> 

I'll make the change while posting the next rev.

Thanks,
Shreyas

>> +#define PSSCR_RL_MASK		0x0000000F
>> +#define PSSCR_MTL_MASK		0x000000F0
>> +#define PSSCR_TR_MASK		0x00000300
>> +#define PSSCR_PSLL_MASK		0x000F0000
>> +#define PSSCR_EC		0x00100000
>> +#define PSSCR_ESL		0x00200000
>> +#define PSSCR_SD		0x00400000
>> +
>> +
>>  /* Floating Point Status and Control Register (FPSCR) Fields */
> 
> Cheers,
> Sam.
>