From: Jacek Anaszewski <j.anaszewski@samsung•com>
To: "Andrew F. Davis" <afd@ti•com>
Cc: Russell King <linux@armlinux•org.uk>,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail•com>,
Linus Walleij <linus.walleij@linaro•org>,
Sebastian Reichel <sre@kernel•org>,
Wolfram Sang <wsa@the-dreams•de>,
Richard Purdie <rpurdie@rpsys•net>,
Rusty Russell <rusty@rustcorp•com.au>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Mauro Carvalho Chehab <mchehab@osg•samsung.com>,
Ulf Hansson <ulf.hansson@linaro•org>,
Lauro Ramos Venancio <lauro.venancio@openbossa•org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa•org>,
Samuel Ortiz <sameo@linux•intel.com>,
Ingo Molnar <mingo@kernel•org>,
linux-pwm@vger•kernel.org, lguest@lists•ozlabs.org,
linux-wireless@vger•kernel.org, linux-mmc@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-gpio@vger•kernel.org,
linux-i2c@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-leds@vger•kernel.org, linux-media@vger•kernel.org
Subject: Re: [PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS is set
Date: Wed, 15 Jun 2016 08:48:50 +0200 [thread overview]
Message-ID: <5760FA52.7010806@samsung.com> (raw)
In-Reply-To: <20160613200211.14790-13-afd@ti.com>
Hi Andrew,
Thanks for the patch.
Please address the issue [1] raised by test bot and resubmit.
Thanks,
Jacek Anaszewski
[1] https://lkml.org/lkml/2016/6/13/1091
On 06/13/2016 10:02 PM, Andrew F. Davis wrote:
> When CONFIG_NEW_LEDS is not set make will still descend into the leds
> directory but nothing will be built. This produces unneeded build
> artifacts and messages in addition to slowing the build. Fix this here.
>
> Signed-off-by: Andrew F. Davis <afd@ti•com>
> ---
> drivers/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 567e32c..fa514d5 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -127,7 +127,7 @@ obj-$(CONFIG_CPU_FREQ) += cpufreq/
> obj-$(CONFIG_CPU_IDLE) += cpuidle/
> obj-$(CONFIG_MMC) += mmc/
> obj-$(CONFIG_MEMSTICK) += memstick/
> -obj-y += leds/
> +obj-$(CONFIG_NEW_LEDS) += leds/
> obj-$(CONFIG_INFINIBAND) += infiniband/
> obj-$(CONFIG_SGI_SN) += sn/
> obj-y += firmware/
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-06-15 6:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 20:01 [PATCH 00/12] Remove unneeded build directory traversals Andrew F. Davis
2016-06-13 20:02 ` [PATCH 01/12] gpio: Only descend into gpio directory when CONFIG_GPIOLIB is set Andrew F. Davis
2016-06-14 6:58 ` Linus Walleij
2016-06-13 20:02 ` [PATCH 02/12] pwm: Only descend into pwm directory when CONFIG_PWM " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 03/12] amba: Only descend into amba directory when CONFIG_ARM_AMBA " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 04/12] NFC: Only descend into nfc directory when CONFIG_NFC " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 05/12] macintosh: Only descend into directory when CONFIG_MACINTOSH_DRIVERS " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 06/12] hsi: Only descend into hsi directory when CONFIG_HSI " Andrew F. Davis
2016-06-14 0:36 ` kbuild test robot
2016-06-14 16:13 ` [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled Andrew F. Davis
2016-06-15 12:48 ` Sebastian Reichel
2016-06-13 20:02 ` [PATCH 07/12] auxdisplay: Only descend into directory when CONFIG_AUXDISPLAY is set Andrew F. Davis
2016-06-13 20:02 ` [PATCH 08/12] i2c: Only descend into i2c directory when CONFIG_I2C " Andrew F. Davis
2016-06-14 0:18 ` kbuild test robot
2016-06-13 20:02 ` [PATCH 09/12] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 10/12] lguest: Only descend into lguest directory when CONFIG_LGUEST " Andrew F. Davis
2016-06-20 20:44 ` Rusty Russell
2016-06-13 20:02 ` [PATCH 11/12] mmc: Only descend into mmc directory when CONFIG_MMC " Andrew F. Davis
2016-06-14 1:33 ` kbuild test robot
2016-06-13 20:02 ` [PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS " Andrew F. Davis
2016-06-14 0:19 ` kbuild test robot
2016-06-15 6:48 ` Jacek Anaszewski [this message]
2016-06-17 22:46 ` Andrew F. Davis
2016-06-20 7:41 ` Jacek Anaszewski
2016-06-20 22:13 ` [PATCH] leds: Add no-op gpio_led_register_device when LED subsystem is disabled Andrew F. Davis
2016-06-21 7:09 ` Jacek Anaszewski
2016-06-21 11:48 ` Andrew F. Davis
2016-06-21 13:11 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5760FA52.7010806@samsung.com \
--to=j.anaszewski@samsung$(echo .)com \
--cc=afd@ti$(echo .)com \
--cc=aloisio.almeida@openbossa$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=lauro.venancio@openbossa$(echo .)org \
--cc=lguest@lists$(echo .)ozlabs.org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mchehab@osg$(echo .)samsung.com \
--cc=miguel.ojeda.sandonis@gmail$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=rpurdie@rpsys$(echo .)net \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sameo@linux$(echo .)intel.com \
--cc=sre@kernel$(echo .)org \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=wsa@the-dreams$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox