Hi All,

You removed PAGE_GUARDED in the commit

https://git.ker= nel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3Dc04a5880299eab= 3da8c10547db96ea9cdffd44a6

We use

range.size, _PAGE_NO_CACHE|_PAGE_GUARDED);

This doesn't work anymore. What can we use instead?

Thanks in advance,

Christian

<= /html>= --Apple-Mail-2C897F81-C964-4F59-BCD7-1703DF9C0C0F-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rCrbp3LVmzDqD8 for ; Mon, 23 May 2016 18:01:54 +1000 (AEST) Message-ID: <1463990507.3078.16.camel@kernel.crashing.org> Subject: Re: PAGE_GUARDED From: Benjamin Herrenschmidt To: Christian Zigotzky , linuxppc-dev@lists.ozlabs.org Cc: darren@stevens-zone.net Date: Mon, 23 May 2016 18:01:47 +1000 In-Reply-To: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2016-05-23 at 06:38 +0200, Christian Zigotzky wrote: > Hi All, > > You removed PAGE_GUARDED in the commit > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi > t/?id=c04a5880299eab3da8c10547db96ea9cdffd44a6 > > We use > > range.size, _PAGE_NO_CACHE|_PAGE_GUARDED); > > This doesn't work anymore. What can we use instead? You should just use pgprot_noncached() Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rDXNt6TwQzDqF4 for ; Tue, 24 May 2016 20:54:54 +1000 (AEST) Subject: PAGE_GUARDED To: Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> From: Christian Zigotzky Message-ID: Date: Tue, 24 May 2016 12:48:48 +0200 MIME-Version: 1.0 In-Reply-To: <1463990507.3078.16.camel@kernel.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ben, Thanks for the hint. I'm sorry I don't know how pgprot_noncached() works. I tried: 1) range.size, pgprot_noncached() 2) range.size, pgprot_val(pgprot_noncached(__pgprot(0)))); 3) range.size, pgprot_val(pgprot_noncached_wc(__pgprot(0)))); Unfortunately without any success. I'd like to modify the following code for the ATi SB600 southbridge chipset: /* Workaround for lack of device tree */ if (primary) { __ioremap_at(range.cpu_addr, (void *)ISA_IO_BASE, range.size, _PAGE_NO_CACHE|_PAGE_GUARDED); hose->io_base_virt = (void *)_IO_BASE; printk("Initialised io_base_virt 0x%lx _IO_BASE 0x%llx\n", (unsigned long)hose->io_base_virt, (unsigned long long)_IO_BASE); } This workaround works with the kernel 4.6 final. After the commit powerpc-4.7-1, the computer doesn't boot anymore. Last message in the CFE firmware: Booting Linux via __start()... Cheers, Christian On 23 May 2016 at 10:01 AM, Benjamin Herrenschmidt wrote: > On Mon, 2016-05-23 at 06:38 +0200, Christian Zigotzky wrote: >> Hi All, >> >> You removed PAGE_GUARDED in the commit >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi >> t/?id=c04a5880299eab3da8c10547db96ea9cdffd44a6 >> >> We use >> >> range.size, _PAGE_NO_CACHE|_PAGE_GUARDED); >> >> This doesn't work anymore. What can we use instead? > You should just use pgprot_noncached() > > Cheers, > Ben. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rDXtd00YPzDqMb for ; Tue, 24 May 2016 21:17:12 +1000 (AEST) Message-ID: <1464088614.3078.79.camel@kernel.crashing.org> Subject: Re: PAGE_GUARDED From: Benjamin Herrenschmidt To: Christian Zigotzky , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net Cc: "Aneesh Kumar K.V" , Michael Ellerman Date: Tue, 24 May 2016 21:16:54 +1000 In-Reply-To: References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2016-05-24 at 12:48 +0200, Christian Zigotzky wrote: > Ben, > > Thanks for the hint. I'm sorry I don't know how pgprot_noncached() > works. > > I tried: > > 1) range.size, pgprot_noncached() > > 2) range.size, pgprot_val(pgprot_noncached(__pgprot(0)))); Hrm... The above is what is used elsewhere, I'm not sure what's wrong. Aneesh, any idea ? Michael, does it work on our PA-Semi board ? (DO we have that southbridge on it ?) Actually, can you try pgprot_noncached(PAGE_KERNEL) ? If that works, then I wonder what that's going on in pci_64.c ... Cheers, Ben. > 3) range.size, pgprot_val(pgprot_noncached_wc(__pgprot(0)))); > > Unfortunately without any success. > > I'd like to modify the following code for the ATi SB600 southbridge > chipset: > > /* Workaround for lack of device tree */ > if (primary) { > __ioremap_at(range.cpu_addr, (void > *)ISA_IO_BASE, > range.size, > _PAGE_NO_CACHE|_PAGE_GUARDED); > hose->io_base_virt = (void > *)_IO_BASE; > printk("Initialised io_base_virt > 0x%lx > _IO_BASE 0x%llx\n", (unsigned long)hose->io_base_virt, (unsigned > long > long)_IO_BASE); > } > > This workaround works with the kernel 4.6 final. After the commit > powerpc-4.7-1, the computer doesn't boot anymore. > > Last message in the CFE firmware: > > Booting Linux via __start()... > > Cheers, > > Christian > > > On 23 May 2016 at 10:01 AM, Benjamin Herrenschmidt wrote: > > > > On Mon, 2016-05-23 at 06:38 +0200, Christian Zigotzky wrote: > > > > > > Hi All, > > > > > > You removed PAGE_GUARDED in the commit > > > > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/c > > > ommi > > > t/?id=c04a5880299eab3da8c10547db96ea9cdffd44a6 > > > > > > We use > > > > > > range.size, _PAGE_NO_CACHE|_PAGE_GUARDED); > > > > > > This doesn't work anymore. What can we use instead? > > You should just use pgprot_noncached() > > > > Cheers, > > Ben. > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rDc8F5TpGzDqHh for ; Tue, 24 May 2016 23:44:12 +1000 (AEST) Subject: PAGE_GUARDED To: Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> Cc: "Aneesh Kumar K.V" , Michael Ellerman From: Christian Zigotzky Message-ID: <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> Date: Tue, 24 May 2016 15:37:58 +0200 MIME-Version: 1.0 In-Reply-To: <1464088614.3078.79.camel@kernel.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ben, I tried: /* Workaround for lack of device tree */ if (primary) { __ioremap_at(range.cpu_addr, (void *)ISA_IO_BASE, range.size, pgprot_noncached(PAGE_KERNEL)); hose->io_base_virt = (void *)_IO_BASE; printk("Initialised io_base_virt 0x%lx _IO_BASE 0x%llx\n", (unsigned long)hose->io_base_virt, (unsigned long long)_IO_BASE); } Unfortunately I got some error messages: arch/powerpc/kernel/pci-common.c: In function ‘pci_process_bridge_OF_ranges’: arch/powerpc/kernel/pci-common.c:731:32: error: incompatible type for argument 4 of ‘__ioremap_at’ __ioremap_at(range.cpu_addr, (void *)ISA_IO_BASE, ^ In file included from include/linux/io.h:25:0, from include/linux/pci.h:31, from arch/powerpc/kernel/pci-common.c:20: ./arch/powerpc/include/asm/io.h:746:23: note: expected ‘long unsigned int’ but argument is of type ‘pgprot_t’ extern void __iomem * __ioremap_at(phys_addr_t pa, void *ea, Cheers, Christian On 24 May 2016 at 1:16 PM, Benjamin Herrenschmidt wrote: > Actually, can you try pgprot_noncached(PAGE_KERNEL) ? If that works, > then I wonder what that's going on in pci_64.c ... > > Cheers, > Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) (using TLSv1.2 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rDfgf0sgQzDqKM for ; Wed, 25 May 2016 01:38:06 +1000 (AEST) Received: from localhost by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 May 2016 01:38:04 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 8CAD82CE8054 for ; Wed, 25 May 2016 01:38:01 +1000 (EST) Received: from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u4OFbrJ85439964 for ; Wed, 25 May 2016 01:38:01 +1000 Received: from d23av06.au.ibm.com (localhost [127.0.0.1]) by d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u4OFbTat022695 for ; Wed, 25 May 2016 01:37:29 +1000 From: "Aneesh Kumar K.V" To: Christian Zigotzky , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net Cc: Michael Ellerman Subject: Re: PAGE_GUARDED In-Reply-To: <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> Date: Tue, 24 May 2016 21:07:10 +0530 Message-ID: <87d1obqxg9.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Christian Zigotzky writes: > Ben, > > I tried: > > /* Workaround for lack of device tree */ > if (primary) { > __ioremap_at(range.cpu_addr, (void=20 > *)ISA_IO_BASE, > range.size, pgprot_noncached(PAGE_KERNEL)= ); > hose->io_base_virt =3D (void *)_IO_BASE; > printk("Initialised io_base_virt 0x%lx _IO_BASE=20 > 0x%llx\n", (unsigned long)hose->io_base_virt, (unsigned long long)_IO_BAS= E); > } > > Unfortunately I got some error messages: > > arch/powerpc/kernel/pci-common.c: In function=20 > =E2=80=98pci_process_bridge_OF_ranges=E2=80=99: > arch/powerpc/kernel/pci-common.c:731:32: error: incompatible type for=20 > argument 4 of =E2=80=98__ioremap_at=E2=80=99 > __ioremap_at(range.cpu_addr, (void=20 > *)ISA_IO_BASE, > ^ > In file included from include/linux/io.h:25:0, > from include/linux/pci.h:31, > from arch/powerpc/kernel/pci-common.c:20: > ./arch/powerpc/include/asm/io.h:746:23: note: expected =E2=80=98long unsi= gned=20 > int=E2=80=99 but argument is of type =E2=80=98pgprot_t=E2=80=99 > extern void __iomem * __ioremap_at(phys_addr_t pa, void *ea, > You can look at commit 72176dd0ad36c ("powerpc/mm: Use a helper for finding pte bits mapping I/O area") to find similar conversion we did. For ex: __ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE, size, _PAGE_NO_CACHE|_PAGE_GUARDED); gets replaced by __ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE, size, pgprot_val(pgprot_noncached(__pgprot(0)))); Now that gets mapped to the below hpte bits pte bit -> _PAGE_NON_IDEMPOTENT Which get converted in htab_convert_pte_flags(unsigned long pteflags) to if ((pteflags & _PAGE_CACHE_CTL ) =3D=3D _PAGE_NON_IDEMPOTENT) rflags |=3D (HPTE_R_I | HPTE_R_G); BTW we default add (HPTE_R_C | HPTE_R_M ). Hence the final pte WIMG bits will be MIG. I guess that is what you wanted ? If that doesn't work, can you point me the current code so that I can look at it and suggest correct alternative. -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rF3VM5G3nzDqV3 for ; Wed, 25 May 2016 17:16:26 +1000 (AEST) Subject: PAGE_GUARDED To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> Cc: Michael Ellerman From: Christian Zigotzky Message-ID: Date: Wed, 25 May 2016 08:58:03 +0200 MIME-Version: 1.0 In-Reply-To: <87d1obqxg9.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Aneesh, Thank you for your help. I tried /* Workaround for lack of device tree */ if (primary) { __ioremap_at(range.cpu_addr, (void *)ISA_IO_BASE, range.size, HPTE_R_C | HPTE_R_M); hose->io_base_virt = (void *)_IO_BASE; printk("Initialised io_base_virt 0x%lx _IO_BASE 0x%llx\n", (unsigned long)hose->io_base_virt, (unsigned long long)_IO_BASE); } Unfortunately the kernel doesn't boot. Cheers, Christian On 24 May 2016 at 5:37 PM, Aneesh Kumar K.V wrote: > You can look at commit 72176dd0ad36c ("powerpc/mm: Use a helper for > finding pte bits mapping I/O area") to find similar conversion we did. > > For ex: > __ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE, > size, _PAGE_NO_CACHE|_PAGE_GUARDED); > > gets replaced by > > __ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE, > size, pgprot_val(pgprot_noncached(__pgprot(0)))); > > Now that gets mapped to the below hpte bits > > pte bit -> _PAGE_NON_IDEMPOTENT > > Which get converted in htab_convert_pte_flags(unsigned long pteflags) > to > > if ((pteflags & _PAGE_CACHE_CTL ) == _PAGE_NON_IDEMPOTENT) > rflags |= (HPTE_R_I | HPTE_R_G); > > BTW we default add (HPTE_R_C | HPTE_R_M ). > > Hence the final pte WIMG bits will be MIG. I guess that is what you > wanted ? > > > If that doesn't work, can you point me the current code so that I can > look at it and suggest correct alternative. > > -aneesh > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rF9bC3x00zDqVp for ; Wed, 25 May 2016 21:51:02 +1000 (AEST) Subject: PAGE_GUARDED To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> Cc: Michael Ellerman From: Christian Zigotzky Message-ID: <79a087a4-24ed-3823-87f5-28df695d3d8a@xenosoft.de> Date: Wed, 25 May 2016 13:44:54 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Aneesh, I understand what you mean. I tried range.size, pgprot_val(pgprot_noncached(__pgprot(0)))); a few days ago. It compiled but the kernel doesn't boot. Cheers, Christian On 25 May 2016 at 08:58 AM, Christian Zigotzky wrote: > Aneesh, > > Thank you for your help. I tried > > /* Workaround for lack of device tree */ > if (primary) { > __ioremap_at(range.cpu_addr, (void > *)ISA_IO_BASE, > range.size, HPTE_R_C | HPTE_R_M); > hose->io_base_virt = (void *)_IO_BASE; > printk("Initialised io_base_virt 0x%lx _IO_BASE > 0x%llx\n", (unsigned long)hose->io_base_virt, (unsigned long > long)_IO_BASE); > } > > Unfortunately the kernel doesn't boot. > > Cheers, > > Christian > > On 24 May 2016 at 5:37 PM, Aneesh Kumar K.V wrote: >> You can look at commit 72176dd0ad36c ("powerpc/mm: Use a helper for >> finding pte bits mapping I/O area") to find similar conversion we did. >> >> For ex: >> __ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE, >> size, _PAGE_NO_CACHE|_PAGE_GUARDED); >> >> gets replaced by >> >> __ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE, >> size, pgprot_val(pgprot_noncached(__pgprot(0)))); >> >> Now that gets mapped to the below hpte bits >> >> pte bit -> _PAGE_NON_IDEMPOTENT >> >> Which get converted in htab_convert_pte_flags(unsigned long pteflags) >> to >> >> if ((pteflags & _PAGE_CACHE_CTL ) == _PAGE_NON_IDEMPOTENT) >> rflags |= (HPTE_R_I | HPTE_R_G); >> >> BTW we default add (HPTE_R_C | HPTE_R_M ). >> >> Hence the final pte WIMG bits will be MIG. I guess that is what you >> wanted ? >> >> >> If that doesn't work, can you point me the current code so that I can >> look at it and suggest correct alternative. >> >> -aneesh >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rMCDX5sLwzDq80 for ; Sat, 4 Jun 2016 17:25:48 +1000 (AEST) Subject: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> From: Christian Zigotzky Message-ID: <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> Date: Sat, 4 Jun 2016 09:19:36 +0200 MIME-Version: 1.0 In-Reply-To: <87d1obqxg9.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi All, The commit powerpc-4.7-2 [2] was released yesterday. There is a conflict in my local kernel git directory if I use git pull because I have reverted the commit powerpc-4.7-1. [1] The commit powerpc-4.7-2 [2] needs the commit powerpc-4.7-1. [1] I created a new local kernel git directory for the RC2 with: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git linux-git-without-powerpc-commits After that I reverted the two commits: powerpc-4.7-2 [2]: git revert 5306d766f15e72bc79c61d88f77e5a6b1fcc0e68 -m 1 powerpc-4.7-1 [1]: git revert c04a5880299eab3da8c10547db96ea9cdffd44a6 -m 1 Afterwards I successfully tested our latest Nemo patch 4.7-1 [3] with the following commands: cp -R linux-git-without-powerpc-commits linux-4.7 patch -p0 < nemo_4.7-1.patch I tried to solve the boot issue last week. I modified the code a lot and I replaced some files. Unfortunately without any success. The RC1 without the commit powerpc-4.7-1 [1] boots and works fantastic. I don't have any ideas anymore. Please help me to solve the boot problems. Thanks in advance, Christian [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c04a5880299eab3da8c10547db96ea9cdffd44a6 [2] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5306d766f15e72bc79c61d88f77e5a6b1fcc0e68 [3] http://www.xenosoft.de/nemo_4.7-1.patch On 28 May 2016 at 8:51 PM, Darren Stevens wrote: > Hello Adrian > > On 28/05/2016, Adrian Cox wrote: >>> From: Christian Zigotzky [mailto:chzigotzky@xenosoft.de] >>> Sent: 28 May 2016 07:06 >>> Adrian, what is the expected WIMG bit mapping for the Nemo board? >>> >> I'm not able to help much here, I'm afraid. I don't have a Nemo board at >> the moment, and it's been a few years. From memory all the peripherals >> required standard uncached and guarded mappings on Nemo. > Before everybody gets too involved, from what I've seen with my tests today > the kernel is crashing long before it gets to the pci-common code. > > I've attached 2 boot logs, one from a 4.4 kernel I've been working on, and > from a build of the latest git. > > You can see from this that the 4.7 kernel hangs right after the booting linux > via __start(), whereas in the 4.4 there's about 29 lines of output before it > gets to the Initialised io_base_virt printk in our patch. > > The last time we had a hang this early in the boot it turned out to be a > problem in head_64.S, I think there is something else wrong in the commit > Christian has identified > > I will see if this is something I can fix, but it may need better low level > knowledge of PPC hardware than I have. > > Regards > Darren On 28 May 2016 at 6:53 PM, Adrian Cox wrote: >> From: Christian Zigotzky [mailto:chzigotzky@xenosoft.de] >> Sent: 28 May 2016 07:06 >> Adrian, what is the expected WIMG bit mapping for the Nemo board? >> > I'm not able to help much here, I'm afraid. I don't have a Nemo board at the moment, and it's been a few years. From memory all the peripherals required standard uncached and guarded mappings on Nemo. > > The difficult bit that usually breaks on kernel upgrades is not the WIMG settings, but the PCI probing routine. The SB600 doesn't follow normal PCIe address decoding rules, as in its original use as an AMD south bridge it was designed to appear as if it were integrated into the north bridge. > > -- > Adrian > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rMCZG0w8zzDq8G for ; Sat, 4 Jun 2016 17:41:09 +1000 (AEST) Subject: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> From: Christian Zigotzky Message-ID: <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> Date: Sat, 4 Jun 2016 09:40:54 +0200 MIME-Version: 1.0 In-Reply-To: <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Aneesh, Could you please send me only your patch for the Power ISA 3.0 (Power9) Radix Tree MMU? You have done the most modifications for the kernel 4.7. If the kernel boots with your modifications then I have to look to the other few modifications. Thanks in advance, Christian On 04 June 2016 at 09:19 AM, Christian Zigotzky wrote: > Hi All, > > The commit powerpc-4.7-2 [2] was released yesterday. > > There is a conflict in my local kernel git directory if I use git pull > because I have reverted the commit powerpc-4.7-1. [1] > > The commit powerpc-4.7-2 [2] needs the commit powerpc-4.7-1. [1] > > I created a new local kernel git directory for the RC2 with: > > git clone > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > linux-git-without-powerpc-commits > > After that I reverted the two commits: > > powerpc-4.7-2 [2]: > > git revert 5306d766f15e72bc79c61d88f77e5a6b1fcc0e68 -m 1 > > powerpc-4.7-1 [1]: > > git revert c04a5880299eab3da8c10547db96ea9cdffd44a6 -m 1 > > Afterwards I successfully tested our latest Nemo patch 4.7-1 [3] with > the following commands: > > cp -R linux-git-without-powerpc-commits linux-4.7 > > patch -p0 < nemo_4.7-1.patch > > I tried to solve the boot issue last week. I modified the code a lot > and I replaced some files. Unfortunately without any success. The RC1 > without the commit powerpc-4.7-1 [1] boots and works fantastic. I > don't have any ideas anymore. Please help me to solve the boot problems. > > Thanks in advance, > > Christian > > [1] > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c04a5880299eab3da8c10547db96ea9cdffd44a6 > [2] > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5306d766f15e72bc79c61d88f77e5a6b1fcc0e68 > [3] http://www.xenosoft.de/nemo_4.7-1.patch > > On 28 May 2016 at 8:51 PM, Darren Stevens wrote: >> Hello Adrian >> >> On 28/05/2016, Adrian Cox wrote: >>>> From: Christian Zigotzky [mailto:chzigotzky@xenosoft.de] >>>> Sent: 28 May 2016 07:06 >>>> Adrian, what is the expected WIMG bit mapping for the Nemo board? >>>> >>> I'm not able to help much here, I'm afraid. I don't have a Nemo >>> board at >>> the moment, and it's been a few years. From memory all the peripherals >>> required standard uncached and guarded mappings on Nemo. >> Before everybody gets too involved, from what I've seen with my tests >> today >> the kernel is crashing long before it gets to the pci-common code. >> >> I've attached 2 boot logs, one from a 4.4 kernel I've been working >> on, and >> from a build of the latest git. >> >> You can see from this that the 4.7 kernel hangs right after the >> booting linux >> via __start(), whereas in the 4.4 there's about 29 lines of output >> before it >> gets to the Initialised io_base_virt printk in our patch. >> >> The last time we had a hang this early in the boot it turned out to be a >> problem in head_64.S, I think there is something else wrong in the >> commit >> Christian has identified >> >> I will see if this is something I can fix, but it may need better low >> level >> knowledge of PPC hardware than I have. >> >> Regards >> Darren > > On 28 May 2016 at 6:53 PM, Adrian Cox wrote: >>> From: Christian Zigotzky [mailto:chzigotzky@xenosoft.de] >>> Sent: 28 May 2016 07:06 >>> Adrian, what is the expected WIMG bit mapping for the Nemo board? >>> >> I'm not able to help much here, I'm afraid. I don't have a Nemo board >> at the moment, and it's been a few years. From memory all the >> peripherals required standard uncached and guarded mappings on Nemo. >> >> The difficult bit that usually breaks on kernel upgrades is not the >> WIMG settings, but the PCI probing routine. The SB600 doesn't follow >> normal PCIe address decoding rules, as in its original use as an AMD >> south bridge it was designed to appear as if it were integrated into >> the north bridge. >> >> -- >> Adrian >> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rMJ9j4J41zDq80 for ; Sat, 4 Jun 2016 21:08:38 +1000 (AEST) Subject: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox , "R.T.Dickinson" , "R.T.Dickinson" , Pat Wall , Pat Wall , "contact@a-eon.com" , Matthew Leaman , luigi burdo , Christian Zigotzky References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> From: Christian Zigotzky Message-ID: Date: Sat, 4 Jun 2016 13:08:22 +0200 MIME-Version: 1.0 In-Reply-To: <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi All, I compiled the latest git version of kernel 4.7 with all PowerPC commits. Maybe the latest commit powerpc-4.7-2 solved the boot issues. Our latest Nemo patch 4.7-1 works without any problems with the latest git version. I got the following error message: arch/powerpc/kernel/pci-common.c: In function ‘pci_process_bridge_OF_ranges’: arch/powerpc/kernel/pci-common.c:732:59: error: ‘_PAGE_GUARDED’ undeclared (first use in this function) range.size, _PAGE_NO_CACHE|_PAGE_GUARDED); ^ arch/powerpc/kernel/pci-common.c:732:59: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/powerpc/kernel/pci-common.o] Error 1 make: *** [arch/powerpc/kernel] Error 2 I replaced __ioremap_at(range.cpu_addr, (void *)ISA_IO_BASE, range.size, _PAGE_NO_CACHE|_PAGE_GUARDED); with __ioremap_at(range.cpu_addr, (void *)ISA_IO_BASE, range.size, pgprot_val(pgprot_noncached(__pgprot(0)))); After that it compiled. Unfortunately it doesn't boot. :-( Which files are responsible for the early boot phase in the commit powerpc-4.7-1? Perhaps the problem is there. Cheers, Christian On 04 June 2016 at 09:40 AM, Christian Zigotzky wrote: > Aneesh, > > Could you please send me only your patch for the Power ISA 3.0 > (Power9) Radix Tree MMU? You have done the most modifications for the > kernel 4.7. If the kernel boots with your modifications then I have to > look to the other few modifications. > > Thanks in advance, > > Christian > > On 04 June 2016 at 09:19 AM, Christian Zigotzky wrote: >> Hi All, >> >> The commit powerpc-4.7-2 [2] was released yesterday. >> >> There is a conflict in my local kernel git directory if I use git >> pull because I have reverted the commit powerpc-4.7-1. [1] >> >> The commit powerpc-4.7-2 [2] needs the commit powerpc-4.7-1. [1] >> >> I created a new local kernel git directory for the RC2 with: >> >> git clone >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> linux-git-without-powerpc-commits >> >> After that I reverted the two commits: >> >> powerpc-4.7-2 [2]: >> >> git revert 5306d766f15e72bc79c61d88f77e5a6b1fcc0e68 -m 1 >> >> powerpc-4.7-1 [1]: >> >> git revert c04a5880299eab3da8c10547db96ea9cdffd44a6 -m 1 >> >> Afterwards I successfully tested our latest Nemo patch 4.7-1 [3] with >> the following commands: >> >> cp -R linux-git-without-powerpc-commits linux-4.7 >> >> patch -p0 < nemo_4.7-1.patch >> >> I tried to solve the boot issue last week. I modified the code a lot >> and I replaced some files. Unfortunately without any success. The RC1 >> without the commit powerpc-4.7-1 [1] boots and works fantastic. I >> don't have any ideas anymore. Please help me to solve the boot problems. >> >> Thanks in advance, >> >> Christian >> >> [1] >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c04a5880299eab3da8c10547db96ea9cdffd44a6 >> [2] >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5306d766f15e72bc79c61d88f77e5a6b1fcc0e68 >> [3] http://www.xenosoft.de/nemo_4.7-1.patch >> >> On 28 May 2016 at 8:51 PM, Darren Stevens wrote: >>> Hello Adrian >>> >>> On 28/05/2016, Adrian Cox wrote: >>>>> From: Christian Zigotzky [mailto:chzigotzky@xenosoft.de] >>>>> Sent: 28 May 2016 07:06 >>>>> Adrian, what is the expected WIMG bit mapping for the Nemo board? >>>>> >>>> I'm not able to help much here, I'm afraid. I don't have a Nemo >>>> board at >>>> the moment, and it's been a few years. From memory all the peripherals >>>> required standard uncached and guarded mappings on Nemo. >>> Before everybody gets too involved, from what I've seen with my >>> tests today >>> the kernel is crashing long before it gets to the pci-common code. >>> >>> I've attached 2 boot logs, one from a 4.4 kernel I've been working >>> on, and >>> from a build of the latest git. >>> >>> You can see from this that the 4.7 kernel hangs right after the >>> booting linux >>> via __start(), whereas in the 4.4 there's about 29 lines of output >>> before it >>> gets to the Initialised io_base_virt printk in our patch. >>> >>> The last time we had a hang this early in the boot it turned out to >>> be a >>> problem in head_64.S, I think there is something else wrong in the >>> commit >>> Christian has identified >>> >>> I will see if this is something I can fix, but it may need better >>> low level >>> knowledge of PPC hardware than I have. >>> >>> Regards >>> Darren >> >> On 28 May 2016 at 6:53 PM, Adrian Cox wrote: >>>> From: Christian Zigotzky [mailto:chzigotzky@xenosoft.de] >>>> Sent: 28 May 2016 07:06 >>>> Adrian, what is the expected WIMG bit mapping for the Nemo board? >>>> >>> I'm not able to help much here, I'm afraid. I don't have a Nemo >>> board at the moment, and it's been a few years. From memory all the >>> peripherals required standard uncached and guarded mappings on Nemo. >>> >>> The difficult bit that usually breaks on kernel upgrades is not the >>> WIMG settings, but the PCI probing routine. The SB600 doesn't >>> follow normal PCIe address decoding rules, as in its original use as >>> an AMD south bridge it was designed to appear as if it were >>> integrated into the north bridge. >>> >>> -- >>> Adrian >>> >> >> >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158]) (using TLSv1.2 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rMNwJ0GwkzDq80 for ; Sun, 5 Jun 2016 00:42:23 +1000 (AEST) Received: from localhost by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 4 Jun 2016 08:42:21 -0600 From: "Aneesh Kumar K.V" To: Christian Zigotzky , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox Subject: Re: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE In-Reply-To: <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> Date: Sat, 04 Jun 2016 20:12:15 +0530 Message-ID: <874m99uibc.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Christian Zigotzky writes: > Aneesh, > > Could you please send me only your patch for the Power ISA 3.0 (Power9) > Radix Tree MMU? You have done the most modifications for the kernel 4.7. > If the kernel boots with your modifications then I have to look to the > other few modifications. > > Thanks in advance, > Are you looking for changes too kernel that will add ISA 3.0 MMU model without making changes to other part of kernel ?. I don't think we ever had a kernel patch which did the ISA 3.0 work like that. In order to add the new ISA support we did have to make changes to other part of the kernel. To debug your boot issue, I still haven't understood why the suggested changes are not working. Because for a non cache guarded page the mapping didn't change at all. Hence I was asking for what the expected WIMG values are for your board. One other option is to bisect test the kernel and if you can isolate which patch is breaking the boot, we can possibly understand it better. ie, instead of reverting the entire merge, try a git bisect. -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) (using TLSv1.2 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rMP196dtXzDq80 for ; Sun, 5 Jun 2016 00:46:37 +1000 (AEST) Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 4 Jun 2016 08:46:35 -0600 From: "Aneesh Kumar K.V" To: Christian Zigotzky , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox , "R.T.Dickinson" , "R.T.Dickinson" , Pat Wall , Pat Wall , "contact@a-eon.com" , Matthew Leaman , luigi burdo , Christian Zigotzky Subject: Re: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE In-Reply-To: References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> Date: Sat, 04 Jun 2016 20:16:23 +0530 Message-ID: <871t4dui4g.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Christian Zigotzky writes: > Hi All, > > I compiled the latest git version of kernel 4.7 with all PowerPC=20 > commits. Maybe the latest commit powerpc-4.7-2 solved the boot issues.=20 > Our latest Nemo patch 4.7-1 works without any problems with the latest=20 > git version. instead of using powerpc-4.7-2 can you use the upstream SHA1 commit id ?. I am not sure how to map 4.7-2 to a kernel version. > > I got the following error message: > > arch/powerpc/kernel/pci-common.c: In function=20 > =E2=80=98pci_process_bridge_OF_ranges=E2=80=99: > arch/powerpc/kernel/pci-common.c:732:59: error: =E2=80=98_PAGE_GUARDED=E2= =80=99=20 > undeclared (first use in this function) > range.size, _PAGE_NO_CACHE|_PAGE_GUARDED= ); > ^ > arch/powerpc/kernel/pci-common.c:732:59: note: each undeclared=20 > identifier is reported only once for each function it appears in > make[1]: *** [arch/powerpc/kernel/pci-common.o] Error 1 > make: *** [arch/powerpc/kernel] Error 2 Which kernel is that ? For upstream I have at that line 729 hose->pci_io_size =3D range.pci_addr + range.s= ize; 730 hose->io_base_phys =3D range.cpu_addr - range.= pci_addr; 731=20 732 /* Build resource */ 733 res =3D &hose->io_resource; 734 range.cpu_addr =3D range.pci_addr; 735 break; 736 case IORESOURCE_MEM: -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rMPbk6pH8zDq8B for ; Sun, 5 Jun 2016 01:13:06 +1000 (AEST) Subject: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <874m99uibc.fsf@skywalker.in.ibm.com> From: Christian Zigotzky Message-ID: Date: Sat, 4 Jun 2016 17:07:02 +0200 MIME-Version: 1.0 In-Reply-To: <874m99uibc.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Aneesh, Shall I bisect the kernel from the powerpc git? git clone https://kernel.googlesource.com/pub/scm/linux/kernel/git/powerpc/linux https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/log/ Shall I start with the following commit? https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?id=8ffb4103f5e28d7e7890ed4774d8e009f253f56e Thanks, Christian On 04 June 2016 at 4:42 PM, Aneesh Kumar K.V wrote: > > Are you looking for changes too kernel that will add ISA 3.0 MMU model > without making changes to other part of kernel ?. I don't think we ever > had a kernel patch which did the ISA 3.0 work like that. In order to add > the new ISA support we did have to make changes to other part of the > kernel. > > To debug your boot issue, I still haven't understood why the suggested > changes are not working. Because for a non cache guarded page the > mapping didn't change at all. Hence I was asking for what the expected > WIMG values are for your board. > > One other option is to bisect test the kernel and if you can isolate > which patch is breaking the boot, we can possibly understand it better. > ie, instead of reverting the entire merge, try a git bisect. > > -aneesh > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rMPct11q0zDqHF for ; Sun, 5 Jun 2016 01:14:05 +1000 (AEST) Subject: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <871t4dui4g.fsf@skywalker.in.ibm.com> From: Christian Zigotzky Message-ID: <2bf8f412-2631-75b4-70a3-cb5ecee5cf48@xenosoft.de> Date: Sat, 4 Jun 2016 17:13:53 +0200 MIME-Version: 1.0 In-Reply-To: <871t4dui4g.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Aneesh, It's from the Nemo patch. I patch the kernel 4.7 with our Nemo patch. [1] Cheers, Christian [1] http://www.xenosoft.de/nemo_4.7-1.patch On 04 June 2016 at 4:46 PM, Aneesh Kumar K.V wrote: > > Which kernel is that ? For upstream I have at that line > > 729 hose->pci_io_size = range.pci_addr + range.size; > 730 hose->io_base_phys = range.cpu_addr - range.pci_addr; > 731 > 732 /* Build resource */ > 733 res = &hose->io_resource; > 734 range.cpu_addr = range.pci_addr; > 735 break; > 736 case IORESOURCE_MEM: > > > -aneesh > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rMQ0w6GdczDq8G for ; Sun, 5 Jun 2016 01:31:28 +1000 (AEST) From: Christian Zigotzky Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE Message-Id: <2FB13B5B-42F0-4396-AD29-70924D2710CC@xenosoft.de> Date: Sat, 4 Jun 2016 17:25:07 +0200 References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <871t4dui4g.fsf@skywalker.in.ibm.com> <2bf8f412-2631-75b4-70a3-cb5ecee5cf48@xenosoft.de> In-Reply-To: <2bf8f412-2631-75b4-70a3-cb5ecee5cf48@xenosoft.de> To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox , rtd@a-eon.com, rtd2@xtra.co.nz, pjwall@mac.com, pjwall@me.com, matthew@a-eon.biz, intermediadc@hotmail.com, contact@a-eon.com, info@xenosoft.de List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Which files are responsible for the early boot phase in the commit powerpc-4= .7-1? Perhaps the problem is there. - Christian Sent from my iPhone > On 04 Jun 2016, at 17:13, Christian Zigotzky wrot= e: >=20 > Aneesh, >=20 > It's from the Nemo patch. I patch the kernel 4.7 with our Nemo patch. [1] >=20 > Cheers, >=20 > Christian >=20 > [1] http://www.xenosoft.de/nemo_4.7-1.patch >=20 >> On 04 June 2016 at 4:46 PM, Aneesh Kumar K.V wrote: >>=20 >> Which kernel is that ? For upstream I have at that line >>=20 >> 729 hose->pci_io_size =3D range.pci_addr + range= .size; >> 730 hose->io_base_phys =3D range.cpu_addr - rang= e.pci_addr; >> 731 >> 732 /* Build resource */ >> 733 res =3D &hose->io_resource; >> 734 range.cpu_addr =3D range.pci_addr; >> 735 break; >> 736 case IORESOURCE_MEM: >>=20 >>=20 >> -aneesh >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rN2pM2ZFtzDq7v for ; Mon, 6 Jun 2016 02:09:28 +1000 (AEST) Subject: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE To: "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox , rtd@a-eon.com, rtd2@xtra.co.nz, pjwall@mac.com, pjwall@me.com, matthew@a-eon.biz, intermediadc@hotmail.com, contact@a-eon.com, info@xenosoft.de References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <871t4dui4g.fsf@skywalker.in.ibm.com> <2bf8f412-2631-75b4-70a3-cb5ecee5cf48@xenosoft.de> <2FB13B5B-42F0-4396-AD29-70924D2710CC@xenosoft.de> From: Christian Zigotzky Message-ID: <053dd416-a9ab-5b06-5c3b-1acefb53fd3b@xenosoft.de> Date: Sun, 5 Jun 2016 18:09:05 +0200 MIME-Version: 1.0 In-Reply-To: <2FB13B5B-42F0-4396-AD29-70924D2710CC@xenosoft.de> Content-Type: text/plain; charset=windows-1252; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , All, I need an answer because I think Darren's guess is correct. It isn't a problem in the pci code. I replaced the file head_64.S that Darren mentioned with the one from the kernel 4.6 and it compiled but unfortunately it doesn't boot. We know "head_64.S" is one file for the early boot phase but I think there are some other files. I am not a fan of reverting the PowerPC commits but there are some other new things in the new kernel e.g. DRM 2.45.0 which are very interesting for the Nemo board. @Julian What about the issues with the Sam460ex? Have you solved the problem with the commit powerpc-4.7-1? Cheers, Christian On 04 June 2016 at 5:25 PM, Christian Zigotzky wrote: > Which files are responsible for the early boot phase in the commit powerpc-4.7-1? Perhaps the problem is there. > > - Christian > > Sent from my iPhone > On 28 May 2016 at 8:51 PM, Darren Stevens wrote: > Hello Adrian > > On 28/05/2016, Adrian Cox wrote: >>> From: Christian Zigotzky [mailto:chzigotzky@xenosoft.de] >>> Sent: 28 May 2016 07:06 >>> Adrian, what is the expected WIMG bit mapping for the Nemo board? >>> >> I'm not able to help much here, I'm afraid. I don't have a Nemo board at >> the moment, and it's been a few years. From memory all the peripherals >> required standard uncached and guarded mappings on Nemo. > Before everybody gets too involved, from what I've seen with my tests today > the kernel is crashing long before it gets to the pci-common code. > > I've attached 2 boot logs, one from a 4.4 kernel I've been working on, and > from a build of the latest git. > > You can see from this that the 4.7 kernel hangs right after the booting linux > via __start(), whereas in the 4.4 there's about 29 lines of output before it > gets to the Initialised io_base_virt printk in our patch. > > The last time we had a hang this early in the boot it turned out to be a > problem in head_64.S, I think there is something else wrong in the commit > Christian has identified > > I will see if this is something I can fix, but it may need better low level > knowledge of PPC hardware than I have. > > Regards > Darren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rNGNw6zJ0zDqFF for ; Mon, 6 Jun 2016 10:51:44 +1000 (AEST) Message-ID: <1465174304.12265.0.camel@ellerman.id.au> Subject: Re: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE From: Michael Ellerman To: Christian Zigotzky , "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox Date: Mon, 06 Jun 2016 10:51:44 +1000 In-Reply-To: References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <874m99uibc.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2016-06-04 at 17:07 +0200, Christian Zigotzky wrote: > Aneesh, > > Shall I bisect the kernel from the powerpc git? No just use linus' tree. > Shall I start with the following commit? > > https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?id=8ffb4103f5e28d7e7890ed4774d8e009f253f56e Yeah that would be a good one to start with. Then mark rc1 as bad and bisect should do the rest. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rNGSK0KDGzDqFF for ; Mon, 6 Jun 2016 10:54:41 +1000 (AEST) Message-ID: <1465174480.12265.2.camel@ellerman.id.au> Subject: Re: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE From: Michael Ellerman To: "Aneesh Kumar K.V" , Christian Zigotzky , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox , "R.T.Dickinson" , "R.T.Dickinson" , Pat Wall , Pat Wall , "contact@a-eon.com" , Matthew Leaman , luigi burdo , Christian Zigotzky Date: Mon, 06 Jun 2016 10:54:40 +1000 In-Reply-To: <871t4dui4g.fsf@skywalker.in.ibm.com> References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <871t4dui4g.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2016-06-04 at 20:16 +0530, Aneesh Kumar K.V wrote: > Christian Zigotzky writes: > > > Hi All, > > > > I compiled the latest git version of kernel 4.7 with all PowerPC > > commits. Maybe the latest commit powerpc-4.7-2 solved the boot issues. > > Our latest Nemo patch 4.7-1 works without any problems with the latest > > git version. > > > instead of using powerpc-4.7-2 can you use the upstream SHA1 commit id > ?. I am not sure how to map 4.7-2 to a kernel version. That's my tag: https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/tag/?h=powerpc-4.7-2 > > I got the following error message: > > > > arch/powerpc/kernel/pci-common.c: In function > > ‘pci_process_bridge_OF_ranges’: > > arch/powerpc/kernel/pci-common.c:732:59: error: ‘_PAGE_GUARDED’ > > undeclared (first use in this function) > > range.size, _PAGE_NO_CACHE|_PAGE_GUARDED); > > ^ > > arch/powerpc/kernel/pci-common.c:732:59: note: each undeclared > > identifier is reported only once for each function it appears in > > make[1]: *** [arch/powerpc/kernel/pci-common.o] Error 1 > > make: *** [arch/powerpc/kernel] Error 2 > > Which kernel is that ? For upstream I have at that line > > 729 hose->pci_io_size = range.pci_addr + range.size; > 730 hose->io_base_phys = range.cpu_addr - range.pci_addr; > 731 > 732 /* Build resource */ > 733 res = &hose->io_resource; > 734 range.cpu_addr = range.pci_addr; > 735 break; > 736 case IORESOURCE_MEM: Christian is running an out-of-tree patch for the nemo board. He did post it to the list at some point. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rNGX73XGMzDq5g for ; Mon, 6 Jun 2016 10:57:59 +1000 (AEST) Message-ID: <1465174679.12265.4.camel@ellerman.id.au> Subject: Re: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE From: Michael Ellerman To: Christian Zigotzky , "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Julian Margetson , Adrian Cox , rtd@a-eon.com, rtd2@xtra.co.nz, pjwall@mac.com, pjwall@me.com, matthew@a-eon.biz, intermediadc@hotmail.com, contact@a-eon.com, info@xenosoft.de Date: Mon, 06 Jun 2016 10:57:59 +1000 In-Reply-To: <053dd416-a9ab-5b06-5c3b-1acefb53fd3b@xenosoft.de> References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <871t4dui4g.fsf@skywalker.in.ibm.com> <2bf8f412-2631-75b4-70a3-cb5ecee5cf48@xenosoft.de> <2FB13B5B-42F0-4396-AD29-70924D2710CC@xenosoft.de> <053dd416-a9ab-5b06-5c3b-1acefb53fd3b@xenosoft.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2016-06-05 at 18:09 +0200, Christian Zigotzky wrote: > All, > > I need an answer because I think Darren's guess is correct. It isn't a > problem in the pci code. I replaced the file head_64.S that Darren > mentioned with the one from the kernel 4.6 and it compiled but > unfortunately it doesn't boot. We know "head_64.S" is one file for the > early boot phase but I think there are some other files. There's lots of files used in the early boot, you can't revert individual files and expect it to work. > On 28 May 2016 at 8:51 PM, Darren Stevens wrote: > > You can see from this that the 4.7 kernel hangs right after the booting linux > > via __start(), whereas in the 4.4 there's about 29 lines of output before it > > gets to the Initialised io_base_virt printk in our patch. If the last thing you see is "booting linux via __start()" that means the kernel crashed early, before it could detect and initialise the console. Do you have a serial or other console in that machine at a known location? If so you can hard-code the kernel to use that console, which means you can get messages earlier in boot. See udbg_early_init() for starters. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp618.redcondor.net (smtp618.redcondor.net [208.80.206.18]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rNH7K2zkVzDq60 for ; Mon, 6 Jun 2016 11:25:00 +1000 (AEST) Subject: Re: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE To: Michael Ellerman , Christian Zigotzky , "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Adrian Cox , rtd@a-eon.com, rtd2@xtra.co.nz, pjwall@mac.com, pjwall@me.com, matthew@a-eon.biz, intermediadc@hotmail.com, contact@a-eon.com, info@xenosoft.de References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <871t4dui4g.fsf@skywalker.in.ibm.com> <2bf8f412-2631-75b4-70a3-cb5ecee5cf48@xenosoft.de> <2FB13B5B-42F0-4396-AD29-70924D2710CC@xenosoft.de> <053dd416-a9ab-5b06-5c3b-1acefb53fd3b@xenosoft.de> <1465174679.12265.4.camel@ellerman.id.au> From: Julian Margetson Message-ID: <5fb9d8e9-d456-0537-ef77-82658e4538cd@candw.ms> Date: Sun, 5 Jun 2016 21:23:49 -0400 MIME-Version: 1.0 In-Reply-To: <1465174679.12265.4.camel@ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 6/5/2016 8:57 PM, Michael Ellerman wrote: > On Sun, 2016-06-05 at 18:09 +0200, Christian Zigotzky wrote: > >> All, >> >> I need an answer because I think Darren's guess is correct. It isn't a >> problem in the pci code. I replaced the file head_64.S that Darren >> mentioned with the one from the kernel 4.6 and it compiled but >> unfortunately it doesn't boot. We know "head_64.S" is one file for the >> early boot phase but I think there are some other files. > There's lots of files used in the early boot, you can't revert individual files > and expect it to work. > >> On 28 May 2016 at 8:51 PM, Darren Stevens wrote: >>> You can see from this that the 4.7 kernel hangs right after the booting linux >>> via __start(), whereas in the 4.4 there's about 29 lines of output before it >>> gets to the Initialised io_base_virt printk in our patch. > If the last thing you see is "booting linux via __start()" that means the kernel > crashed early, before it could detect and initialise the console. > > Do you have a serial or other console in that machine at a known location? If so > you can hard-code the kernel to use that console, which means you can get > messages earlier in boot. See udbg_early_init() for starters. > > cheers > > > > Julian Margetson writes: > >> Hi Christian, >> >> I am also having a problem with _PAGE_NO_CACHE on Sam460ex. >> >> Regards >> Julian >> >> ï»¿drivers/gpu/drm/drm_vm.c: In function â€˜drm_dma_protâ€™: >> drivers/gpu/drm/drm_vm.c:83:6: error: invalid operands to binary | >> (have â€˜pgprot_t {aka struct }â€™ and â€˜intâ€™) >> tmp |= _PAGE_NO_CACHE; >> ^ >> scripts/Makefile.build:289: recipe for target >> 'drivers/gpu/drm/drm_vm.o' failed >> make[3]: *** [drivers/gpu/drm/drm_vm.o] Error 1 >> scripts/Makefile.build:440: recipe for target 'drivers/gpu/drm' failed >> make[2]: *** [drivers/gpu/drm] Error 2 >> scripts/Makefile.build:440: recipe for target 'drivers/gpu' failed >> make[1]: *** [drivers/gpu] Error 2 >> Makefile:985: recipe for target 'drivers' failed >> make: *** [drivers] Error 2 >> >> > That is because that usage is wrong based on type. _PAGE_NO_CACHE is not > of type pgprot_t. What you really need there is > > tmp = __pgprot(pgprot_val(tmp) | _PAGE_NO_CACHE); > > or a better option would be > > tmp = pgprot_noncached_wc(tmp); > > -aneesh > > @Julian > > What about the issues with the Sam460ex? Have you solved the problem > with the commit powerpc-4.7-1? > > Cheers, > > Christian > > On 04 June 2016 at 5:25 PM, Christian Zigotzky wrote: > tmp = pgprot_noncached_wc(tmp); compiles but I then run in to the following CC drivers/gpu/drm/drm_scatter.o drivers/gpu/drm/drm_scatter.c: In function â€˜drm_vmalloc_dmaâ€™: drivers/gpu/drm/drm_scatter.c:44:49: error: invalid operands to binary | (have â€˜pgprot_t {aka struct }â€™ and â€˜intâ€™) return __vmalloc(size, GFP_KERNEL, PAGE_KERNEL | _PAGE_NO_CACHE); ^ drivers/gpu/drm/drm_scatter.c:48:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/drm_scatter.o' failed make[3]: *** [drivers/gpu/drm/drm_scatter.o] Error 1 scripts/Makefile.build:440: recipe for target 'drivers/gpu/drm' failed make[2]: *** [drivers/gpu/drm] Error 2 scripts/Makefile.build:440: recipe for target 'drivers/gpu' failed make[1]: *** [drivers/gpu] Error 2 Makefile:985: recipe for target 'drivers' failed make: *** [drivers] Error 2 Regards Julian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rNHvp6VCgzDq9H for ; Mon, 6 Jun 2016 12:00:06 +1000 (AEST) Message-ID: <1465178406.12265.6.camel@ellerman.id.au> Subject: Re: Kernel 4.7: PAGE_GUARDED and _PAGE_NO_CACHE From: Michael Ellerman To: Julian Margetson , Christian Zigotzky , "Aneesh Kumar K.V" , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, darren@stevens-zone.net, Michael Ellerman , Adrian Cox , rtd@a-eon.com, rtd2@xtra.co.nz, pjwall@mac.com, pjwall@me.com, matthew@a-eon.biz, intermediadc@hotmail.com, contact@a-eon.com, info@xenosoft.de Date: Mon, 06 Jun 2016 12:00:06 +1000 In-Reply-To: <5fb9d8e9-d456-0537-ef77-82658e4538cd@candw.ms> References: <8B4C4AB7-5C17-4992-935A-361153472793@xenosoft.de> <1463990507.3078.16.camel@kernel.crashing.org> <1464088614.3078.79.camel@kernel.crashing.org> <1298e1f6-beb7-5487-72a1-366ebd140c17@xenosoft.de> <87d1obqxg9.fsf@skywalker.in.ibm.com> <9690f9a4-70c7-8acc-42d0-779bcc93db52@xenosoft.de> <66397458-c40a-4e83-c5e5-0ba69fb48986@xenosoft.de> <871t4dui4g.fsf@skywalker.in.ibm.com> <2bf8f412-2631-75b4-70a3-cb5ecee5cf48@xenosoft.de> <2FB13B5B-42F0-4396-AD29-70924D2710CC@xenosoft.de> <053dd416-a9ab-5b06-5c3b-1acefb53fd3b@xenosoft.de> <1465174679.12265.4.camel@ellerman.id.au> <5fb9d8e9-d456-0537-ef77-82658e4538cd@candw.ms> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: