From: Christian Borntraeger <borntraeger@de•ibm.com>
To: Suraj Jitindar Singh <sjitindarsingh@gmail•com>,
linuxppc-dev@lists•ozlabs.org
Cc: pbonzini@redhat•com, rkrcmar@redhat•com,
christoffer.dall@linaro•org, marc.zyngier@arm•com,
james.hogan@imgtec•com, agraf@suse•com, benh@kernel•crashing.org,
paulus@samba•org, mpe@ellerman•id.au, cornelia.huck@de•ibm.com,
kvm@vger•kernel.org, kvm-ppc@vger•kernel.org,
kvmarm@lists•cs.columbia.edu, linux-mips@linux-mips•org,
linux-s390@vger•kernel.org
Subject: Re: [PATCH V3 4/5] kvm/stats: Add provisioning for 64-bit vm and vcpu statistics
Date: Wed, 13 Jul 2016 11:04:08 +0200 [thread overview]
Message-ID: <57860408.1000203@de.ibm.com> (raw)
In-Reply-To: <1468400015-4834-1-git-send-email-sjitindarsingh@gmail.com>
On 07/13/2016 10:53 AM, Suraj Jitindar Singh wrote:
> vms and vcpus have statistics associated with them which can be viewed
> within the debugfs. Currently it is assumed within the vcpu_stat_get() and
> vm_stat_get() functions that all of these statistics are represented as
> u32s, however the next patch adds some u64 statistics.
>
> Thus modify these two functions, vcpu_stat_get() and vm_stat_get(), such
> that they expect u64 statistics and update vm and vcpu statistics to u64s
> accordingly.
>
> ---
> Change Log:
>
> V1 -> V2:
> - Nothing
> V2 -> V3:
> - Instead of implementing separate u32 and u64 functions keep the
> generic functions and modify them to expect u64s. Thus update all
> vm and vcpu statistics to u64s accordingly.
Have not looked into everything, but I agree with changing everything to 64bit.
> @@ -3583,8 +3583,8 @@ static const struct file_operations vcpu_stat_get_per_vm_fops = {
> };
>
> static const struct file_operations *stat_fops_per_vm[] = {
> - [KVM_STAT_VCPU] = &vcpu_stat_get_per_vm_fops,
> - [KVM_STAT_VM] = &vm_stat_get_per_vm_fops,
> + [KVM_STAT_VCPU] = &vcpu_stat_get_per_vm_fops,
> + [KVM_STAT_VM] = &vm_stat_get_per_vm_fops,
> };
unrelated white space changes?
>
> static int vm_stat_get(void *_offset, u64 *val)
> @@ -3628,8 +3628,8 @@ static int vcpu_stat_get(void *_offset, u64 *val)
> DEFINE_SIMPLE_ATTRIBUTE(vcpu_stat_fops, vcpu_stat_get, NULL, "%llu\n");
>
> static const struct file_operations *stat_fops[] = {
> - [KVM_STAT_VCPU] = &vcpu_stat_fops,
> - [KVM_STAT_VM] = &vm_stat_fops,
> + [KVM_STAT_VCPU] = &vcpu_stat_fops,
> + [KVM_STAT_VM] = &vm_stat_fops,
> };
>
> static int kvm_init_debug(void)
>
next prev parent reply other threads:[~2016-07-13 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 8:53 [PATCH V3 4/5] kvm/stats: Add provisioning for 64-bit vm and vcpu statistics Suraj Jitindar Singh
2016-07-13 9:04 ` Christian Borntraeger [this message]
2016-07-15 7:49 ` Suraj Jitindar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57860408.1000203@de.ibm.com \
--to=borntraeger@de$(echo .)ibm.com \
--cc=agraf@suse$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=christoffer.dall@linaro$(echo .)org \
--cc=cornelia.huck@de$(echo .)ibm.com \
--cc=james.hogan@imgtec$(echo .)com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)cs.columbia.edu \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=marc.zyngier@arm$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=rkrcmar@redhat$(echo .)com \
--cc=sjitindarsingh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox