From: Kumar Gala <kumar.gala@freescale•com>
To: "Mark A. Greer" <mgreer@mvista•com>
Cc: linuxppc-embedded@ozlabs•org, Kumar Gala <galak@somerset•sps.mot.com>
Subject: Re: RFC: [PATCH] platform device driver model support
Date: Wed, 12 Jan 2005 22:19:39 -0600 [thread overview]
Message-ID: <579DFDF6-651A-11D9-92A0-000393DBC2E8@freescale.com> (raw)
In-Reply-To: <41E5B318.3060304@mvista.com>
> My $0.02.
>
> I didn't go thru in complete detail but I like the idea.=A0 I have a
> couple minor comments, though.
>
> 1) Can we pick something other than 'soc' since the Marvell bridges
> really aren't SOCs?=A0 I don't really know what is better but just to
> throw something out, how about haing them all look like ppc_pd_xxx()?
What about ppc_plat_xxx() or ppc_sys_xxx() [for system]? 'sys' maybe=20
more consistent with our naming conventions in that arch/ppc/platforms=20=
is more board focused, and arch/ppc/syslib is bridge and non-core chip=20=
functionality.
> 2) In 8540_ads.c you're digging out platform_device entries and
> modifying them in your mpc8540ads_setup_arch() routine.=A0 I think the
> platform_device "way" of doing that would be to make your mods via the
> platform_notify() hook (eventually called by device_add() which was
> ultimately called from platform_add_devices()).
This is problematic for some things like the updating of the IOMEM=20
resources since that needs to occur before platform_device_register is=20=
called. However, the updates in mpc8540_ads.c could possibly handled=20
by platform_notify(), will look into that.
- kumar=
next prev parent reply other threads:[~2005-01-13 4:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 7:43 RFC: [PATCH] platform device driver model support Kumar Gala
2005-01-12 8:36 ` Eugene Surovegin
2005-01-12 14:41 ` Kumar Gala
2005-01-12 21:14 ` Matt Porter
2005-01-12 21:28 ` Matt Porter
2005-01-14 19:13 ` Andrew May
2005-01-14 19:14 ` Kumar Gala
2005-01-12 23:30 ` Mark A. Greer
2005-01-13 4:19 ` Kumar Gala [this message]
2005-01-13 17:34 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579DFDF6-651A-11D9-92A0-000393DBC2E8@freescale.com \
--to=kumar.gala@freescale$(echo .)com \
--cc=galak@somerset$(echo .)sps.mot.com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=mgreer@mvista$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox