From: Ravi Bangoria <ravi.bangoria@linux•vnet.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>
Cc: chris@distroguy•com, aneesh.kumar@linux•vnet.ibm.com,
ast@kernel•org, linux-kernel@vger•kernel.org, oss@buserror•net,
paul.gortmaker@windriver•com, duwe@lst•de,
Anton Blanchard <anton@samba•org>,
lsorense@csclub•uwaterloo.ca, bauerman@linux•vnet.ibm.com,
oohall@gmail•com, naveen.n.rao@linux•vnet.ibm.com,
linuxppc-dev@lists•ozlabs.org, paulus@samba•org,
viro@zeniv•linux.org.uk,
Ravi Bangoria <ravi.bangoria@linux•vnet.ibm.com>
Subject: Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE
Date: Fri, 4 Nov 2016 11:01:30 +0530 [thread overview]
Message-ID: <581C1D32.50108@linux.vnet.ibm.com> (raw)
In-Reply-To: <e993dc5c-7a90-e43b-b761-a70a79b3d1d9@au1.ibm.com>
On Friday 04 November 2016 07:37 AM, Andrew Donnellan wrote:
> On 03/11/16 21:27, Ravi Bangoria wrote:
>> Yes, kernel-space hw-breakpoint feature is broken on LE without this.
>
> Is there any actual user-visible feature that depends on this, or is this solely for debugging and development purposes?
>
> It would of course be *nice* to have it in stable trees (particularly so we pick it up in distros) but I'm not convinced that enabling HW breakpoints on a platform where it has *never* worked qualifies as an "actual bug".
>
> (BTW many thanks for fixing this - I had a shot at it late last year but never quite got there!)
Thanks Andrew,
kprobe, uprobe, hw-breakpoint and xmon are the only user of emulate_step.
Kprobe / uprobe single-steps instruction if they can't emulate it, so there
is no problem with them. As I mention, hw-breakpoint is broken. However
I'm not sure about xmon, I need to check that.
So yes, there is no user-visible feature that depends on this.
-Ravi
next prev parent reply other threads:[~2016-11-04 5:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 8:53 [PATCH 0/3] powerpc: Emulation support for load/store instructions on LE Ravi Bangoria
2016-11-02 8:53 ` [PATCH 1/3] " Ravi Bangoria
2016-11-02 21:04 ` Anton Blanchard
2016-11-03 5:41 ` Ravi Bangoria
2016-11-03 9:48 ` Michael Ellerman
2016-11-03 10:27 ` Ravi Bangoria
2016-11-04 2:07 ` Andrew Donnellan
2016-11-04 5:31 ` Ravi Bangoria [this message]
2016-11-05 19:31 ` Anton Blanchard
2016-11-06 18:59 ` Ravi Bangoria
2016-11-02 8:53 ` [PATCH 2/3] powerpc: Add encoding for couple of load/store instructions Ravi Bangoria
2016-11-02 8:53 ` [PATCH 3/3] powerpc: emulate_step test for " Ravi Bangoria
2016-11-02 10:30 ` Naveen N. Rao
2016-11-03 7:03 ` [PATCH 0/3] powerpc: Emulation support for load/store instructions on LE Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581C1D32.50108@linux.vnet.ibm.com \
--to=ravi.bangoria@linux$(echo .)vnet.ibm.com \
--cc=andrew.donnellan@au1$(echo .)ibm.com \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=anton@samba$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bauerman@linux$(echo .)vnet.ibm.com \
--cc=chris@distroguy$(echo .)com \
--cc=duwe@lst$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lsorense@csclub$(echo .)uwaterloo.ca \
--cc=mpe@ellerman$(echo .)id.au \
--cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=oohall@gmail$(echo .)com \
--cc=oss@buserror$(echo .)net \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox