From: Chanwoo Choi <cw00.choi@samsung•com>
To: Viresh Kumar <viresh.kumar@linaro•org>,
Rafael Wysocki <rjw@rjwysocki•net>, Kukjin Kim <kgene@kernel•org>,
Krzysztof Kozlowski <krzk@kernel•org>,
Javier Martinez Canillas <javier@osg•samsung.com>,
Jason Cooper <jason@lakedaemon•net>, Andrew Lunn <andrew@lunn•ch>,
Gregory Clement <gregory.clement@free-electrons•com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>,
Simon Horman <horms@verge•net.au>,
Magnus Damm <magnus.damm@gmail•com>
Cc: linaro-kernel@lists•linaro.org, linux-pm@vger•kernel.org,
linux-kernel@vger•kernel.org,
Vincent Guittot <vincent.guittot@linaro•org>,
arnd.bergmann@linaro•org, linux-arm-kernel@lists•infradead.org,
linux-samsung-soc@vger•kernel.org,
linux-renesas-soc@vger•kernel.org, linux-mips@linux-mips•org,
linuxppc-dev@lists•ozlabs.org, linux-sh@vger•kernel.org
Subject: Re: [PATCH] cpufreq: Remove CONFIG_CPU_FREQ_STAT_DETAILS config option
Date: Thu, 05 Jan 2017 19:12:29 +0900 [thread overview]
Message-ID: <586E1C0D.20102@samsung.com> (raw)
In-Reply-To: <d4299228a500a889c2b4b9e305674f3d1ea9ae06.1483604760.git.viresh.kumar@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
Hi Viresh,
On 2017년 01월 05일 17:27, Viresh Kumar wrote:
> This doesn't have any benefit apart from saving a small amount of memory
> when it is disabled. The ifdef hackery in the code makes it dirty
> unnecessarily.
>
> Clean it up by removing the Kconfig option completely. Few defconfigs
> are also updated and CONFIG_CPU_FREQ_STAT_DETAILS is replaced with
> CONFIG_CPU_FREQ_STAT now in them, as users wanted stats to be enabled.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro•org>
> ---
> arch/arm/configs/exynos_defconfig | 2 +-
> arch/arm/configs/multi_v5_defconfig | 2 +-
> arch/arm/configs/multi_v7_defconfig | 2 +-
> arch/arm/configs/mvebu_v5_defconfig | 2 +-
> arch/arm/configs/pxa_defconfig | 2 +-
> arch/arm/configs/shmobile_defconfig | 2 +-
> arch/mips/configs/lemote2f_defconfig | 1 -
> arch/powerpc/configs/ppc6xx_defconfig | 1 -
> arch/sh/configs/sh7785lcr_32bit_defconfig | 2 +-
> drivers/cpufreq/Kconfig | 8 --------
> drivers/cpufreq/cpufreq_stats.c | 14 --------------
> 11 files changed, 7 insertions(+), 31 deletions(-)
I agree. Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung•com>
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
[-- Attachment #2: cw00_choi.vcf --]
[-- Type: text/x-vcard, Size: 6 bytes --]
null
next prev parent reply other threads:[~2017-01-05 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170105082939epcas4p4b494945ce55c949dc7a030ebf9dbdd4c@epcas4p4.samsung.com>
2017-01-05 8:27 ` [PATCH] cpufreq: Remove CONFIG_CPU_FREQ_STAT_DETAILS config option Viresh Kumar
2017-01-05 9:50 ` Gregory CLEMENT
2017-01-05 10:12 ` Chanwoo Choi [this message]
2017-01-05 18:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586E1C0D.20102@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd.bergmann@linaro$(echo .)org \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=horms@verge$(echo .)net.au \
--cc=jason@lakedaemon$(echo .)net \
--cc=javier@osg$(echo .)samsung.com \
--cc=kgene@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linaro-kernel@lists$(echo .)linaro.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=magnus.damm@gmail$(echo .)com \
--cc=rjw@rjwysocki$(echo .)net \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=viresh.kumar@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox