From: Ravi Bangoria <ravi.bangoria@linux•vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail•com>
Cc: mpe@ellerman•id.au, benh@kernel•crashing.org, paulus@samba•org,
npiggin@gmail•com, aneesh.kumar@linux•vnet.ibm.com,
chris@distroguy•com, viro@zeniv•linux.org.uk,
christophe.leroy@c-s•fr, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org, anton@samba•org,
naveen.n.rao@linux•vnet.ibm.com,
Ravi Bangoria <ravi.bangoria@linux•vnet.ibm.com>,
"ananth@in•ibm.com" <ananth@in•ibm.com>
Subject: Re: [PATCH v2] ppc64/kprobe: Fix oops when kprobed on 'stdu' instruction
Date: Tue, 11 Apr 2017 16:22:18 +0530 [thread overview]
Message-ID: <58ECB562.8070903@linux.vnet.ibm.com> (raw)
In-Reply-To: <1491900956.8380.5.camel@gmail.com>
Thanks Balbir for the review,
On Tuesday 11 April 2017 02:25 PM, Balbir Singh wrote:
> On Tue, 2017-04-11 at 10:38 +0530, Ravi Bangoria wrote:
>> If we set a kprobe on a 'stdu' instruction on powerpc64, we see a kernel
>> OOPS:
>>
>> [ 1275.165932] Bad kernel stack pointer cd93c840 at c000000000009868
>> [ 1275.166378] Oops: Bad kernel stack pointer, sig: 6 [#1]
>> ...
>> GPR00: c000001fcd93cb30 00000000cd93c840 c0000000015c5e00 00000000cd93c840
>> ...
>> [ 1275.178305] NIP [c000000000009868] resume_kernel+0x2c/0x58
>> [ 1275.178594] LR [c000000000006208] program_check_common+0x108/0x180
>>
>> Basically, on 64 bit system, when user probes on 'stdu' instruction,
>> kernel does not emulate actual store in emulate_step itself because it
>> may corrupt exception frame. So kernel does actual store operation in
>> exception return code i.e. resume_kernel().
>>
>> resume_kernel() loads the saved stack pointer from memory using lwz,
>> effectively loading a corrupt (32bit) address, causing the kernel crash.
>>
>> Fix this by loading the 64bit value instead.
>>
>> Fixes: be96f63375a1 ("powerpc: Split out instruction analysis part of emulate_step()")
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux•vnet.ibm.com>
>> Reviewed-by: Naveen N. Rao <naveen.n.rao@linux•vnet.ibm.com>
>> ---
> The patch looks correct to me from the description and code. I have not
> validated that the write to GPR1(r1) via store of r8 to 0(r5) is indeed correct.
> I would assume r8 should contain regs->gpr[r1] with the updated ea that
> is written down to the GPR1(r1) which will be what we restore when we return
> from the exception.
emulate_step() updates regs->gpr[r1] with the new value. So,
regs->gpr[r1] and GPR(r1) both are same at resume_kernel.
At resume_kernel, r1 points to the exception frame. Address
of frame preceding exception frame gets loaded in r8 with:
addi r8,r1,INT_FRAME_SIZE
Let me know if you need more details.
Ravi
next prev parent reply other threads:[~2017-04-11 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 5:08 [PATCH v2] ppc64/kprobe: Fix oops when kprobed on 'stdu' instruction Ravi Bangoria
2017-04-11 6:01 ` Ananth N Mavinakayanahalli
2017-04-11 8:55 ` Balbir Singh
2017-04-11 10:52 ` Ravi Bangoria [this message]
2017-04-18 11:51 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ECB562.8070903@linux.vnet.ibm.com \
--to=ravi.bangoria@linux$(echo .)vnet.ibm.com \
--cc=ananth@in$(echo .)ibm.com \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=anton@samba$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bsingharora@gmail$(echo .)com \
--cc=chris@distroguy$(echo .)com \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox