Subject: Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support

From: Segher Boessenkool <[email-masked]>
Date: Thu, 3 May 2007 17:43:38 +0200

>> +               pcmcia@0080 {

>> +                       compatible = "8xx";

> The compatible property should be a little more specific, imho. Since 
> there
> are differences in how things are done depending on the board, it 
> would be
> good to tell the exact method from the pcmcia node itself.

Just "8xx" isn't good enough -- at a very minimum it
needs to say this is a PCMCIA controller!

> For example, you could make this
>
> 	compatible = "8xx\0mpc885ads";

"mpc885ads-pcmcia\0mpc8xx-pcmcia" or something like that.

Segher