Subject: Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property

From: Segher Boessenkool <[email-masked]>
Date: Mon, 23 Apr 2007 22:59:43 +0200

> Since ucc_geth is being migrated to use the phylib, the existing
> (undocumented) 'interface' property is being deprecated in favour
> of 'phy-connection-type'.

Okay.

> phy-connection-type is now maintained one-to-one with definitions
> in include/linux/phy.h, albeit in the form of a string.

That's sort-of accidental though :-)

> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -1562,6 +1562,9 @@ platforms are moved over to use the 
> flattened-device-tree model.
>       network device.  This is used by the bootwrapper to interpret
>       MAC addresses passed by the firmware when no information other
>       than indices is available to associate an address with a device.
> +   - phy-connection-type : a string naming the controller/PHY 
> interface type,
> +     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id", 
> "tbi",
> +     or "rtbi".

Could you put this right after the "phy-handle" definition
please?

> @@ -1573,6 +1576,7 @@ platforms are moved over to use the 
> flattened-device-tree model.
>  		interrupts = <a0 0>;
>  		interrupt-parent = <700>;
>  		mac-address = [ 00 04 9f 00 23 23 ];
> +		phy-connection-type = "gmii";
>  		rx-clock = "none";
>  		tx-clock = "clk9";
>  		phy-handle = <212000>;

Same here.  It's nice to keep things grouped, it
improves understanding ;-)

Segher