From: Milton Miller <miltonm@bga•com>
To: Yuri Tikhonov <yur@emcraft•com>
Cc: yanok@emcraft•com, dzu@denx•de, linuxppc-dev@ozlabs•org,
hugh@veritas•com, paulus@samba•org, akpm@linux-foundation•org,
prodyuth@gmail•com, wd@denx•de
Subject: Re: Re[2]: [PATCH][v4] powerpc 44x: support for 256KB PAGE_SIZE
Date: Sat, 17 Jan 2009 20:32:25 -0600 [thread overview]
Message-ID: <6206e2ad09c4ee677275859dc6d5046e@bga.com> (raw)
In-Reply-To: <1336101832.20090116181842@emcraft.com>
On Jan 16, 2009, at 9:18 AM, Yuri Tikhonov wrote:
> On Friday, January 16, 2009 you wrote:
>> On Jan 12, 2009, at 4:49 PM, Yuri Tikhonov wrote:
>
>>> This patch adds support for 256KB pages on ppc44x-based boards.
>
>
>>> +config STDBINUTILS
>>> + bool "Using standard binutils settings"
>>> + depends on 44x
>>> + default y
>
>
>> I think this should be
>
>> config STDBINUTILS
>> bool "Using standard binutils settings" if 44x
>> default y
>
>> that way we imply that all powerpc users are using the standard
>> binutils instead of only those using a 44x platform. We still get the
>> intended effect of asking the user only on 44x.
>
>> I haven't looked at the resulting question or config order to see if
>> it
>> makes sense to leave it here or put it closer to the page size.
>
> I'm not sure about this. For 44x platforms - the STDBINUTILS option
> is reasonable, because it's used in the PAGE_SIZE selection process.
> But as regarding the other powerpcs the STDBINUTILS option will do
> nothing, but taking a superfluous string in configs. Are you sure this
> will be better ?
Ok I tried this out in menuconfig. You are right that the depends on
makes sense as it removes the option from the config file as not
relevant. But right now to enable 256K pages one has to go to platform
setup to find this dependency, then has to go to general setup to find
the shmem option at the bottom of the list in the embedded/expert
section, then finally go to the kernel options menu to finally choose
the page size.
Moving this question just before the page size choice removes one of
those hidden menu, so I suggest that it be moved to just before the
option that it allow be selected.
milton
next prev parent reply other threads:[~2009-01-18 2:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 22:49 [PATCH][v4] powerpc 44x: support for 256KB PAGE_SIZE Yuri Tikhonov
2009-01-16 15:00 ` Milton Miller
2009-01-16 15:18 ` Re[2]: " Yuri Tikhonov
2009-01-18 2:32 ` Milton Miller [this message]
2009-01-18 13:40 ` Josh Boyer
2009-01-29 11:40 ` Re[4]: " Yuri Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6206e2ad09c4ee677275859dc6d5046e@bga.com \
--to=miltonm@bga$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=dzu@denx$(echo .)de \
--cc=hugh@veritas$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=prodyuth@gmail$(echo .)com \
--cc=wd@denx$(echo .)de \
--cc=yanok@emcraft$(echo .)com \
--cc=yur@emcraft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox