From: Michael Neuling <mikey@neuling•org>
To: benh@kernel•crashing.org
Cc: linuxppc-dev@ozlabs•org, kumar.gala@freescale•com
Subject: [PATCH] powerpc: Fix potential compile error irqs_disabled_flags
Date: Thu, 22 Oct 2009 16:58:35 +1100 [thread overview]
Message-ID: <6797.1256191115@neuling.org> (raw)
irqs_disabled_flags is #defined in linux/irqflags.h when
CONFIG_TRACE_IRQFLAGS_SUPPORT is enabled.
This fixes the case when someone needs to include both linux/irqflags.h
and asm/hw_irq.h.
Signed-off-by: Michael Neuling <mikey@neuling•org>
---
I'm not sure if this is the right fix. We could just remove
irqs_disabled_flags but I think that has the possibility of breaking
32bit.
arch/powerpc/include/asm/hw_irq.h | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6-ozlabs/arch/powerpc/include/asm/hw_irq.h
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/include/asm/hw_irq.h
+++ linux-2.6-ozlabs/arch/powerpc/include/asm/hw_irq.h
@@ -64,10 +64,12 @@ extern void iseries_handle_interrupts(vo
get_paca()->hard_enabled = 0; \
} while(0)
+#ifndef CONFIG_TRACE_IRQFLAGS_SUPPORT
static inline int irqs_disabled_flags(unsigned long flags)
{
return flags == 0;
}
+#endif
#else
next reply other threads:[~2009-10-22 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 5:58 Michael Neuling [this message]
2009-10-22 6:03 ` [PATCH] powerpc: Fix potential compile error irqs_disabled_flags Kumar Gala
2009-10-22 6:15 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6797.1256191115@neuling.org \
--to=mikey@neuling$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox