public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel•org>
To: Haren Myneni <haren@linux•ibm.com>, linuxppc-dev@lists•ozlabs.org
Cc: maddy@linux•ibm.com, mpe@ellerman•id.au, npiggin@gmail•com,
	msuchanek@suse•de, mahesh@linux•ibm.com, tyreld@linux•ibm.com,
	hbabu@us•ibm.com
Subject: Re: [PATCH RFC 7/9] powerpc/pseries: Enable HVPIPE event message interrupt
Date: Thu, 3 Jul 2025 09:00:14 +0200	[thread overview]
Message-ID: <6824e14b-8f79-4fee-85f6-e5f78a8ef265@kernel.org> (raw)
In-Reply-To: <20250702221444.879256-8-haren@linux.ibm.com>

On 03/07/2025 00:14, Haren Myneni wrote:
> +static int __init enable_hvpipe_IRQ(void)
> +{
> +	struct device_node *np;
> +
> +	hvpipe_check_exception_token = rtas_function_token(RTAS_FN_CHECK_EXCEPTION);
> +	if (hvpipe_check_exception_token  == RTAS_UNKNOWN_SERVICE)
> +		return -ENODEV;
> +
> +	/* hvpipe events */
> +	np = of_find_node_by_path("/event-sources/ibm,hvpipe-msg-events");

Undocumented ABI, NAK. Plus node names should not be used at all as
ABI... and naming does not follow DT spec/style, not sure if you care
about it, though.


> +	if (np != NULL) {
> +		request_event_sources_irqs(np, hvpipe_event_interrupt,
> +					"HPIPE_EVENT");
> +		of_node_put(np);
> +	} else {
> +		pr_err("Can not enable hvpipe event IRQ\n");


Best regards,
Krzysztof


  reply	other threads:[~2025-07-03  7:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 22:14 [PATCH RFC 0/9] powerpc/pseries: Add hypervisor pipe (HVPIPE) suport Haren Myneni
2025-07-02 22:14 ` [PATCH RFC 1/9] powerpc/pseries: Define papr-hvpipe ioctl Haren Myneni
2025-07-02 22:14 ` [PATCH RFC 2/9] powerpc/pseries: Define HVPIPE specific macros Haren Myneni
2025-07-02 22:14 ` [PATCH RFC 3/9] powerpc/pseries: Add papr-hvpipe char driver for HVPIPE interfaces Haren Myneni
2025-07-03  6:58   ` Krzysztof Kozlowski
2025-07-07  6:53     ` Haren Myneni
2025-07-07  7:29       ` Krzysztof Kozlowski
2025-07-02 22:14 ` [PATCH RFC 4/9] powerpc/pseries: Send payload with ibm,send-hvpipe-msg RTAS Haren Myneni
2025-07-02 22:14 ` [PATCH RFC 5/9] powerpc/pseries: Receive payload with ibm,receive-hvpipe-msg RTAS Haren Myneni
2025-07-02 22:14 ` [PATCH RFC 6/9] powerpc/pseries: Wakeup hvpipe FD when the payload is pending Haren Myneni
2025-07-02 22:14 ` [PATCH RFC 7/9] powerpc/pseries: Enable HVPIPE event message interrupt Haren Myneni
2025-07-03  7:00   ` Krzysztof Kozlowski [this message]
2025-07-07  7:02     ` Haren Myneni
2025-07-07  7:35       ` Krzysztof Kozlowski
2025-07-07  7:43         ` Krzysztof Kozlowski
2025-07-07  9:13           ` Haren Myneni
2025-07-02 22:14 ` [PATCH RFC 8/9] powerpc/pseries: Enable hvpipe with ibm,set-system-parameter RTAS Haren Myneni
2025-07-02 22:14 ` [PATCH RFC 9/9] powerpc/pseries: HVPIPE changes to support migration Haren Myneni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6824e14b-8f79-4fee-85f6-e5f78a8ef265@kernel.org \
    --to=krzk@kernel$(echo .)org \
    --cc=haren@linux$(echo .)ibm.com \
    --cc=hbabu@us$(echo .)ibm.com \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=maddy@linux$(echo .)ibm.com \
    --cc=mahesh@linux$(echo .)ibm.com \
    --cc=mpe@ellerman$(echo .)id.au \
    --cc=msuchanek@suse$(echo .)de \
    --cc=npiggin@gmail$(echo .)com \
    --cc=tyreld@linux$(echo .)ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox