public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel•crashing.org>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: ppcdev list <linuxppc-dev@ozlabs•org>
Subject: Re: [RFC] Device tree for new desktop platform in arch/powerpc
Date: Tue, 19 Jun 2007 08:16:09 +0200	[thread overview]
Message-ID: <69de6646562b9fb3432909afff57a962@kernel.crashing.org> (raw)
In-Reply-To: <20070619054232.GB32039@localhost.localdomain>

>>   	interrupt-controller {
>> 		device_type = "interrupt-controller";
>> 		compatible = "chrp,iic";
>
> Is there a device binding defined somewhere for "chrp,iic"?

In the CHRP platform binding, which doesn't apply here.

>> 		keyboard {
>> 			device_type = "keyboard";
>> 			compatible = "pnpPNP,303";
>> 			reg = <0>;
>> 		};
>
>> 		mouse {
>> 			device_type = "mouse";
>> 			compatible = "pnpPNP,f03";
>> 			reg = <1>;
>> 		};
>> 	};
>
>> 	timer@40 {
>> 		device_type = "timer";
>
> For flat device trees we're generally avoiding setting the device_type
> property unless there is a clearly defined "class binding" which
> applies.  There are a number of cases here where I'm not sure if
> that's true.

Keyboard and mouse have defined "device_type"s.  Timer I
don't think so.

Either way, I'd leave out the device_type here, the OS
isn't supposed to use it anyway.

>> 	serial@3f8 {
>> 		device_type = "serial";
>> /*		compatible = "pnpPNP,501";*/
>> 		compatible = "ns16550";
>> 		reg = <3f8 8>;
>> 		interrupts = <4 3>;			// IRQ4 (rising edge)
>> 		interrupt-parent = <&interrupt-controller>;
>> 		clock-frequency = <0>;			// Not necessary?
>
> Probably necessary, but may need to be filled in from the bootwrapper.

If absent, "clock-frequency" should be taken to be the
default thing.  Actually, for pnpPNP (PC-style) serial,
the clock frequency is fixed.

>>   	pci@80000000 {
>> 		device_type = "pci";
>> 		bus-frequency = <01fca055>;		// 33.3MHz

So write it in decimal...


Segher

  reply	other threads:[~2007-06-19  6:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-18 18:57 [RFC] Device tree for new desktop platform in arch/powerpc Gerhard Pircher
2007-06-18 19:15 ` Mark A. Greer
2007-06-18 19:43   ` Gerhard Pircher
2007-06-18 20:25     ` Mark A. Greer
2007-06-19  5:08       ` David Gibson
2007-06-19  5:42 ` David Gibson
2007-06-19  6:16   ` Segher Boessenkool [this message]
2007-06-19  8:40   ` Gerhard Pircher
2007-06-19  9:14     ` Segher Boessenkool
2007-06-19  9:52       ` Gerhard Pircher
2007-06-19 10:08         ` Segher Boessenkool
2007-06-19 12:37           ` Gerhard Pircher
2007-06-19 13:15             ` Segher Boessenkool
2007-06-19 13:29               ` Gerhard Pircher
2007-06-21 12:42   ` Benjamin Herrenschmidt
2007-06-21 13:28     ` Gerhard Pircher
2007-06-21 14:59       ` Segher Boessenkool
2007-06-21 14:29     ` Segher Boessenkool
2007-06-21 23:25       ` Benjamin Herrenschmidt
2007-06-22  7:52         ` Segher Boessenkool
2007-06-22  8:16           ` Benjamin Herrenschmidt
2007-06-22  9:10             ` Segher Boessenkool
2007-06-19  6:08 ` Segher Boessenkool
2007-06-19  9:08   ` Gerhard Pircher
2007-06-19  9:28     ` Segher Boessenkool
2007-06-21 12:36 ` Benjamin Herrenschmidt
2007-06-21 13:20   ` Gerhard Pircher
2007-06-21 14:38     ` Segher Boessenkool
2007-06-21 16:27       ` Gerhard Pircher
2007-06-21 23:22     ` Benjamin Herrenschmidt
2007-06-22 13:12       ` Gerhard Pircher
2007-06-22 13:40         ` Benjamin Herrenschmidt
2007-06-21 14:24   ` Segher Boessenkool
2007-06-21 16:21     ` Gerhard Pircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69de6646562b9fb3432909afff57a962@kernel.crashing.org \
    --to=segher@kernel$(echo .)crashing.org \
    --cc=david@gibson$(echo .)dropbear.id.au \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox