From: Michael Neuling <mikey@neuling•org>
To: Joel Schopp <jschopp@austin•ibm.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc: update ibm,client-architecture
Date: Tue, 22 Dec 2009 08:12:15 +1100 [thread overview]
Message-ID: <7024.1261429935@neuling.org> (raw)
In-Reply-To: <4B2FBB3F.8030703@austin.ibm.com>
> >> Subject: Re: [PATCH] powerpc: update ibm,client-architecture
> >>
> >
> > Please give this a more appropriate name.
> >
> Any suggestions?
Something that's more descriptive of what the patch does. Say "Add
max CPU nodes field to ibm,client-architecture call"
> >
> >> In order to boot with more than 64 cores on machines that support the
> >> ibm,client-architecture RTAS call a new field has been added to the
> >> structure. This patch updates that field and adds a few others in the
> >> process.
> >>
> >
> > Please detail what these are here.
> >
> OK.
> >> + W(NR_CPUS/4), /* max cores supported */
FYI reading the PAPR, this comment should technically be "max 'cpu'
nodes presented".
> >>
> >
> > 4?
> >
> >
> 4 is the new 2.
I'd still be asking what 2 is. It's needs a #define to make clearer
what you are doing.
> Since you don't know the actual threads per core at
> this point in boot you have to be conservative and go with the maximum
> number of any processor. See page 4 of these charts:
> http://www.power.org/events/powercon09/taiwan09/IBM_Overview_POWER7.pdf
I don't think hard wiring 4 in here is right. If we are booting a
machine with SMT2, we will put only half the number of cores that we can
handle in this field. This is going to break a lot of machines where
people have compiled with NR_CPUS = thread number.
I think you just want to put NR_CPUS here.
Mikey
> >
> >
> > Can we do this now or remove the comment. Maybe UTS_RELEASE or
> > something like that.
> >
> I'll just remove the comment for now.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists•ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2009-12-21 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 21:07 [PATCH] powerpc: update ibm,client-architecture Joel Schopp
2009-12-20 23:59 ` Michael Neuling
2009-12-21 18:15 ` Joel Schopp
2009-12-21 21:12 ` Michael Neuling [this message]
2009-12-21 22:14 ` Joel Schopp
2009-12-22 0:33 ` Michael Neuling
2009-12-22 0:58 ` Tony Breeds
2009-12-21 0:44 ` Tony Breeds
2009-12-21 18:22 ` Joel Schopp
2009-12-22 0:18 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7024.1261429935@neuling.org \
--to=mikey@neuling$(echo .)org \
--cc=jschopp@austin$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox