From: Milton Miller <miltonm@bga•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH 4/7] bootwrapper: add a fatal error helper
Date: Tue, 20 Mar 2007 08:38:45 -0500 [thread overview]
Message-ID: <7a08cdfd3ee0f04ed3e96601c9698de6@bga.com> (raw)
In-Reply-To: <20070320003847.GB19728@localhost.localdomain>
On Mar 19, 2007, at 7:38 PM, David Gibson wrote:
> On Mon, Mar 19, 2007 at 02:58:03PM -0600, Milton Miller wrote:
>> Add a macro fatal that calls printf then exit. User must include
>> stdio.h.
>>
>> Typically replaces 3 lines with 1, although I added back some
>> whitespace.
>>
>> Signed-off-by: Milton Miller <miltonm@bga•com>
>
> One tiny nit...
>
> [snip]
>> Index: kernel/arch/powerpc/boot/ops.h
>> ===================================================================
>> --- kernel.orig/arch/powerpc/boot/ops.h 2007-03-19 08:32:50.000000000
>> -0500
>> +++ kernel/arch/powerpc/boot/ops.h 2007-03-19 08:33:02.000000000 -0500
>> @@ -157,6 +157,8 @@ static inline void exit(void)
>> platform_ops.exit();
>> for(;;);
>> }
>> +#define fatal(args...) { printf(args); exit(); }
>> +
>
> This is the old gcc way of doing a varargs macro, not the new C99
> way. The new way would be:
>
> #define fata(...) { printf(__VA_ARGS__); exit(); }
>
I was following the example of fprintf in stdio.h. Is the new C99
way used elsewhere in the kernel?
milton
next prev parent reply other threads:[~2007-03-20 13:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 20:55 [PATCH 0/7] boot: cleanup and prep for more platforms Milton Miller
2007-03-19 20:58 ` [PATCH 4/7] bootwrapper: add a fatal error helper Milton Miller
2007-03-20 0:38 ` David Gibson
2007-03-20 13:38 ` Milton Miller [this message]
2007-03-21 0:01 ` David Gibson
2007-03-19 20:58 ` [PATCH 3/7] boot: use FORCE Milton Miller
2007-03-20 15:52 ` Segher Boessenkool
2007-03-19 20:58 ` [PATCH 2/7] boot: rebuild when wrapper changes Milton Miller
2007-03-20 0:36 ` David Gibson
2007-03-20 15:50 ` Segher Boessenkool
2007-03-19 20:58 ` [PATCH 6/7] bootwrapper: allow platforms to call library zImage_start Milton Miller
2007-03-20 4:55 ` David Gibson
2007-03-19 20:58 ` [PATCH 5/7] bootwrapper: missing relocation in crt0.S Milton Miller
2007-03-20 0:39 ` David Gibson
2007-03-20 20:09 ` Mark A. Greer
2007-03-19 20:58 ` [PATCH 7/7] boot: export flush_cache Milton Miller
2007-03-20 4:55 ` David Gibson
2007-03-19 20:58 ` [PATCH 1/7] boot: use a common zImage rule Milton Miller
2007-03-20 3:30 ` David Gibson
2007-03-20 13:47 ` Milton Miller
2007-03-20 17:41 ` Mark A. Greer
2007-03-21 2:46 ` David Gibson
2007-03-21 15:02 ` [PATCH 0/8] boot: cleanup and prep for more platforms Milton Miller
2007-03-21 15:02 ` [PATCH 6/8] boot: use FORCE Milton Miller
2007-03-21 15:02 ` [PATCH 1/8] bootwrapper: add a fatal error helper Milton Miller
2007-03-21 15:02 ` [PATCH 5/8] boot: rebuild when wrapper changes Milton Miller
2007-03-21 15:02 ` [PATCH 3/8] bootwrapper: allow platforms to call library zImage_start Milton Miller
2007-03-21 15:02 ` [PATCH 2/8] bootwrapper: missing relocation in crt0.S Milton Miller
2007-03-23 5:25 ` Paul Mackerras
2007-03-28 8:21 ` [PATCH 0/4] boot: cleanup and prep for more platforms Milton Miller
2007-03-28 8:21 ` [PATCH 1/4] bootwrapper: missing relocation in crt0.S Milton Miller
2007-03-28 8:21 ` [RFC] bootwrapper: allow vmlinuz to be an external payload Milton Miller
2007-03-28 8:21 ` Patch: [PATCH 3/4] bootwrapper: no gzip fixes Milton Miller
2007-03-28 20:03 ` Scott Wood
2007-03-28 8:21 ` [PATCH 2/4] bootwrapper: remove unused variable Milton Miller
2007-03-28 8:34 ` David Gibson
2007-03-28 16:04 ` Milton Miller
2007-03-28 8:21 ` [PATCH 4/4] bootwrapper: decompress less, check more Milton Miller
2007-03-29 13:31 ` Milton Miller
2007-03-21 15:03 ` [PATCH 4/8] boot: export flush_cache Milton Miller
2007-03-21 15:03 ` [PATCH 7/8] boot: clean rule fixes Milton Miller
2007-03-21 15:03 ` [PATCH 8/8] boot: use a common zImage rule Milton Miller
2007-03-22 3:46 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a08cdfd3ee0f04ed3e96601c9698de6@bga.com \
--to=miltonm@bga$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox