From: Balbir Singh <bsingharora@gmail•com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@ozlabs•org>,
Michael Ellerman <mpe@ellerman•id.au>
Subject: Re: [PATCH 1/3] Setup AMOR in HV mode
Date: Fri, 11 Nov 2016 17:15:28 +1100 [thread overview]
Message-ID: <7ff5fdfd-751a-a435-c2be-439ae849ed00@gmail.com> (raw)
In-Reply-To: <87a8da2edy.fsf@linux.vnet.ibm.com>
On 09/11/16 02:13, Aneesh Kumar K.V wrote:
> Balbir Singh <bsingharora@gmail•com> writes:
>
>> AMOR should be setup in HV mode, we set it up once
>> and let the generic kernel handle IAMR. This patch is
>> used to enable storage keys in a following patch as
>> defined in ISA 3
>>
>> Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux•vnet.ibm.com>
>> Signed-off-by: Balbir Singh <bsingharora@gmail•com>
>> ---
>> arch/powerpc/mm/pgtable-radix.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/powerpc/mm/pgtable-radix.c b/arch/powerpc/mm/pgtable-radix.c
>> index ed7bddc..0fdd8ed 100644
>> --- a/arch/powerpc/mm/pgtable-radix.c
>> +++ b/arch/powerpc/mm/pgtable-radix.c
>> @@ -320,6 +320,25 @@ static void update_hid_for_radix(void)
>> cpu_relax();
>> }
>>
>> +/*
>> + * In HV mode, we init AMOR so that the hypervisor
>> + * and guest can setup IMAR, enable key 0 and set
>> + * it to 1
>> + * AMOR = 1100....00 (Mask for key 0 is 11)
>> + */
>> +static void __init radix_init_amor(void)
>> +{
>> + unsigned long amor_mask = 0xc000000000000000;
>> + unsigned long amor = mfspr(SPRN_AMOR);
>> +
>> + if (cpu_has_feature(CPU_FTR_POWER9_DD1))
>> + return;
>
> Why is DD1 excluded ?
>
>> +
>> + amor |= amor_mask;
>> +
>
> Can't we just init it with the constant 0xc000000000000000;
> I can understand kvm code wanting to do the '|' above, but does the host
> init code need to look at the previous value there ?
>
>
>> + mtspr(SPRN_AMOR, amor);
>> +}
>> +
>> void __init radix__early_init_mmu(void)
>> {
>> unsigned long lpcr;
>> @@ -376,6 +395,7 @@ void __init radix__early_init_mmu(void)
>> lpcr = mfspr(SPRN_LPCR);
>> mtspr(SPRN_LPCR, lpcr | LPCR_UPRT | LPCR_HR);
>> radix_init_partition_table();
>> + radix_init_amor();
>> }
>>
>> radix_init_pgtable();
>
> What about secondaries ? Don't we need to init AMOR there ?
My bad, I should have checked and caught this
Balbir Singh
next prev parent reply other threads:[~2016-11-11 6:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 13:38 [PATCH 0/3] Enable IAMR storage keys for radix Balbir Singh
2016-11-01 13:38 ` [PATCH 1/3] Setup AMOR in HV mode Balbir Singh
2016-11-08 15:13 ` Aneesh Kumar K.V
2016-11-11 6:15 ` Balbir Singh [this message]
2016-11-01 13:38 ` [PATCH 2/3] Detect instruction fetch denied and report Balbir Singh
2016-11-08 16:09 ` Aneesh Kumar K.V
2016-11-11 6:14 ` Balbir Singh
2016-11-08 16:16 ` Aneesh Kumar K.V
2016-11-01 13:38 ` [PATCH 3/3] Enable storage keys for radix - user mode execution Balbir Singh
2016-11-08 16:15 ` Aneesh Kumar K.V
2016-11-11 6:02 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ff5fdfd-751a-a435-c2be-439ae849ed00@gmail.com \
--to=bsingharora@gmail$(echo .)com \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox