Subject: Re: [PATCH 3/5] powerpc: Document device nodes for I2C devices.

From: Segher Boessenkool <[email-masked]>
Date: Thu, 17 May 2007 21:18:15 +0200

> +   Required properties :
> +
> +    - reg : Unshifted 7-bit I2C address for the device

What about 10-bit addressing, etc.?

> +   Recommended properties :
> +
> +    - compatible : The name of the Linux device driver that
> +      handles this device.  If unspecified, the name of the
> +      node will be used.

NO WAY

> +    - interrupts : <a b> where a is the interrupt number and b is a

I2C doesn't do interrupts, this doesn't belong in
an I2C binding; it's redundant anyway (and incorrect
as well).

I second most of Kumar's sentiments, too.

Segher