From: Segher Boessenkool <segher@kernel•crashing.org>
To: Timur Tabi <timur@freescale•com>
Cc: Stuart Yoder <stuart.yoder@freescale•com>,
linuxppc-dev@ozlabs•org, paulus@samba•org, g.liakhovetski@gmx•de
Subject: Re: [PATCH v3] powerpc: delete boot-cpu property from all DTS files
Date: Thu, 15 Feb 2007 02:30:37 +0100 [thread overview]
Message-ID: <8554ec6810844cd79a8ad3eb2dda33a0@kernel.crashing.org> (raw)
In-Reply-To: <11714885473600-git-send-email-timur@freescale.com>
While you're at it...
> -The /cpus/PowerPC,970@0/linux,boot-cpu property is an example of a
> +The /cpus/PowerPC,970@0/64-bit property is an example of a
> property without a value. All other properties have a value. The
s/All other properties/All other properties in this example/
I had to read this ten times before understanding what was meant :-)
Also, why is there a special header for this in the device tree
blob? It could just have reused /chosen/cpu (with an identity
ihandle>phandle mapping perhaps) -- just like the /aliases node
could be used for aliases, instead of this new labels scheme.
Why reinvent the wheel :-)
Patch looks good of course.
Segher
next prev parent reply other threads:[~2007-02-15 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 21:29 [PATCH v3] powerpc: delete boot-cpu property from all DTS files Timur Tabi
2007-02-15 0:53 ` David Gibson
2007-02-15 16:04 ` Timur Tabi
2007-02-15 1:30 ` Segher Boessenkool [this message]
2007-02-15 15:28 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8554ec6810844cd79a8ad3eb2dda33a0@kernel.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=g.liakhovetski@gmx$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=stuart.yoder@freescale$(echo .)com \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox